[PATCH 19/29] s3c-fb: use display information in info not in var for panning

[PATCH 19/29] s3c-fb: use display information in info not in var for panning

[Laurent Pinchart]

We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ben Dooks <ben@simtec.co.uk>
Cc: InKi Dae <inki.dae@samsung.com>
---
 drivers/video/s3c-fb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 3b6cdca..4fce307 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -882,7 +882,7 @@ static int s3c_fb_pan_display(struct fb_var_screeninfo *var,
 		}
 	}
 	/* Offset in bytes to the end of the displayed area */
-	end_boff = start_boff + var->yres * info->fix.line_length;
+	end_boff = start_boff + info->var.yres * info->fix.line_length;
 
 	/* Temporarily turn off per-vsync update from shadow registers until
 	 * both start and end addresses are updated to prevent corruption */
-- 
1.7.3.4

Re: [PATCH 19/29] s3c-fb: use display information in info not in var

[한진구]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1378 bytes --]


Acked-by: Jingoo Han <jg1.han@samsung.com>

> ------- Original Message -------
> Sender : Laurent Pinchart<laurent.pinchart@ideasonboard.com> 
> Date   : 2011-05-26 07:58 (GMT+09:00)
> Title  : [PATCH 19/29] s3c-fb: use display information in info not in var for
>  panning
> 
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Ben Dooks <ben@simtec.co.uk>
> Cc: InKi Dae <inki.dae@samsung.com>
> ---
>  drivers/video/s3c-fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 3b6cdca..4fce307 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -882,7 +882,7 @@ static int s3c_fb_pan_display(struct fb_var_screeninfo *var,
>  		}
>  	}
 > 	/* Offset in bytes to the end of the displayed area */
> -	end_boff = start_boff + var->yres * info->fix.line_length;
> +	end_boff = start_boff + info->var.yres * info->fix.line_length;
>  
>  	/* Temporarily turn off per-vsync update from shadow registers until
>  	 * both start and end addresses are updated to prevent corruption */
> -- 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm