[PATCH] 8250_pci: Fix build warning

[PATCH] 8250_pci: Fix build warning

[Borislav Petkov]

Fix

drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type

by constifying the serial board :).

Cc: Antony Pavlov <antony@niisi.msk.ru>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
 drivers/tty/serial/8250_pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
index 4b4968a..c9c9e6f 100644
--- a/drivers/tty/serial/8250_pci.c
+++ b/drivers/tty/serial/8250_pci.c
@@ -973,8 +973,8 @@ ce4100_serial_setup(struct serial_private *priv,
 
 static int
 pci_omegapci_setup(struct serial_private *priv,
-		      struct pciserial_board *board,
-		      struct uart_port *port, int idx)
+		   const struct pciserial_board *board,
+		   struct uart_port *port, int idx)
 {
 	return setup_port(priv, port, 2, idx * 8, 0);
 }
-- 
1.7.5.rc1.16.g9db1

Re: [PATCH] 8250_pci: Fix build warning

[Borislav Petkov]

Hey Greg,

can you please pick this one up - warning is still present in -rc2 so it
looks like no one else fixed it yet :).

Thanks.

On Mon, May 30, 2011 at 11:52:54AM +0200, Borislav Petkov wrote:
> Fix
> 
> drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type
> 
> by constifying the serial board :).
> 
> Cc: Antony Pavlov <antony@niisi.msk.ru>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Borislav Petkov <bp@alien8.de>
> ---
>  drivers/tty/serial/8250_pci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
> index 4b4968a..c9c9e6f 100644
> --- a/drivers/tty/serial/8250_pci.c
> +++ b/drivers/tty/serial/8250_pci.c
> @@ -973,8 +973,8 @@ ce4100_serial_setup(struct serial_private *priv,
>  
>  static int
>  pci_omegapci_setup(struct serial_private *priv,
> -		      struct pciserial_board *board,
> -		      struct uart_port *port, int idx)
> +		   const struct pciserial_board *board,
> +		   struct uart_port *port, int idx)
>  {
>  	return setup_port(priv, port, 2, idx * 8, 0);
>  }
> -- 
> 1.7.5.rc1.16.g9db1
> 
> 

-- 
Regards/Gruss,
    Boris.

Re: [PATCH] 8250_pci: Fix build warning

[Greg KH]

On Tue, Jun 07, 2011 at 09:26:17AM +0200, Borislav Petkov wrote:
> Hey Greg,
> 
> can you please pick this one up - warning is still present in -rc2 so it
> looks like no one else fixed it yet :).

Sorry, bad jet-lag at the moment, I have it in my "to-apply" queue,
along with about 8 different copies of it from different people, and
I'll get to it in a short while.

greg k-h