All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Print the pixel clock of each mode.
@ 2011-05-30 15:55 yi.sun
  2011-05-31  9:01 ` Paul Menzel
  0 siblings, 1 reply; 2+ messages in thread
From: yi.sun @ 2011-05-30 15:55 UTC (permalink / raw)
  To: intel-gfx

From: Sun Yi <yi.sun@intel.com>

---
 tests/testdisplay.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index 41a5753..1efc6e5 100644
--- a/tests/testdisplay.c
+++ b/tests/testdisplay.c
@@ -157,7 +157,7 @@ struct connector {
 
 static void dump_mode(drmModeModeInfo *mode)
 {
-	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
+	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d\n",
 	       mode->name,
 	       mode->vrefresh,
 	       mode->hdisplay,
@@ -169,7 +169,8 @@ static void dump_mode(drmModeModeInfo *mode)
 	       mode->vsync_end,
 	       mode->vtotal,
 	       mode->flags,
-	       mode->type);
+	       mode->type,
+	       mode->clock);
 }
 
 static void dump_connectors(void)
@@ -201,7 +202,7 @@ static void dump_connectors(void)
 
 		printf("  modes:\n");
 		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
-		       "vss vse vtot flags type\n");
+		       "vss vse vtot flags type clock\n");
 		for (j = 0; j < connector->count_modes; j++)
 			dump_mode(&connector->modes[j]);
 
-- 
1.7.5.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Print the pixel clock of each mode.
  2011-05-30 15:55 [PATCH] Print the pixel clock of each mode yi.sun
@ 2011-05-31  9:01 ` Paul Menzel
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Menzel @ 2011-05-31  9:01 UTC (permalink / raw)
  To: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 1624 bytes --]

Dear Sun,


Am Montag, den 30.05.2011, 23:55 +0800 schrieb yi.sun@intel.com:
> From: Sun Yi <yi.sun@intel.com>

is a Signed-off-by line needed to get your patch accepted? You can add
it automatically passing `-s` to `git commit` or `git format-patch`.

Additionally next time you could add an example output before and after
your change to the commit message.

> ---
>  tests/testdisplay.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index 41a5753..1efc6e5 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -157,7 +157,7 @@ struct connector {
>  
>  static void dump_mode(drmModeModeInfo *mode)
>  {
> -	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
> +	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d\n",
>  	       mode->name,
>  	       mode->vrefresh,
>  	       mode->hdisplay,
> @@ -169,7 +169,8 @@ static void dump_mode(drmModeModeInfo *mode)
>  	       mode->vsync_end,
>  	       mode->vtotal,
>  	       mode->flags,
> -	       mode->type);
> +	       mode->type,
> +	       mode->clock);
>  }
>  
>  static void dump_connectors(void)
> @@ -201,7 +202,7 @@ static void dump_connectors(void)
>  
>  		printf("  modes:\n");
>  		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
> -		       "vss vse vtot flags type\n");
> +		       "vss vse vtot flags type clock\n");
>  		for (j = 0; j < connector->count_modes; j++)
>  			dump_mode(&connector->modes[j]);
>  

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-31  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-30 15:55 [PATCH] Print the pixel clock of each mode yi.sun
2011-05-31  9:01 ` Paul Menzel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.