From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Sergei Shtylyov <sshtylyov@mvista.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/8] MTD: Add integrator-flash feature to physmap
Date: Wed, 01 Jun 2011 10:42:46 +0300 [thread overview]
Message-ID: <1306914166.4405.47.camel@localhost> (raw)
In-Reply-To: <BANLkTim0xrx+33BeoSbXbQcu2Ab6Oin=Wg@mail.gmail.com>
On Tue, 2011-05-31 at 22:20 -0400, Mike Frysinger wrote:
> On Tue, May 31, 2011 at 17:44, Marc Zyngier wrote:
> > On Tue, 31 May 2011 23:11:14 +0400 Sergei Shtylyov wrote:
> >> Marc Zyngier wrote:
> >> > In the process of moving platforms away from integrator-flash
> >> > (aka armflash), add to physmap the few features that make
> >> > armflash unique:
> >>
> >> > - optionnal probing for the AFS partition type
> >> > - init() and exit() methods, used by Integrator to control
> >> > write access to the various onboard programmable components
> >>
> >> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> >> > Cc: David Woodhouse <dwmw2@infradead.org>
> >> [...]
> >>
> >> > diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
> >> > index bcfd9f7..d37cca0 100644
> >> > --- a/include/linux/mtd/physmap.h
> >> > +++ b/include/linux/mtd/physmap.h
> >> > @@ -22,6 +22,8 @@ struct map_info;
> >> >
> >> > struct physmap_flash_data {
> >> > unsigned int width;
> >> > + int (*init)(struct platform_device *);
> >> > + void (*exit)(struct platform_device *);
> >>
> >> How about a declaration for 'struct platform_device' beforehand? This breaks
> >> build on other platforms at least...
> >
> > Sure. Please send a patch.
>
> uhh, what ? you broke things, so you fix them. i already pointed out
> this breakage to you over a week ago.
> -mike
The change went in via Russell's tree, I sent him a fix. It looks like
he did not merge it. Now I'm not sure who should merge this patch. I'll
ping dwmw2.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/8] MTD: Add integrator-flash feature to physmap
Date: Wed, 01 Jun 2011 10:42:46 +0300 [thread overview]
Message-ID: <1306914166.4405.47.camel@localhost> (raw)
In-Reply-To: <BANLkTim0xrx+33BeoSbXbQcu2Ab6Oin=Wg@mail.gmail.com>
On Tue, 2011-05-31 at 22:20 -0400, Mike Frysinger wrote:
> On Tue, May 31, 2011 at 17:44, Marc Zyngier wrote:
> > On Tue, 31 May 2011 23:11:14 +0400 Sergei Shtylyov wrote:
> >> Marc Zyngier wrote:
> >> > In the process of moving platforms away from integrator-flash
> >> > (aka armflash), add to physmap the few features that make
> >> > armflash unique:
> >>
> >> > - optionnal probing for the AFS partition type
> >> > - init() and exit() methods, used by Integrator to control
> >> > write access to the various onboard programmable components
> >>
> >> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> >> > Cc: David Woodhouse <dwmw2@infradead.org>
> >> [...]
> >>
> >> > diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
> >> > index bcfd9f7..d37cca0 100644
> >> > --- a/include/linux/mtd/physmap.h
> >> > +++ b/include/linux/mtd/physmap.h
> >> > @@ -22,6 +22,8 @@ struct map_info;
> >> >
> >> > struct physmap_flash_data {
> >> > unsigned int width;
> >> > + int (*init)(struct platform_device *);
> >> > + void (*exit)(struct platform_device *);
> >>
> >> How about a declaration for 'struct platform_device' beforehand? This breaks
> >> build on other platforms at least...
> >
> > Sure. Please send a patch.
>
> uhh, what ? you broke things, so you fix them. i already pointed out
> this breakage to you over a week ago.
> -mike
The change went in via Russell's tree, I sent him a fix. It looks like
he did not merge it. Now I'm not sure who should merge this patch. I'll
ping dwmw2.
--
Best Regards,
Artem Bityutskiy (????? ????????)
next prev parent reply other threads:[~2011-06-01 7:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 13:11 [PATCH v6 0/8] Switch ARM platforms from integrator-flash to physmap Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 1/8] MTD: Add integrator-flash feature " Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-19 11:14 ` Artem Bityutskiy
2011-05-19 11:14 ` Artem Bityutskiy
2011-05-31 19:11 ` Sergei Shtylyov
2011-05-31 19:11 ` Sergei Shtylyov
2011-05-31 21:44 ` Marc Zyngier
2011-05-31 21:44 ` Marc Zyngier
2011-06-01 2:20 ` Mike Frysinger
2011-06-01 2:20 ` Mike Frysinger
2011-06-01 7:42 ` Artem Bityutskiy [this message]
2011-06-01 7:42 ` Artem Bityutskiy
2011-06-01 16:32 ` Sergei Shtylyov
2011-06-01 16:32 ` Sergei Shtylyov
2011-06-01 7:49 ` Marc Zyngier
2011-06-01 7:49 ` Marc Zyngier
2011-06-01 9:43 ` Artem Bityutskiy
2011-06-01 9:43 ` Artem Bityutskiy
2011-06-01 16:28 ` Sergei Shtylyov
2011-06-01 16:28 ` Sergei Shtylyov
2011-05-17 13:11 ` [PATCH v6 2/8] ARM: Realview: Use physmap driver instead of integrator-flash Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 3/8] ARM: Versatile: " Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 4/8] ARM: VExpress: " Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 5/8] ARM: Integrator/AP: " Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 6/8] ARM: Integrator/CP: " Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-17 13:11 ` [PATCH v6 7/8] MTD: Remove integrator-flash Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-19 11:14 ` Artem Bityutskiy
2011-05-19 11:14 ` Artem Bityutskiy
2011-05-17 13:11 ` [PATCH v6 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info Marc Zyngier
2011-05-17 13:11 ` Marc Zyngier
2011-05-19 11:17 ` Artem Bityutskiy
2011-05-19 11:17 ` Artem Bityutskiy
2011-05-19 17:37 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-19 17:37 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-19 11:19 ` [PATCH v6 0/8] Switch ARM platforms from integrator-flash to physmap Artem Bityutskiy
2011-05-19 11:19 ` Artem Bityutskiy
2011-05-19 12:53 ` Marc Zyngier
2011-05-19 12:53 ` Marc Zyngier
2011-05-20 21:28 ` Russell King - ARM Linux
2011-05-20 21:28 ` Russell King - ARM Linux
2011-05-23 15:01 ` Artem Bityutskiy
2011-05-23 15:01 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306914166.4405.47.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=sshtylyov@mvista.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.