All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Oliver Neukum <oliver@neukum.name>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: cdc_ncm: Ericsson F5521gw appears as usbX, while Ericsson F3507g as wwanX
Date: Wed,  1 Jun 2011 12:08:32 +0200	[thread overview]
Message-ID: <1306922913-17803-1-git-send-email-metze@samba.org> (raw)

Hi,

commit e1e499eef2200c2a7120c9ebf297d48b195cf887
"usbnet: Use wwan%d interface name for mobile broadband devices"
introducted the FLAG_WWAN flag and caused the Ericsson F3507g
modem to appear as wwanX device instead of usbX.

commit c261344d3ce3edac781f9d3c7eabe2e96d8e8fe8
"usbnet: use eth%d name for known ethernet devices"
introduced the FLAG_POINTTOPOINT and added it to
the cdc_ncm modules without the FLAG_ETHER.

I'm wondering if the FLAG_POINTTOPOINT (without FLAG_ETHER)
should be changed to FLAG_WWAN instead.

I've changed that for the cdc_ncm driver in order to make Ericsson F5521gw
appear as wwanX, but I'm not sure if it's correct for all devices which
are supported by the cdc_ncm driver.

Maybe this should apply to all drivers in drivers/net/usb?

The following patch is just an example of what I'm currently using,
a possible upstream patch may need to look differently.

Comments please.

metze


             reply	other threads:[~2011-06-01 10:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 10:08 Stefan Metzmacher [this message]
2011-06-01 10:08 ` [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN Stefan Metzmacher
2011-06-01 10:20   ` Alexey ORISHKO
2011-06-01 10:47     ` Stefan (metze) Metzmacher
2011-06-01 11:39       ` Alexey ORISHKO
2011-06-01 11:54         ` Stefan (metze) Metzmacher
2011-06-01 12:27           ` Alexey ORISHKO
2011-06-03  9:35             ` Stefan (metze) Metzmacher
2011-06-02 22:29     ` Dan Williams
2011-06-02 22:35       ` Dan Williams
2011-06-03  0:58         ` Valdis.Kletnieks
2011-06-03  9:45           ` Alexey ORISHKO
2011-06-03  9:45             ` Alexey ORISHKO
2011-06-03 10:01             ` Oliver Neukum
2011-06-03 10:23               ` Alexey ORISHKO
2011-06-03 10:50                 ` Oliver Neukum
2011-06-03 11:47                   ` Alexey ORISHKO
2011-06-03 11:47                     ` Alexey ORISHKO
2011-06-03 12:31                   ` Bjørn Mork
2011-06-03 19:24             ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306922913-17803-1-git-send-email-metze@samba.org \
    --to=metze@samba.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.