All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey ORISHKO <alexey.orishko@stericsson.com>
To: "Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>,
	Dan Williams <dcbw@redhat.com>
Cc: Stefan Metzmacher <metze@samba.org>,
	Oliver Neukum <oliver@neukum.name>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN
Date: Fri, 3 Jun 2011 11:45:38 +0200	[thread overview]
Message-ID: <2AC7D4AD8BA1C640B4C60C61C8E520153E3C13B5F2@EXDCVYMBSTM006.EQ1STM.local> (raw)
In-Reply-To: <5203.1307062683@turing-police.cc.vt.edu>

> -----Original Message-----
> From: Valdis.Kletnieks@vt.edu [mailto:Valdis.Kletnieks@vt.edu]
> Sent: Friday, June 03, 2011 2:58 AM
> 
> > A follow-on to this is that if you really care about specific
> devices,
> > your application can use udev rules to "tag" specific interfaces
> based
> > on USB VID/PID/GUID or other device attributes, and check for those
> > tags in your program.  Use udev (good) or netlink (good) or
> > SIOCGIFCONF (bad) to enumerate the various network interfaces on the
> > system and pick the
> 
> I think Alexey's point was that the patch will hose up programs that
> currently do the netlink or  SIOCGIFCONF thing and look for
> FLAG_POINTTOPOINT.

Just to clarify, I was objecting to renaming interface name mostly because
devices which use CDC NCM function might be something different from wwan
devices. I would prefer to keep a generic name of interface (usbX or ethX).

As an option anyone can use udev rules to set interface name they want 
for their device based on VID/PID or MAC address or something else.
I've already provided udev rule example earlier in this thread.

Dan, is it in line with your statement?

/alexey


WARNING: multiple messages have this Message-ID (diff)
From: Alexey ORISHKO <alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
To: "Valdis.Kletnieks-PjAqaU27lzQ@public.gmane.org"
	<Valdis.Kletnieks-PjAqaU27lzQ@public.gmane.org>,
	Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	Oliver Neukum <oliver-Q6YOFhsQ4GZ7tPAFqOLdPg@public.gmane.org>,
	Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN
Date: Fri, 3 Jun 2011 11:45:38 +0200	[thread overview]
Message-ID: <2AC7D4AD8BA1C640B4C60C61C8E520153E3C13B5F2@EXDCVYMBSTM006.EQ1STM.local> (raw)
In-Reply-To: <5203.1307062683-+bZmOdGhbsPr6rcHtW+onFJE71vCis6O@public.gmane.org>

> -----Original Message-----
> From: Valdis.Kletnieks-PjAqaU27lzQ@public.gmane.org [mailto:Valdis.Kletnieks-PjAqaU27lzQ@public.gmane.org]
> Sent: Friday, June 03, 2011 2:58 AM
> 
> > A follow-on to this is that if you really care about specific
> devices,
> > your application can use udev rules to "tag" specific interfaces
> based
> > on USB VID/PID/GUID or other device attributes, and check for those
> > tags in your program.  Use udev (good) or netlink (good) or
> > SIOCGIFCONF (bad) to enumerate the various network interfaces on the
> > system and pick the
> 
> I think Alexey's point was that the patch will hose up programs that
> currently do the netlink or  SIOCGIFCONF thing and look for
> FLAG_POINTTOPOINT.

Just to clarify, I was objecting to renaming interface name mostly because
devices which use CDC NCM function might be something different from wwan
devices. I would prefer to keep a generic name of interface (usbX or ethX).

As an option anyone can use udev rules to set interface name they want 
for their device based on VID/PID or MAC address or something else.
I've already provided udev rule example earlier in this thread.

Dan, is it in line with your statement?

/alexey

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-06-03  9:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 10:08 cdc_ncm: Ericsson F5521gw appears as usbX, while Ericsson F3507g as wwanX Stefan Metzmacher
2011-06-01 10:08 ` [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN Stefan Metzmacher
2011-06-01 10:20   ` Alexey ORISHKO
2011-06-01 10:47     ` Stefan (metze) Metzmacher
2011-06-01 11:39       ` Alexey ORISHKO
2011-06-01 11:54         ` Stefan (metze) Metzmacher
2011-06-01 12:27           ` Alexey ORISHKO
2011-06-03  9:35             ` Stefan (metze) Metzmacher
2011-06-02 22:29     ` Dan Williams
2011-06-02 22:35       ` Dan Williams
2011-06-03  0:58         ` Valdis.Kletnieks
2011-06-03  9:45           ` Alexey ORISHKO [this message]
2011-06-03  9:45             ` Alexey ORISHKO
2011-06-03 10:01             ` Oliver Neukum
2011-06-03 10:23               ` Alexey ORISHKO
2011-06-03 10:50                 ` Oliver Neukum
2011-06-03 11:47                   ` Alexey ORISHKO
2011-06-03 11:47                     ` Alexey ORISHKO
2011-06-03 12:31                   ` Bjørn Mork
2011-06-03 19:24             ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2AC7D4AD8BA1C640B4C60C61C8E520153E3C13B5F2@EXDCVYMBSTM006.EQ1STM.local \
    --to=alexey.orishko@stericsson.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=dcbw@redhat.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.