* [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit()
@ 2011-06-01 8:53 Wei Yongjun
2011-06-01 13:54 ` WANG Cong
2011-06-01 15:07 ` Eric Dumazet
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2011-06-01 8:53 UTC (permalink / raw)
To: David Miller, Eric Dumazet; +Cc: netdev
commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless
transmit path) have a typo in vlan_dev_hard_start_xmit(), using
u64_stats_update_begin() to end the stat update, it should be
u64_stats_update_end().
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/8021q/vlan_dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index f247f5b..7ea5cf9 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -165,7 +165,7 @@ static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
u64_stats_update_begin(&stats->syncp);
stats->tx_packets++;
stats->tx_bytes += len;
- u64_stats_update_begin(&stats->syncp);
+ u64_stats_update_end(&stats->syncp);
} else {
this_cpu_inc(vlan_dev_info(dev)->vlan_pcpu_stats->tx_dropped);
}
--
1.6.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit()
2011-06-01 8:53 [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit() Wei Yongjun
@ 2011-06-01 13:54 ` WANG Cong
2011-06-01 15:07 ` Eric Dumazet
1 sibling, 0 replies; 4+ messages in thread
From: WANG Cong @ 2011-06-01 13:54 UTC (permalink / raw)
To: netdev
On Wed, 01 Jun 2011 16:53:19 +0800, Wei Yongjun wrote:
> commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless transmit
> path) have a typo in vlan_dev_hard_start_xmit(), using
> u64_stats_update_begin() to end the stat update, it should be
> u64_stats_update_end().
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Yup, good catch!
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit()
2011-06-01 8:53 [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit() Wei Yongjun
2011-06-01 13:54 ` WANG Cong
@ 2011-06-01 15:07 ` Eric Dumazet
2011-06-02 4:09 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2011-06-01 15:07 UTC (permalink / raw)
To: Wei Yongjun; +Cc: David Miller, netdev
Le mercredi 01 juin 2011 à 16:53 +0800, Wei Yongjun a écrit :
> commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless
> transmit path) have a typo in vlan_dev_hard_start_xmit(), using
> u64_stats_update_begin() to end the stat update, it should be
> u64_stats_update_end().
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Good catch, Thanks !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit()
2011-06-01 15:07 ` Eric Dumazet
@ 2011-06-02 4:09 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-06-02 4:09 UTC (permalink / raw)
To: eric.dumazet; +Cc: yjwei, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Jun 2011 17:07:07 +0200
> Le mercredi 01 juin 2011 à 16:53 +0800, Wei Yongjun a écrit :
>> commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless
>> transmit path) have a typo in vlan_dev_hard_start_xmit(), using
>> u64_stats_update_begin() to end the stat update, it should be
>> u64_stats_update_end().
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> Good catch, Thanks !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied and queued up for -stable.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-02 4:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-01 8:53 [PATCH] vlan: fix typo in vlan_dev_hard_start_xmit() Wei Yongjun
2011-06-01 13:54 ` WANG Cong
2011-06-01 15:07 ` Eric Dumazet
2011-06-02 4:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.