[PATCH] btrfs: add CONFIG_BTRFS_DEBUG option

[PATCH] btrfs: add CONFIG_BTRFS_DEBUG option

[David Sterba]

Signed-off-by: David Sterba <dsterba@suse.cz>
---

lives in git://repo.or.cz/linux-2.6/btrfs-unstable.git #config-debug-option


 fs/btrfs/Kconfig |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index ecb9fd3..5601066 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -31,3 +31,13 @@ config BTRFS_FS_POSIX_ACL
 	  Linux website <http://acl.bestbits.at/>.
 
 	  If you don't know what Access Control Lists are, say N
+
+config BTRFS_DEBUG
+	bool "Btrfs debugging support"
+	depends on BTRFS_FS
+	help
+	  Enable run-time debugging support for the btrfs filesystem. This may
+	  enable additional and expensive checks with negative impact on
+	  performance, or export extra information via sysfs.
+
+	  If unsure, say N.
-- 
1.7.5.2.353.g5df3e

[PATCH] btrfs: move extra checks under debug option in btrfs_search_slot

[David Sterba]

CC: Josef Bacik <josef@redhat.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
---

this patch is in conflict with josef's patch

http://git.kernel.org/?p=linux/kernel/git/josef/btrfs-work.git;a=commit;h=98cdd9ffc5da7aa4c516347f7fc8f65cb08df6ae

 fs/btrfs/ctree.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index b0e18d9..4fe7634 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1648,9 +1648,11 @@ again:
 		}
 cow_done:
 		BUG_ON(!cow && ins_len);
+#ifdef CONFIG_BTRFS_DEBUG
 		if (level != btrfs_header_level(b))
 			WARN_ON(1);
 		level = btrfs_header_level(b);
+#endif
 
 		p->nodes[level] = b;
 		if (!p->skip_locking)
-- 
1.7.5.2.353.g5df3e

Re: [PATCH] btrfs: move extra checks under debug option in btrfs_search_slot

[Josef Bacik]

On 06/03/2011 08:09 AM, David Sterba wrote:
> CC: Josef Bacik <josef@redhat.com>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> 

Lets use this instead, I'll drop mine.  Thanks,

Reviewed-by: Josef Bacik <josef@redhat.com>