* [PATCH] savage: remove unecessary if statement
@ 2011-06-06 0:32 Greg Dietsche
2011-06-06 10:53 ` Nicolas Kaiser
0 siblings, 1 reply; 3+ messages in thread
From: Greg Dietsche @ 2011-06-06 0:32 UTC (permalink / raw)
To: airlied; +Cc: dri-devel, linux-kernel, Greg Dietsche
the code always returns ret regardless, so if(ret) check is unecessary.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
drivers/gpu/drm/savage/savage_bci.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index bf5f83e..cb1ee4e 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
_DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
&dev_priv->aperture);
- if (ret)
- return ret;
-
return ret;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] savage: remove unecessary if statement
2011-06-06 0:32 [PATCH] savage: remove unecessary if statement Greg Dietsche
@ 2011-06-06 10:53 ` Nicolas Kaiser
2011-06-13 14:40 ` [PATCH v2] savage: remove unnecessary " Greg Dietsche
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2011-06-06 10:53 UTC (permalink / raw)
To: Dave Airlie; +Cc: Greg Dietsche, dri-devel, linux-kernel
* Greg Dietsche <Gregory.Dietsche@cuw.edu>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Reviewed-by: Nicolas Kaiser <nikai@nikai.net>
Best regards,
Nicolas Kaiser
> ---
> drivers/gpu/drm/savage/savage_bci.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
> ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
> _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
> &dev_priv->aperture);
> - if (ret)
> - return ret;
> -
> return ret;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] savage: remove unnecessary if statement
2011-06-06 10:53 ` Nicolas Kaiser
@ 2011-06-13 14:40 ` Greg Dietsche
0 siblings, 0 replies; 3+ messages in thread
From: Greg Dietsche @ 2011-06-13 14:40 UTC (permalink / raw)
To: airlied; +Cc: nikai, dri-devel, linux-kernel, Greg Dietsche
the code always returns ret regardless, so if(ret) check is unnecessary.
v2: fixed up the spelling.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Reviewed-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/gpu/drm/savage/savage_bci.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index bf5f83e..cb1ee4e 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
_DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
&dev_priv->aperture);
- if (ret)
- return ret;
-
return ret;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-13 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-06 0:32 [PATCH] savage: remove unecessary if statement Greg Dietsche
2011-06-06 10:53 ` Nicolas Kaiser
2011-06-13 14:40 ` [PATCH v2] savage: remove unnecessary " Greg Dietsche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.