From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Nicolas Ferre <nicolas.ferre@atmel.com>, Patrice Vilchez <patrice.vilchez@atmel.com>, Alan Cox <alan@linux.intel.com>, Greg Kroah-Hartman <gregkh@suse.de> Subject: Re: [PATCH] atmel_serial: keep the platform_device unchanged Date: Wed, 08 Jun 2011 10:45:03 +0200 [thread overview] Message-ID: <1307522703.10626.9.camel@hcegtvedt.norway.atmel.com> (raw) In-Reply-To: <1302724038-26236-1-git-send-email-plagnioj@jcrosoft.com> On Wed, 2011-04-13 at 21:47 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > specify the port num via platform_data this will allow to match the clock > with the plaform_dev staticly Sure this works as intended, now the platform device id is off, and at least for my 3.0 testing it is no longer able to open the console, unless I explicit set the id field again. Example on NGW100 mkII I use USART instance 1 as serial console, if not setting the platform device id to 0 (re-mapping), then I get a warning about unable to open console. Is you clock optimization an additional patch? <snipp AT91 changes) > diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c > index bfc9d07..aa677e2 100644 > --- a/arch/avr32/mach-at32ap/at32ap700x.c > +++ b/arch/avr32/mach-at32ap/at32ap700x.c > @@ -1014,6 +1014,7 @@ static struct platform_device *__initdata at32_usarts[4]; > void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags) > { > struct platform_device *pdev; > + struct atmel_uart_data *pdata; > > switch (hw_id) { > case 0: > @@ -1042,7 +1043,8 @@ void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags) > data->regs = (void __iomem *)pdev->resource[0].start; > } > > - pdev->id = line; AVR32 needs this to be present to work independent of which USART peripheral the user chooses to use for console. > + pdata = pdev->dev.platform_data; > + pdata->num = portnr; > at32_usarts[line] = pdev; > } > <snipp> -- Hans-Christian Egtvedt
WARNING: multiple messages have this Message-ID (diff)
From: hans-christian.egtvedt@atmel.com (Hans-Christian Egtvedt) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] atmel_serial: keep the platform_device unchanged Date: Wed, 08 Jun 2011 10:45:03 +0200 [thread overview] Message-ID: <1307522703.10626.9.camel@hcegtvedt.norway.atmel.com> (raw) In-Reply-To: <1302724038-26236-1-git-send-email-plagnioj@jcrosoft.com> On Wed, 2011-04-13 at 21:47 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > specify the port num via platform_data this will allow to match the clock > with the plaform_dev staticly Sure this works as intended, now the platform device id is off, and at least for my 3.0 testing it is no longer able to open the console, unless I explicit set the id field again. Example on NGW100 mkII I use USART instance 1 as serial console, if not setting the platform device id to 0 (re-mapping), then I get a warning about unable to open console. Is you clock optimization an additional patch? <snipp AT91 changes) > diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c > index bfc9d07..aa677e2 100644 > --- a/arch/avr32/mach-at32ap/at32ap700x.c > +++ b/arch/avr32/mach-at32ap/at32ap700x.c > @@ -1014,6 +1014,7 @@ static struct platform_device *__initdata at32_usarts[4]; > void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags) > { > struct platform_device *pdev; > + struct atmel_uart_data *pdata; > > switch (hw_id) { > case 0: > @@ -1042,7 +1043,8 @@ void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags) > data->regs = (void __iomem *)pdev->resource[0].start; > } > > - pdev->id = line; AVR32 needs this to be present to work independent of which USART peripheral the user chooses to use for console. > + pdata = pdev->dev.platform_data; > + pdata->num = portnr; > at32_usarts[line] = pdev; > } > <snipp> -- Hans-Christian Egtvedt
next prev parent reply other threads:[~2011-06-08 8:45 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-13 19:47 [PATCH] atmel_serial: keep the platform_device unchanged Jean-Christophe PLAGNIOL-VILLARD 2011-04-13 19:47 ` Jean-Christophe PLAGNIOL-VILLARD 2011-04-13 21:58 ` Alan Cox 2011-04-13 21:58 ` Alan Cox 2011-04-15 19:02 ` Jean-Christophe PLAGNIOL-VILLARD 2011-04-15 19:02 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-08 8:45 ` Hans-Christian Egtvedt [this message] 2011-06-08 8:45 ` Hans-Christian Egtvedt 2011-06-08 13:47 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-08 13:47 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-08 13:47 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-08 14:02 ` Hans-Christian Egtvedt 2011-06-08 14:02 ` Hans-Christian Egtvedt 2011-06-17 3:06 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-17 3:06 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-17 3:06 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-21 14:28 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-21 14:28 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-21 14:28 ` Jean-Christophe PLAGNIOL-VILLARD 2011-06-21 14:31 ` [PATCH] atmel_serial: fix internal port num Jean-Christophe PLAGNIOL-VILLARD 2011-06-21 14:31 ` Jean-Christophe PLAGNIOL-VILLARD 2011-08-08 15:10 ` [PATCH] atmel_serial: fix atmel_default_console_device Nikolaus Voss 2011-08-09 11:41 ` Sergei Shtylyov 2011-08-09 14:16 ` Voss, Nikolaus 2011-08-09 14:16 ` Voss, Nikolaus 2011-08-09 14:17 ` Voss, Nikolaus 2011-08-10 11:13 ` Sergei Shtylyov 2011-08-10 12:02 ` [PATCH v2] " Voss, Nikolaus 2011-08-10 12:02 ` Voss, Nikolaus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1307522703.10626.9.camel@hcegtvedt.norway.atmel.com \ --to=hans-christian.egtvedt@atmel.com \ --cc=alan@linux.intel.com \ --cc=gregkh@suse.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=nicolas.ferre@atmel.com \ --cc=patrice.vilchez@atmel.com \ --cc=plagnioj@jcrosoft.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.