All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred
Date: Tue, 28 Apr 2020 21:54:32 +0100	[thread overview]
Message-ID: <130909f7-e9e2-93b4-5b54-aa55178d1bd3@citrix.com> (raw)
In-Reply-To: <20200428155144.8253-1-jgross@suse.com>

On 28/04/2020 16:51, Juergen Gross wrote:
> The XS_INTRODUCE command has two parameters: the mfn (or better: gfn)
> of the domain's xenstore ring page and the event channel of the
> domain for communicating with Xenstore.
>
> The gfn is not really needed. It is stored in the per-domain struct
> in xenstored and in case of another XS_INTRODUCE for the domain it
> is tested to match the original value. If it doesn't match the
> command is aborted via EINVAL.
>
> Today there shouldn't be multiple XS_INTRODUCE requests for the same
> domain issued, so the mfn/gfn can just be ignored and multiple
> XS_INTRODUCE commands can be rejected without testing the mfn/gfn.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

In hindsight, this is cleanup following c/s 38eeb3864d "tools/xenstored:
Drop mapping of the ring via foreign map".

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


  reply	other threads:[~2020-04-28 20:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 15:51 [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred Juergen Gross
2020-04-28 20:54 ` Andrew Cooper [this message]
2020-04-28 20:55 ` Julien Grall
2020-04-29  5:51   ` Jürgen Groß
2020-04-29  9:22     ` Julien Grall
2020-04-29 10:39       ` Igor Druzhinin
2020-04-29 10:49         ` Jürgen Groß
2020-04-29 11:04           ` Igor Druzhinin
2020-04-29 12:29             ` Jürgen Groß
2020-04-29 12:49               ` Igor Druzhinin
2020-04-29 12:56                 ` Paul Durrant
2020-04-29 13:16                   ` Igor Druzhinin
2020-04-29 13:22                     ` Paul Durrant
2020-04-29 13:27                       ` Igor Druzhinin
2020-04-29 13:06                 ` Jürgen Groß
2020-04-29 13:39                   ` Igor Druzhinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=130909f7-e9e2-93b4-5b54-aa55178d1bd3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.