* [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript @ 2011-06-30 6:19 Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript Andrew Chen ` (6 more replies) 0 siblings, 7 replies; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Busybox's xargs doesn't recongize the --max-args option. Use -n instead. Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- ltp-full-20101031/testscripts/test_fs_bind.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ltp-full-20101031/testscripts/test_fs_bind.sh b/ltp-full-20101031/testscripts/test_fs_bind.sh index 9ab533a..6b986dc 100755 --- a/ltp-full-20101031/testscripts/test_fs_bind.sh +++ b/ltp-full-20101031/testscripts/test_fs_bind.sh @@ -318,7 +318,7 @@ restore_mounts() # new mounts around and will never remove mounts outside the test # directory ( while grep_mounts ; do - grep_mounts | awk '{print $3}' | xargs -r --max-args=1 umount -l + grep_mounts | awk '{print $3}' | xargs -r -n 1 umount -l done ) >& /dev/null # mount list and exit with 0 -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-07-11 14:45 ` Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated Andrew Chen ` (5 subsequent siblings) 6 siblings, 1 reply; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- .../controllers/cgroup/cgroup_regression_test.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh index 5527afc..c7ce791 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh @@ -254,7 +254,7 @@ test_5() subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'` subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'` - mount -t cgroup -o $subsys1,$subsys xxx cgroup/ + mount -t cgroup -o $subsys1,$subsys2 xxx cgroup/ if [ $? -ne 0 ]; then tst_resm TFAIL "mount $subsys1 and $subsys2 failed" failed=1 -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript 2011-06-30 6:19 ` [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript Andrew Chen @ 2011-07-11 14:45 ` Cyril Hrubis 2011-07-11 16:07 ` Cyril Hrubis 0 siblings, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-07-11 14:45 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > From: Andrew Chen <ypchen@faraday-tech.com> > > > Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> > --- > .../controllers/cgroup/cgroup_regression_test.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > index 5527afc..c7ce791 100755 > --- a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > +++ b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > @@ -254,7 +254,7 @@ test_5() > subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'` > subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'` > > - mount -t cgroup -o $subsys1,$subsys xxx cgroup/ > + mount -t cgroup -o $subsys1,$subsys2 xxx cgroup/ > if [ $? -ne 0 ]; then > tst_resm TFAIL "mount $subsys1 and $subsys2 failed" > failed=1 > -- Please don't leave the commit messages empty, even for such change it should be something like: "Fix typo in cgroup_regression_test.sh." -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript 2011-07-11 14:45 ` Cyril Hrubis @ 2011-07-11 16:07 ` Cyril Hrubis 0 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-07-11 16:07 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > > From: Andrew Chen <ypchen@faraday-tech.com> > > > > > > Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> > > --- > > .../controllers/cgroup/cgroup_regression_test.sh | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > > index 5527afc..c7ce791 100755 > > --- a/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > > +++ b/ltp-full-20101031/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh > > @@ -254,7 +254,7 @@ test_5() > > subsys1=`tail -n 1 /proc/cgroups | awk '{ print $1 }'` > > subsys2=`tail -n 2 /proc/cgroups | head -1 | awk '{ print $1 }'` > > > > - mount -t cgroup -o $subsys1,$subsys xxx cgroup/ > > + mount -t cgroup -o $subsys1,$subsys2 xxx cgroup/ > > if [ $? -ne 0 ]; then > > tst_resm TFAIL "mount $subsys1 and $subsys2 failed" > > failed=1 > > -- > > Please don't leave the commit messages empty, even for such change it > should be something like: > > "Fix typo in cgroup_regression_test.sh." Argh, scratch that. I'm allways confused by git generated emails. I would certainly expect that they add the first line of commit message not only to subject but into the mail body as well. Anyway the patches won't apply as they have ltp-full-20101031 prefix in the path and 'git am' couldn't find the files. PS: It's better to work with the LTP git repository to be sure you are not fixing fixed problem. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-07-21 16:57 ` Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 4/7] testcases: memcg_function: set hugepage size to zero when no hugepage support Andrew Chen ` (4 subsequent siblings) 6 siblings, 1 reply; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Only "Processor" will be showed up in /proc/cpuinfo for ARM non-SMP CPUs. Ignore case to fix this issue. Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- .../kernel/controllers/cpuacct/run_cpuacct_test.sh | 2 +- .../controllers/cpuctl/run_cpuctl_latency_test.sh | 4 ++-- .../controllers/cpuctl/run_cpuctl_stress_test.sh | 2 +- .../kernel/controllers/cpuctl/run_cpuctl_test.sh | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh index 38b2ab6..332a5ae 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh @@ -68,7 +68,7 @@ cleanup mes="CPU Accounting Controller" cg_path="/dev/cpuacct"; -num_online_cpus=`cat /proc/cpuinfo | grep -w processor | wc -l` +num_online_cpus=`cat /proc/cpuinfo | grep -w -i processor | wc -l` #Function to create tasks equal to num_online_cpus. nr_tasks () diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh index 51d6df0..d75d356 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh @@ -99,7 +99,7 @@ calc_allowed_latency() sys_latency=`cat /proc/sys/kernel/sched_wakeup_granularity_ns` allowed_latency=`expr $sys_latency / 1000` # in microseconds else - num_cpus=`cat /proc/cpuinfo | grep -w processor | wc -l` + num_cpus=`cat /proc/cpuinfo | grep -w -i processor | wc -l` log2 $num_cpus; ln_num_cpus=$? ln_num_cpus=`expr $ln_num_cpus + 1` @@ -170,7 +170,7 @@ PWD=`pwd` "2") # With group scheduling echo TINFO "Running cpuctl Latency Test 2" - NUM_CPUS=`cat /proc/cpuinfo | grep -w processor | wc -l`; + NUM_CPUS=`cat /proc/cpuinfo | grep -w -i processor | wc -l`; get_num_groups; # NUM_GROUPS is set now do_setup; diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh index aa5b57d..faf810b 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh @@ -64,7 +64,7 @@ SCRIPT_PID=$$; FILE="stress-678"; # suffix for results file TEST_NAME="CPUCTL NUM_GROUPS vs NUM_TASKS TEST:"; -NUM_CPUS=`cat /proc/cpuinfo | grep -w processor | wc -l` +NUM_CPUS=`cat /proc/cpuinfo | grep -w -i processor | wc -l` N=$NUM_CPUS; # Default total num of groups (classes) M=10; # Default total num of tasks in a group diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh index dd38443..260c97b 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh @@ -59,7 +59,7 @@ NICEVALUE=-20; # Nice value to renice a task with SCRIPT_PID=$$; PWD=`pwd` cd $LTPROOT/testcases/bin/ -NUM_CPUS=`cat /proc/cpuinfo | grep -w processor | wc -l` +NUM_CPUS=`cat /proc/cpuinfo | grep -w -i processor | wc -l` . parameters.sh -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated 2011-06-30 6:19 ` [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated Andrew Chen @ 2011-07-21 16:57 ` Cyril Hrubis 0 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-07-21 16:57 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > From: Andrew Chen <ypchen@faraday-tech.com> > > Only "Processor" will be showed up in /proc/cpuinfo for ARM non-SMP CPUs. > Ignore case to fix this issue. > > Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> > --- > .../kernel/controllers/cpuacct/run_cpuacct_test.sh | 2 +- > .../controllers/cpuctl/run_cpuctl_latency_test.sh | 4 ++-- > .../controllers/cpuctl/run_cpuctl_stress_test.sh | 2 +- > .../kernel/controllers/cpuctl/run_cpuctl_test.sh | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh > index 38b2ab6..332a5ae 100755 > --- a/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh > +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh > @@ -68,7 +68,7 @@ cleanup > > mes="CPU Accounting Controller" > cg_path="/dev/cpuacct"; > -num_online_cpus=`cat /proc/cpuinfo | grep -w processor | wc -l` > +num_online_cpus=`cat /proc/cpuinfo | grep -w -i processor | wc -l` > > #Function to create tasks equal to num_online_cpus. > nr_tasks () > diff --git a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh > index 51d6df0..d75d356 100755 > --- a/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh > +++ b/ltp-full-20101031/testcases/kernel/controllers/cpuctl/run_cpuctl_latency_test.sh > @@ -99,7 +99,7 @@ calc_allowed_latency() > sys_latency=`cat /proc/sys/kernel/sched_wakeup_granularity_ns` > allowed_latency=`expr $sys_latency / 1000` # in microseconds > else > - num_cpus=`cat /proc/cpuinfo | grep -w processor | wc -l` > + num_cpus=`cat /proc/cpuinfo | grep -w -i processor | wc -l` > log2 $num_cpus; > ln_num_cpus=$? > ln_num_cpus=`expr $ln_num_cpus + 1` > @@ -170,7 +170,7 @@ PWD=`pwd` > "2") # With group scheduling > echo TINFO "Running cpuctl Latency Test 2" > > - NUM_CPUS=`cat /proc/cpuinfo | grep -w processor | wc -l`; > + NUM_CPUS=`cat /proc/cpuinfo | grep -w -i processor | wc -l`; > get_num_groups; # NUM_GROUPS is set now > do_setup; Same for this one. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* [LTP] [PATCH 4/7] testcases: memcg_function: set hugepage size to zero when no hugepage support 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 5/7] runltp: precise pattern matching for skipped testcases Andrew Chen ` (3 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- .../memcg/functional/memcg_function_test.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ltp-full-20101031/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh b/ltp-full-20101031/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh index 56010ad..c504ed6 100755 --- a/ltp-full-20101031/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh +++ b/ltp-full-20101031/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh @@ -45,6 +45,7 @@ FAIL=1 PAGESIZE=`./memcg_getpagesize` HUGEPAGESIZE=`grep Hugepagesize /proc/meminfo | awk '{ print $2 }'` +[ -z $HUGEPAGESIZE ] && HUGEPAGESIZE=0 HUGEPAGESIZE=$(( $HUGEPAGESIZE * 1024 )) cur_id=0 -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [LTP] [PATCH 5/7] runltp: precise pattern matching for skipped testcases 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen ` (2 preceding siblings ...) 2011-06-30 6:19 ` [LTP] [PATCH 4/7] testcases: memcg_function: set hugepage size to zero when no hugepage support Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles Andrew Chen ` (2 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- ltp-full-20101031/runltp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ltp-full-20101031/runltp b/ltp-full-20101031/runltp index b385984..c8f558d 100755 --- a/ltp-full-20101031/runltp +++ b/ltp-full-20101031/runltp @@ -681,7 +681,7 @@ main() if [ -n "$SKIPFILE" ] then for file in $( cat $SKIPFILE ); do - sed -i "/$file/d" ${TMP}/alltests + sed -i "/^$file[ \t]/d" ${TMP}/alltests done fi -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen ` (3 preceding siblings ...) 2011-06-30 6:19 ` [LTP] [PATCH 5/7] runltp: precise pattern matching for skipped testcases Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-07-29 11:45 ` Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking Andrew Chen 2011-07-21 16:55 ` [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Cyril Hrubis 6 siblings, 1 reply; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Ensure the number of created file (-S) cannot divide by the rate shrinkfile() is involked (-T), or file shrinking will always happen on the same file. Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- ltp-full-20101031/runtest/fs | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ltp-full-20101031/runtest/fs b/ltp-full-20101031/runtest/fs index e6741a0..26fa4f5 100644 --- a/ltp-full-20101031/runtest/fs +++ b/ltp-full-20101031/runtest/fs @@ -14,9 +14,9 @@ gf12 mkfifo $TMPDIR/gffifo17; growfiles -b -W gf12 -e 1 -u -i 0 -L 30 $TMPDIR/gf gf13 mkfifo $TMPDIR/gffifo18; growfiles -b -W gf13 -e 1 -u -i 0 -L 30 -I r -r 1-4096 $TMPDIR/gffifo18 gf14 growfiles -W gf14 -b -e 1 -u -i 0 -L 20 -w -l -C 1 -T 10 -f glseek19 -S 2 -d $TMPDIR gf15 growfiles -W gf15 -b -e 1 -u -r 1-49600 -I r -u -i 0 -L 120 -f Lgfile1 -d $TMPDIR -gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 100 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR -gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 100 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR gf18 growfiles -W gf18 -b -e 1 -i 0 -L 120 -w -u -r 10-5000 -I r -l -S 2 -f Lgf04_ -d $TMPDIR +gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 101 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR +gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 101 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR gf19 growfiles -W gf19 -b -e 1 -g 5000 -i 500 -t 49900 -T10 -c9 -I p -o O_RDWR,O_CREAT,O_TRUNC -u -f gf08i_ -d $TMPDIR gf20 growfiles -W gf20 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -r 1-256000:512 -R 512-256000 -T 4 -f gfbigio-$$ -d $TMPDIR gf21 growfiles -W gf21 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -g 20480 -T 10 -t 20480 -f gf-bld-$$ -d $TMPDIR -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles 2011-06-30 6:19 ` [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles Andrew Chen @ 2011-07-29 11:45 ` Cyril Hrubis [not found] ` <CANj_sbC3+eO+6=_S4MO8Wr1o6b7Oo9mbX=EehBFaQb6dj=xOww@mail.gmail.com> 0 siblings, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-07-29 11:45 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > --- a/ltp-full-20101031/runtest/fs > +++ b/ltp-full-20101031/runtest/fs > @@ -14,9 +14,9 @@ gf12 mkfifo $TMPDIR/gffifo17; growfiles -b -W gf12 -e 1 -u -i 0 -L 30 $TMPDIR/gf > gf13 mkfifo $TMPDIR/gffifo18; growfiles -b -W gf13 -e 1 -u -i 0 -L 30 -I r -r 1-4096 $TMPDIR/gffifo18 > gf14 growfiles -W gf14 -b -e 1 -u -i 0 -L 20 -w -l -C 1 -T 10 -f glseek19 -S 2 -d $TMPDIR > gf15 growfiles -W gf15 -b -e 1 -u -r 1-49600 -I r -u -i 0 -L 120 -f Lgfile1 -d $TMPDIR > -gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 100 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > -gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 100 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > gf18 growfiles -W gf18 -b -e 1 -i 0 -L 120 -w -u -r 10-5000 -I r -l -S 2 -f Lgf04_ -d $TMPDIR > +gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 101 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > +gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 101 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > gf19 growfiles -W gf19 -b -e 1 -g 5000 -i 500 -t 49900 -T10 -c9 -I p -o O_RDWR,O_CREAT,O_TRUNC -u -f gf08i_ -d $TMPDIR > gf20 growfiles -W gf20 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -r 1-256000:512 -R 512-256000 -T 4 -f gfbigio-$$ -d $TMPDIR > gf21 growfiles -W gf21 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -g 20480 -T 10 -t 20480 -f gf-bld-$$ -d $TMPDIR Any reason why you have changed the order of the execution (the gf18 now preceeds gf16 and gf17)? Also I'm not sure if 'shrinking on the same file' wasn't intentional (most likely not but I'm not sure yet). -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <CANj_sbC3+eO+6=_S4MO8Wr1o6b7Oo9mbX=EehBFaQb6dj=xOww@mail.gmail.com>]
[parent not found: <CAGH67wROk8oOO85TVCZxfNofy2M1NdQXPTkuEHezgUJy8Jx-zw@mail.gmail.com>]
* Re: [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles [not found] ` <CAGH67wROk8oOO85TVCZxfNofy2M1NdQXPTkuEHezgUJy8Jx-zw@mail.gmail.com> @ 2011-08-10 12:12 ` Cyril Hrubis 0 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-08-10 12:12 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list, ypchen > >>> --- a/ltp-full-20101031/runtest/fs > >>> +++ b/ltp-full-20101031/runtest/fs > >>> @@ -14,9 +14,9 @@ gf12 mkfifo $TMPDIR/gffifo17; growfiles -b -W gf12 -e 1 -u -i 0 -L 30 $TMPDIR/gf > >>> gf13 mkfifo $TMPDIR/gffifo18; growfiles -b -W gf13 -e 1 -u -i 0 -L 30 -I r -r 1-4096 $TMPDIR/gffifo18 > >>> gf14 growfiles -W gf14 -b -e 1 -u -i 0 -L 20 -w -l -C 1 -T 10 -f glseek19 -S 2 -d $TMPDIR > >>> gf15 growfiles -W gf15 -b -e 1 -u -r 1-49600 -I r -u -i 0 -L 120 -f Lgfile1 -d $TMPDIR > >>> -gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 100 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > >>> -gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 100 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > >>> gf18 growfiles -W gf18 -b -e 1 -i 0 -L 120 -w -u -r 10-5000 -I r -l -S 2 -f Lgf04_ -d $TMPDIR > >>> +gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 101 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > >>> +gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 101 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > >>> gf19 growfiles -W gf19 -b -e 1 -g 5000 -i 500 -t 49900 -T10 -c9 -I p -o O_RDWR,O_CREAT,O_TRUNC -u -f gf08i_ -d $TMPDIR > >>> gf20 growfiles -W gf20 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -r 1-256000:512 -R 512-256000 -T 4 -f gfbigio-$$ -d $TMPDIR > >>> gf21 growfiles -W gf21 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -g 20480 -T 10 -t 20480 -f gf-bld-$$ -d $TMPDIR > >> > >> Any reason why you have changed the order of the execution (the gf18 now preceeds gf16 and gf17)? > >> > > Sorry, that's my mistake. > > I will resend the patch later. > > > >> Also I'm not sure if 'shrinking on the same file' wasn't intentional > >> (most likely not but I'm not sure yet). > >> > > We made the patch here for the following problem: > > gf16/gf17 create 10 files and keep them growing and shrinking. > > But shrinking on the same file leads the others to be growing only > > which may cause the tests run out of memory. > > Keep things simple. Each testcase should operate on a fresh file > (mk*temp generated filename) to ensure determinism and avoid potential > issues with execution ordering, memory starvation, etc. Not really the case here. The tests itself plays with several files at once making them grow and shrink. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles [not found] ` <CANj_sbC3+eO+6=_S4MO8Wr1o6b7Oo9mbX=EehBFaQb6dj=xOww@mail.gmail.com> [not found] ` <CAGH67wROk8oOO85TVCZxfNofy2M1NdQXPTkuEHezgUJy8Jx-zw@mail.gmail.com> @ 2011-08-10 12:16 ` Cyril Hrubis 2011-09-08 12:09 ` Cyril Hrubis 1 sibling, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-08-10 12:16 UTC (permalink / raw) To: Andrew Yan-Pai Chen; +Cc: ltp-list, ypchen Hi! > >> --- a/ltp-full-20101031/runtest/fs > >> +++ b/ltp-full-20101031/runtest/fs > >> @@ -14,9 +14,9 @@ gf12 mkfifo $TMPDIR/gffifo17; growfiles -b -W gf12 -e 1 -u -i 0 -L 30 $TMPDIR/gf > >> gf13 mkfifo $TMPDIR/gffifo18; growfiles -b -W gf13 -e 1 -u -i 0 -L 30 -I r -r 1-4096 $TMPDIR/gffifo18 > >> gf14 growfiles -W gf14 -b -e 1 -u -i 0 -L 20 -w -l -C 1 -T 10 -f glseek19 -S 2 -d $TMPDIR > >> gf15 growfiles -W gf15 -b -e 1 -u -r 1-49600 -I r -u -i 0 -L 120 -f Lgfile1 -d $TMPDIR > >> -gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 100 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > >> -gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 100 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > >> gf18 growfiles -W gf18 -b -e 1 -i 0 -L 120 -w -u -r 10-5000 -I r -l -S 2 -f Lgf04_ -d $TMPDIR > >> +gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 101 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > >> +gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 101 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > >> gf19 growfiles -W gf19 -b -e 1 -g 5000 -i 500 -t 49900 -T10 -c9 -I p -o O_RDWR,O_CREAT,O_TRUNC -u -f gf08i_ -d $TMPDIR > >> gf20 growfiles -W gf20 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -r 1-256000:512 -R 512-256000 -T 4 -f gfbigio-$$ -d $TMPDIR > >> gf21 growfiles -W gf21 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -g 20480 -T 10 -t 20480 -f gf-bld-$$ -d $TMPDIR > > > > Any reason why you have changed the order of the execution (the gf18 now preceeds gf16 and gf17)? > > > Sorry, that's my mistake. > I will resend the patch later. > > > Also I'm not sure if 'shrinking on the same file' wasn't intentional > > (most likely not but I'm not sure yet). > > > We made the patch here for the following problem: > gf16/gf17 create 10 files and keep them growing and shrinking. > But shrinking on the same file leads the others to be growing only > which may cause the tests run out of memory. Ah right, this should have been in the commit description and also the amount of the memory consumed. That makes clear why you did such change as the change itself doesn't define the problem that you hit... -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles 2011-08-10 12:16 ` Cyril Hrubis @ 2011-09-08 12:09 ` Cyril Hrubis [not found] ` <1316411646-1886-1-git-send-email-yanpai.chen@gmail.com> 0 siblings, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-09-08 12:09 UTC (permalink / raw) To: Andrew Yan-Pai Chen; +Cc: ltp-list, ypchen Hi! > > >> --- a/ltp-full-20101031/runtest/fs > > >> +++ b/ltp-full-20101031/runtest/fs > > >> @@ -14,9 +14,9 @@ gf12 mkfifo $TMPDIR/gffifo17; growfiles -b -W gf12 -e 1 -u -i 0 -L 30 $TMPDIR/gf > > >> gf13 mkfifo $TMPDIR/gffifo18; growfiles -b -W gf13 -e 1 -u -i 0 -L 30 -I r -r 1-4096 $TMPDIR/gffifo18 > > >> gf14 growfiles -W gf14 -b -e 1 -u -i 0 -L 20 -w -l -C 1 -T 10 -f glseek19 -S 2 -d $TMPDIR > > >> gf15 growfiles -W gf15 -b -e 1 -u -r 1-49600 -I r -u -i 0 -L 120 -f Lgfile1 -d $TMPDIR > > >> -gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 100 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > > >> -gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 100 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > > >> gf18 growfiles -W gf18 -b -e 1 -i 0 -L 120 -w -u -r 10-5000 -I r -l -S 2 -f Lgf04_ -d $TMPDIR > > >> +gf16 growfiles -W gf16 -b -e 1 -i 0 -L 120 -u -g 4090 -T 101 -t 408990 -l -C 10 -c 1000 -S 10 -f Lgf02_ -d $TMPDIR > > >> +gf17 growfiles -W gf17 -b -e 1 -i 0 -L 120 -u -g 5000 -T 101 -t 499990 -l -C 10 -c 1000 -S 10 -f Lgf03_ -d $TMPDIR > > >> gf19 growfiles -W gf19 -b -e 1 -g 5000 -i 500 -t 49900 -T10 -c9 -I p -o O_RDWR,O_CREAT,O_TRUNC -u -f gf08i_ -d $TMPDIR > > >> gf20 growfiles -W gf20 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -r 1-256000:512 -R 512-256000 -T 4 -f gfbigio-$$ -d $TMPDIR > > >> gf21 growfiles -W gf21 -D 0 -b -i 0 -L 60 -u -B 1000b -e 1 -g 20480 -T 10 -t 20480 -f gf-bld-$$ -d $TMPDIR > > > > > > Any reason why you have changed the order of the execution (the gf18 now preceeds gf16 and gf17)? > > > > > Sorry, that's my mistake. > > I will resend the patch later. > > > > > Also I'm not sure if 'shrinking on the same file' wasn't intentional > > > (most likely not but I'm not sure yet). > > > > > We made the patch here for the following problem: > > gf16/gf17 create 10 files and keep them growing and shrinking. > > But shrinking on the same file leads the others to be growing only > > which may cause the tests run out of memory. > > Ah right, this should have been in the commit description and also the > amount of the memory consumed. That makes clear why you did such change > as the change itself doesn't define the problem that you hit... > Ping, any progress on this? -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Doing More with Less: The Next Generation Virtual Desktop What are the key obstacles that have prevented many mid-market businesses from deploying virtual desktops? How do next-generation virtual desktops provide companies an easier-to-deploy, easier-to-manage and more affordable virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <1316411646-1886-1-git-send-email-yanpai.chen@gmail.com>]
[parent not found: <CANj_sbD=c+R4YVwqh1tSw-4LanVimNos5rFc0tU872ouCLf-8g@mail.gmail.com>]
* Re: [LTP] [PATCH 6/7 V2] runtest/fs: change parameters of growfiles [not found] ` <CANj_sbD=c+R4YVwqh1tSw-4LanVimNos5rFc0tU872ouCLf-8g@mail.gmail.com> @ 2011-10-13 14:00 ` Cyril Hrubis 0 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-10-13 14:00 UTC (permalink / raw) To: Andrew Yan-Pai Chen; +Cc: ltp-list Hi! > Hi Cyril, > > Is this OK? Yes, this time both description and patche seem fine. Will commit in a minute. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen ` (4 preceding siblings ...) 2011-06-30 6:19 ` [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles Andrew Chen @ 2011-06-30 6:19 ` Andrew Chen 2011-07-11 16:45 ` Cyril Hrubis 2011-07-21 17:01 ` Cyril Hrubis 2011-07-21 16:55 ` [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Cyril Hrubis 6 siblings, 2 replies; 20+ messages in thread From: Andrew Chen @ 2011-06-30 6:19 UTC (permalink / raw) To: ltp-list; +Cc: ypchen From: Andrew Chen <ypchen@faraday-tech.com> Ensure file descriptors are closed before unlinking them, or we cannot remove the generated directories after these tests. The leftover directories may cause tests failed in latter runs once the directory names are hit. Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> --- .../testcases/kernel/syscalls/fstatat/fstatat01.c | 4 +++- .../kernel/syscalls/futimesat/futimesat01.c | 4 +++- .../testcases/kernel/syscalls/openat/openat01.c | 11 ++++++++++- .../kernel/syscalls/readlinkat/readlinkat01.c | 4 +++- .../kernel/syscalls/renameat/renameat01.c | 4 +++- .../kernel/syscalls/unlinkat/unlinkat01.c | 5 ++++- 6 files changed, 26 insertions(+), 6 deletions(-) diff --git a/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c b/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c index 5f81dac..f5938eb 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c @@ -73,6 +73,7 @@ char testfile[256]; char testfile2[256]; char testfile3[256]; int dirfd, fd, ret; +int innerfd; int fds[TEST_CASES]; char *filenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, EINVAL, 0 }; @@ -217,7 +218,7 @@ void setup_every_copy() exit(-1); } - fd = open(testfile2, O_CREAT | O_RDWR, 0600); + innerfd = open(testfile2, O_CREAT | O_RDWR, 0600); if (fd < 0) { perror("open: "); exit(-1); @@ -258,6 +259,7 @@ void setup() void cleanup() { /* Remove them */ + close(innerfd); unlink(testfile2); unlink(testfile3); unlink(testfile); diff --git a/ltp-full-20101031/testcases/kernel/syscalls/futimesat/futimesat01.c b/ltp-full-20101031/testcases/kernel/syscalls/futimesat/futimesat01.c index d82a2c4..6729941 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/futimesat/futimesat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/futimesat/futimesat01.c @@ -73,6 +73,7 @@ char testfile[256]; char testfile2[256]; char testfile3[256]; int dirfd, fd, ret; +int innerfd; int fds[TEST_CASES]; char *filenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, 0 }; @@ -184,7 +185,7 @@ void setup_every_copy() exit(-1); } - fd = open(testfile2, O_CREAT | O_RDWR, 0600); + innerfd = open(testfile2, O_CREAT | O_RDWR, 0600); if (fd < 0) { perror("open: "); exit(-1); @@ -224,6 +225,7 @@ void setup() void cleanup() { /* Remove them */ + close(innerfd); unlink(testfile2); unlink(testfile3); unlink(testfile); diff --git a/ltp-full-20101031/testcases/kernel/syscalls/openat/openat01.c b/ltp-full-20101031/testcases/kernel/syscalls/openat/openat01.c index be40c63..38f2014 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/openat/openat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/openat/openat01.c @@ -72,6 +72,7 @@ char testfile[256]; char testfile2[256]; char testfile3[256]; int dirfd, fd, ret; +int innerfds[2]; int fds[TEST_CASES]; char *filenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, 0 }; @@ -118,9 +119,12 @@ int main(int ac, char **av) * Call openat */ for (i = 0; i < TST_TOTAL; i++) { - TEST(myopenat + TEST(fd = myopenat (fds[i], filenames[i], O_CREAT | O_WRONLY, 0600)); + if (i < 2) + innerfds[i] = fd; + /* check return code */ if (TEST_ERRNO == expected_errno[i]) { @@ -206,7 +210,12 @@ void setup() void cleanup() { /* Remove them */ + int i; char tmppathname[256]; + + for (i = 0; i < 2; ++i) + close(innerfds[i]); + strcpy(tmppathname, pathname); unlink(strcat(strcat(tmppathname, "/"), testfile)); unlink(testfile); diff --git a/ltp-full-20101031/testcases/kernel/syscalls/readlinkat/readlinkat01.c b/ltp-full-20101031/testcases/kernel/syscalls/readlinkat/readlinkat01.c index a6963f1..78768fb 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/readlinkat/readlinkat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/readlinkat/readlinkat01.c @@ -83,6 +83,7 @@ char dtestfile2[256]; char testfile3[256]; char dtestfile3[256]; int dirfd, fd, ret; +int innerfd; int fds[TEST_CASES]; char *filenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, 0 }; @@ -222,7 +223,7 @@ void setup_every_copy() exit(-1); } - fd = open(testfile2, O_CREAT | O_RDWR, 0600); + innerfd = open(testfile2, O_CREAT | O_RDWR, 0600); if (fd < 0) { perror("open: "); exit(-1); @@ -285,6 +286,7 @@ void setup() void cleanup() { /* Remove them */ + close(innerfd); unlink(testfile2); unlink(dtestfile2); unlink(testfile3); diff --git a/ltp-full-20101031/testcases/kernel/syscalls/renameat/renameat01.c b/ltp-full-20101031/testcases/kernel/syscalls/renameat/renameat01.c index 3f27c95..5eff504 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/renameat/renameat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/renameat/renameat01.c @@ -81,6 +81,7 @@ char dtestfile2[256]; char testfile3[256]; char dtestfile3[256]; int olddirfd, newdirfd, fd, ret; +int innerfd; int oldfds[TEST_CASES], newfds[TEST_CASES]; char *oldfilenames[TEST_CASES], *newfilenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, 0 }; @@ -208,7 +209,7 @@ void setup_every_copy() exit(-1); } - fd = open(testfile2, O_CREAT | O_RDWR, 0600); + innerfd = open(testfile2, O_CREAT | O_RDWR, 0600); if (fd < 0) { perror("open: "); exit(-1); @@ -258,6 +259,7 @@ void setup() void cleanup() { /* Remove them */ + close(innerfd); unlink(testfile2); unlink(dtestfile2); unlink(testfile3); diff --git a/ltp-full-20101031/testcases/kernel/syscalls/unlinkat/unlinkat01.c b/ltp-full-20101031/testcases/kernel/syscalls/unlinkat/unlinkat01.c index f8977f5..a20c085 100644 --- a/ltp-full-20101031/testcases/kernel/syscalls/unlinkat/unlinkat01.c +++ b/ltp-full-20101031/testcases/kernel/syscalls/unlinkat/unlinkat01.c @@ -78,6 +78,7 @@ char testfile[256]; char testfile2[256]; char testfile3[256]; int dirfd, fd, ret; +int innerfd; int fds[TEST_CASES]; char *filenames[TEST_CASES]; int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, EINVAL, 0, 0 }; @@ -196,7 +197,7 @@ void setup_every_copy() exit(-1); } - fd = open(testfile2, O_CREAT | O_RDWR, 0600); + innerfd = open(testfile2, O_CREAT | O_RDWR, 0600); if (fd < 0) { perror("open: "); exit(-1); @@ -239,6 +240,8 @@ void cleanup() { /* Remove them */ char tmppathname[256] = ""; + + close(innerfd); strcat(strcat(strcat(tmppathname, pathname), "/"), subpathname); rmdir(tmppathname); unlink(testfile2); -- 1.6.5 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking 2011-06-30 6:19 ` [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking Andrew Chen @ 2011-07-11 16:45 ` Cyril Hrubis 2011-07-21 17:01 ` Cyril Hrubis 1 sibling, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-07-11 16:45 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > Ensure file descriptors are closed before unlinking them, or we cannot > remove the generated directories after these tests. The leftover > directories may cause tests failed in latter runs once the directory > names are hit. I fail to see the problem here (which doesn't mean that there isn't any). If you do unlink() of file, it's removed from filesystem tree regardless if it's open or not. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking 2011-06-30 6:19 ` [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking Andrew Chen 2011-07-11 16:45 ` Cyril Hrubis @ 2011-07-21 17:01 ` Cyril Hrubis [not found] ` <CANj_sbBZGdHond=dOHRKtgBrEHYiK8-iQD=hM-iv3ZU1J5_aYQ@mail.gmail.com> 1 sibling, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-07-21 17:01 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > Ensure file descriptors are closed before unlinking them, or we cannot > remove the generated directories after these tests. The leftover > directories may cause tests failed in latter runs once the directory > names are hit. Basically all the patches but this one looks reasonably. Could you please fix and resend the rest of the patches. Also have you tried to change the setup to create files in TMP insted of PWD? -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <CANj_sbBZGdHond=dOHRKtgBrEHYiK8-iQD=hM-iv3ZU1J5_aYQ@mail.gmail.com>]
[parent not found: <CANj_sbB1KoHxDCBEnGGX66LihMY-00N+mj+rv-4zPYA7XpkssQ@mail.gmail.com>]
[parent not found: <20110727121238.GB20610@saboteur.suse.cz>]
[parent not found: <20110728180131.GA3307@saboteur.suse.cz>]
[parent not found: <CANj_sbCv=TKkRuaPmfWOBz4qArC1eKEuCoDiMb2oLrWCOf_GWQ@mail.gmail.com>]
* Re: [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking [not found] ` <CANj_sbCv=TKkRuaPmfWOBz4qArC1eKEuCoDiMb2oLrWCOf_GWQ@mail.gmail.com> @ 2011-08-10 12:10 ` Cyril Hrubis [not found] ` <1316411928-1941-1-git-send-email-yanpai.chen@gmail.com> 0 siblings, 1 reply; 20+ messages in thread From: Cyril Hrubis @ 2011-08-10 12:10 UTC (permalink / raw) To: Andrew Yan-Pai Chen; +Cc: ltp-list Hi! > I've tried creating the files in TMP and the tests got passed. > I also checked the rmdir(), it worked fine and no ENOTEMPTY. > So, is this a filesystem specific issue? Not really sure, for some reason files in $LTPROOT are not removed if the fd is open on unlink(), could be anything from kernel bug to well defined behavior in your setup. Anyway these tests needs to be fixed and as usual patches are welcome ;). -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <1316411928-1941-1-git-send-email-yanpai.chen@gmail.com>]
* Re: [LTP] [PATCH] testcases: syscalls: use tst_tmpdir() interface [not found] ` <1316411928-1941-1-git-send-email-yanpai.chen@gmail.com> @ 2011-10-13 13:45 ` Cyril Hrubis 0 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-10-13 13:45 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! First of all, please use more recent LTP source (ideally git checkout). The '/* End setup() */' and '/* End cleanup() */' comments were removed about an year ago. > index 5f81dac..0851cbc 100644 > --- a/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c > +++ b/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c > @@ -247,6 +247,8 @@ void setup() > /* capture signals */ > tst_sig(NOFORK, DEF_HANDLER, cleanup); > > + tst_tmpdir(); > + > /* Pause if that option was specified */ > TEST_PAUSE; > } /* End setup() */ > @@ -269,6 +271,8 @@ void cleanup() > */ > TEST_CLEANUP; > > + tst_rmdir(); > + > /* exit with return code appropriate for results */ > tst_exit(); > } /* End cleanup() */ You missed the testfile3 that uses absolute path to /tmp/ which should rather be absoulute path to tst_tmpdir. Something like this should work: snprintf(testfile3, sizeof(testfile3), "%s/fstatattestfile.txt", tst_get_tmpdir()) Note that we no longer need the pid in the filenames as the create test directory is unique. And the same goes for the rest of the testcases. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen ` (5 preceding siblings ...) 2011-06-30 6:19 ` [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking Andrew Chen @ 2011-07-21 16:55 ` Cyril Hrubis 6 siblings, 0 replies; 20+ messages in thread From: Cyril Hrubis @ 2011-07-21 16:55 UTC (permalink / raw) To: Andrew Chen; +Cc: ltp-list, ypchen Hi! > Busybox's xargs doesn't recongize the --max-args option. Use -n instead. > > Signed-off-by: Andrew Chen <ypchen@faraday-tech.com> > --- > ltp-full-20101031/testscripts/test_fs_bind.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ltp-full-20101031/testscripts/test_fs_bind.sh b/ltp-full-20101031/testscripts/test_fs_bind.sh > index 9ab533a..6b986dc 100755 > --- a/ltp-full-20101031/testscripts/test_fs_bind.sh > +++ b/ltp-full-20101031/testscripts/test_fs_bind.sh > @@ -318,7 +318,7 @@ restore_mounts() > # new mounts around and will never remove mounts outside the test > # directory > ( while grep_mounts ; do > - grep_mounts | awk '{print $3}' | xargs -r --max-args=1 umount -l > + grep_mounts | awk '{print $3}' | xargs -r -n 1 umount -l > done ) >& /dev/null > > # mount list and exit with 0 This patch is good to go, but doesn't apply. git am ... Applying: testcases: fs_bind: fix hanging of testscript error: ltp-full-20101031/testscripts/test_fs_bind.sh: does not exist in index Patch failed at 0001 testcases: fs_bind: fix hanging of testscript When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". As I said before there is ltp-full-20101031 that shouldn't be there. Could you please fix and resend it. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2011-10-13 13:57 UTC | newest] Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-06-30 6:19 [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 2/7] testcases: cgroup: correct wrong variable used in the testscript Andrew Chen 2011-07-11 14:45 ` Cyril Hrubis 2011-07-11 16:07 ` Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 3/7] testcases: controllers: fix wrong cpu number calculated Andrew Chen 2011-07-21 16:57 ` Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 4/7] testcases: memcg_function: set hugepage size to zero when no hugepage support Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 5/7] runltp: precise pattern matching for skipped testcases Andrew Chen 2011-06-30 6:19 ` [LTP] [PATCH 6/7] runtest/fs: change parameters of growfiles Andrew Chen 2011-07-29 11:45 ` Cyril Hrubis [not found] ` <CANj_sbC3+eO+6=_S4MO8Wr1o6b7Oo9mbX=EehBFaQb6dj=xOww@mail.gmail.com> [not found] ` <CAGH67wROk8oOO85TVCZxfNofy2M1NdQXPTkuEHezgUJy8Jx-zw@mail.gmail.com> 2011-08-10 12:12 ` Cyril Hrubis 2011-08-10 12:16 ` Cyril Hrubis 2011-09-08 12:09 ` Cyril Hrubis [not found] ` <1316411646-1886-1-git-send-email-yanpai.chen@gmail.com> [not found] ` <CANj_sbD=c+R4YVwqh1tSw-4LanVimNos5rFc0tU872ouCLf-8g@mail.gmail.com> 2011-10-13 14:00 ` [LTP] [PATCH 6/7 V2] " Cyril Hrubis 2011-06-30 6:19 ` [LTP] [PATCH 7/7] testcases: syscalls: close file descriptors before unlinking Andrew Chen 2011-07-11 16:45 ` Cyril Hrubis 2011-07-21 17:01 ` Cyril Hrubis [not found] ` <CANj_sbBZGdHond=dOHRKtgBrEHYiK8-iQD=hM-iv3ZU1J5_aYQ@mail.gmail.com> [not found] ` <CANj_sbB1KoHxDCBEnGGX66LihMY-00N+mj+rv-4zPYA7XpkssQ@mail.gmail.com> [not found] ` <20110727121238.GB20610@saboteur.suse.cz> [not found] ` <20110728180131.GA3307@saboteur.suse.cz> [not found] ` <CANj_sbCv=TKkRuaPmfWOBz4qArC1eKEuCoDiMb2oLrWCOf_GWQ@mail.gmail.com> 2011-08-10 12:10 ` Cyril Hrubis [not found] ` <1316411928-1941-1-git-send-email-yanpai.chen@gmail.com> 2011-10-13 13:45 ` [LTP] [PATCH] testcases: syscalls: use tst_tmpdir() interface Cyril Hrubis 2011-07-21 16:55 ` [LTP] [PATCH 1/7] testcases: fs_bind: fix hanging of testscript Cyril Hrubis
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.