From: Artem Bityutskiy <dedekind1@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Kyungmin Park <kmpark@infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mtd: OneNAND: samsung: Write DMA support
Date: Thu, 30 Jun 2011 16:38:33 +0300 [thread overview]
Message-ID: <1309441118.23597.198.camel@sauron> (raw)
In-Reply-To: <20110630112354.GW21898@n2100.arm.linux.org.uk>
On Thu, 2011-06-30 at 12:23 +0100, Russell King - ARM Linux wrote:
> It's probably going to be better to have a MTD block API for DMA which
> provides a scatterlist to the MTD block driver, and which knows whether
> the memory is from vmalloc. When it is, it takes care of the flushing
> via those two functions I referred to in cachetlb.txt.
>
> This keeps the magic out of the individual MTD block drivers, and stops
> them replicating the same mistakes time and time again - and also means
> that you won't have to teach everyone about this.
Yeah, something like this. The MTD API is not very suitable for this and
would need some rework to make sure we achieve 2 goals:
1. No need to change current MTD API users
2. Keep the vmalloced memory handling in one place and not replicate it
in each driver.
Currently only OneNAND drivers do these hacks, so I guess Kyungmin will
suffer most...
> It doesn't make sense for the DMA API to deal with vmalloc - MTD is
> one of the very few (the only?) subsystems which does this.
OK, thank you!
--
Best Regards,
Artem Bityutskiy
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: OneNAND: samsung: Write DMA support
Date: Thu, 30 Jun 2011 16:38:33 +0300 [thread overview]
Message-ID: <1309441118.23597.198.camel@sauron> (raw)
In-Reply-To: <20110630112354.GW21898@n2100.arm.linux.org.uk>
On Thu, 2011-06-30 at 12:23 +0100, Russell King - ARM Linux wrote:
> It's probably going to be better to have a MTD block API for DMA which
> provides a scatterlist to the MTD block driver, and which knows whether
> the memory is from vmalloc. When it is, it takes care of the flushing
> via those two functions I referred to in cachetlb.txt.
>
> This keeps the magic out of the individual MTD block drivers, and stops
> them replicating the same mistakes time and time again - and also means
> that you won't have to teach everyone about this.
Yeah, something like this. The MTD API is not very suitable for this and
would need some rework to make sure we achieve 2 goals:
1. No need to change current MTD API users
2. Keep the vmalloced memory handling in one place and not replicate it
in each driver.
Currently only OneNAND drivers do these hacks, so I guess Kyungmin will
suffer most...
> It doesn't make sense for the DMA API to deal with vmalloc - MTD is
> one of the very few (the only?) subsystems which does this.
OK, thank you!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-06-30 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 10:18 [PATCH] mtd: OneNAND: samsung: Write DMA support Kyungmin Park
2011-06-29 7:22 ` Kyungmin Park
2011-06-30 7:21 ` Artem Bityutskiy
2011-06-30 7:55 ` Artem Bityutskiy
2011-06-30 7:55 ` Artem Bityutskiy
2011-06-30 9:19 ` Russell King - ARM Linux
2011-06-30 9:19 ` Russell King - ARM Linux
2011-06-30 10:45 ` Artem Bityutskiy
2011-06-30 10:45 ` Artem Bityutskiy
2011-06-30 11:23 ` Russell King - ARM Linux
2011-06-30 11:23 ` Russell King - ARM Linux
2011-06-30 13:38 ` Artem Bityutskiy [this message]
2011-06-30 13:38 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309441118.23597.198.camel@sauron \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.