All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-input@vger.kernel.org
Cc: jkosina@suse.cz, padovan@profusion.mobi,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 05/12] HID: wiimote: Synchronize wiimote input and hid event handling
Date: Tue,  5 Jul 2011 13:45:12 +0200	[thread overview]
Message-ID: <1309866319-12899-5-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1309866319-12899-1-git-send-email-dh.herrmann@googlemail.com>

The wiimote first starts HID hardware and then registers the input
device. We need to synchronize the startup so no event handler will
start parsing events when the wiimote device is not ready, yet.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/hid/hid-wiimote.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-wiimote.c b/drivers/hid/hid-wiimote.c
index deaf232..3416f69 100644
--- a/drivers/hid/hid-wiimote.c
+++ b/drivers/hid/hid-wiimote.c
@@ -10,6 +10,7 @@
  * any later version.
  */
 
+#include <linux/atomic.h>
 #include <linux/device.h>
 #include <linux/hid.h>
 #include <linux/input.h>
@@ -20,6 +21,7 @@
 #define WIIMOTE_NAME "Nintendo Wii Remote"
 
 struct wiimote_data {
+	atomic_t ready;
 	struct hid_device *hdev;
 	struct input_dev *input;
 };
@@ -27,12 +29,26 @@ struct wiimote_data {
 static int wiimote_input_event(struct input_dev *dev, unsigned int type,
 						unsigned int code, int value)
 {
+	struct wiimote_data *wdata = input_get_drvdata(dev);
+
+	if (!atomic_read(&wdata->ready))
+		return -EBUSY;
+	/* smp_rmb: Make sure wdata->xy is available when wdata->ready is 1 */
+	smp_rmb();
+
 	return 0;
 }
 
 static int wiimote_hid_event(struct hid_device *hdev, struct hid_report *report,
 							u8 *raw_data, int size)
 {
+	struct wiimote_data *wdata = hid_get_drvdata(hdev);
+
+	if (!atomic_read(&wdata->ready))
+		return -EBUSY;
+	/* smp_rmb: Make sure wdata->xy is available when wdata->ready is 1 */
+	smp_rmb();
+
 	if (size < 1)
 		return -EINVAL;
 
@@ -103,6 +119,9 @@ static int wiimote_hid_probe(struct hid_device *hdev,
 		goto err_stop;
 	}
 
+	/* smp_wmb: Write wdata->xy first before wdata->ready is set to 1 */
+	smp_wmb();
+	atomic_set(&wdata->ready, 1);
 	hid_info(hdev, "New device registered\n");
 	return 0;
 
-- 
1.7.6


  parent reply	other threads:[~2011-07-05 11:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 11:45 [PATCH 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub David Herrmann
2011-07-05 11:45 ` [PATCH 02/12] HID: wiimote: Register wiimote hid " David Herrmann
2011-07-05 11:45 ` [PATCH 03/12] HID: wiimote: Add wiimote device structure David Herrmann
2011-07-05 11:45 ` [PATCH 04/12] HID: wiimote: Register input device in wiimote hid driver David Herrmann
2011-07-05 11:45 ` David Herrmann [this message]
2011-07-05 11:45 ` [PATCH 06/12] HID: wiimote: Add wiimote send function David Herrmann
2011-07-05 11:45 ` [PATCH 07/12] HID: wiimote: Add output queue for wiimote driver David Herrmann
2011-07-05 11:45 ` [PATCH 08/12] HID: wiimote: Add wiimote event handler David Herrmann
2011-07-05 11:45 ` [PATCH 09/12] HID: wiimote: Add wiimote input button parser David Herrmann
2011-07-05 11:45 ` [PATCH 10/12] HID: wiimote: Add wiimote led request David Herrmann
2011-07-05 11:45 ` [PATCH 11/12] HID: wiimote: Cache wiimote led state David Herrmann
2011-07-05 11:45 ` [PATCH 12/12] HID: wiimote: Add sysfs support to wiimote driver David Herrmann
2011-07-11 12:36 ` [PATCH 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2011-06-27 14:30 David Herrmann
2011-06-27 14:30 ` [PATCH 05/12] HID: wiimote: Synchronize wiimote input and hid event handling David Herrmann
2011-06-28  5:49   ` Dmitry Torokhov
2011-06-29 12:39     ` David Herrmann
2011-07-11 12:29       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309866319-12899-5-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.