All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, padovan@profusion.mobi,
	oliver@neukum.org
Subject: Re: [PATCH 05/12] HID: wiimote: Synchronize wiimote input and hid event handling
Date: Mon, 11 Jul 2011 14:29:25 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1107111428330.11049@pobox.suse.cz> (raw)
In-Reply-To: <BANLkTimbhk9y8V6ff0FiTsjNQWw6wBXjNA@mail.gmail.com>

On Wed, 29 Jun 2011, David Herrmann wrote:

> But, thanks to your hint, I looked at hid_hw_start() again and as far
> as I can see the synchronization issue exists there, too.
> The ll_driver->start() function is called first and after that, the
> input instance is registered.
> If the ll_driver reports an event before the input instance is
> registered, the hidinput/other-driver will call input_event() on an
> invalid input instance (probably even a NULL dereference).
> This may not be a problem for usbhid, because usbhid_open() has to be
> called first, however, hidp (bluetooth hid) ignores the *_open()
> callback and therefore may fail.

Indeed, this looks like a proper analysis. Thanks a lot for looking into 
it.

Are you planning on submitting the fix for that? Otherwise I'll add it to 
my TODO list, independently on the wiimote driver.

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2011-07-11 12:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 14:30 [PATCH 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub David Herrmann
2011-06-27 14:30 ` [PATCH 02/12] HID: wiimote: Register wiimote hid " David Herrmann
2011-06-27 14:30 ` [PATCH 03/12] HID: wiimote: Add wiimote device structure David Herrmann
2011-06-27 14:30 ` [PATCH 04/12] HID: wiimote: Register input device in wiimote hid driver David Herrmann
2011-06-27 14:30 ` [PATCH 05/12] HID: wiimote: Synchronize wiimote input and hid event handling David Herrmann
2011-06-28  5:49   ` Dmitry Torokhov
2011-06-29 12:39     ` David Herrmann
2011-07-11 12:29       ` Jiri Kosina [this message]
2011-06-27 14:30 ` [PATCH 06/12] HID: wiimote: Add wiimote send function David Herrmann
2011-06-27 14:30 ` [PATCH 07/12] HID: wiimote: Add output queue for wiimote driver David Herrmann
2011-06-28  4:51   ` Dmitry Torokhov
2011-06-29 12:53     ` David Herrmann
2011-06-27 14:30 ` [PATCH 08/12] HID: wiimote: Add wiimote event handler David Herrmann
2011-06-27 14:30 ` [PATCH 09/12] HID: wiimote: Add wiimote input button parser David Herrmann
2011-06-28  5:52   ` Dmitry Torokhov
2011-06-29 12:43     ` David Herrmann
2011-06-27 14:30 ` [PATCH 10/12] HID: wiimote: Add wiimote led request David Herrmann
2011-06-27 14:30 ` [PATCH 11/12] HID: wiimote: Cache wiimote led state David Herrmann
2011-06-27 14:30 ` [PATCH 12/12] HID: wiimote: Add sysfs support to wiimote driver David Herrmann
2011-07-05 11:45 [PATCH 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub David Herrmann
2011-07-05 11:45 ` [PATCH 05/12] HID: wiimote: Synchronize wiimote input and hid event handling David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1107111428330.11049@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=dh.herrmann@googlemail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.