From: Torsten Schenk <torsten.schenk@zoho.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: [PATCH] final issues in snd-usb-6fire concerning signedness bug
Date: Thu, 16 Jun 2011 21:06:27 +0200 [thread overview]
Message-ID: <13099d8e809.-433657093718378069.6298655438333370759@zoho.com> (raw)
In-Reply-To: <s5hr59mw2u5.wl%tiwai@suse.de>
Fixed remaining issues of the signedness bug discovered by Dan Carpenter. A check was remaining that tests if unsigned rt->rate is >= 0. Changed that so that rt->rate now consistently uses ARRAY_SIZE(rates) as invalid rate value and not -1.
Signed-off-by: Torsten Schenk <torsten.schenk@zoho.com>
diff -Nur a/sound/usb/6fire/pcm.c b/sound/usb/6fire/pcm.c
--- a/sound/usb/6fire/pcm.c 2011-06-16 20:49:55.859600014 +0200
+++ b/sound/usb/6fire/pcm.c 2011-06-16 20:48:07.000000000 +0200
@@ -395,12 +395,12 @@
alsa_rt->hw = pcm_hw;
if (alsa_sub->stream == SNDRV_PCM_STREAM_PLAYBACK) {
- if (rt->rate >= 0)
+ if (rt->rate < ARRAY_SIZE(rates))
alsa_rt->hw.rates = rates_alsaid[rt->rate];
alsa_rt->hw.channels_max = OUT_N_CHANNELS;
sub = &rt->playback;
} else if (alsa_sub->stream == SNDRV_PCM_STREAM_CAPTURE) {
- if (rt->rate >= 0)
+ if (rt->rate < ARRAY_SIZE(rates))
alsa_rt->hw.rates = rates_alsaid[rt->rate];
alsa_rt->hw.channels_max = IN_N_CHANNELS;
sub = &rt->capture;
next prev parent reply other threads:[~2011-06-16 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12d995c1fa0.477955495632923443.5387390398635058860@zoho.com>
2011-01-20 16:54 ` Driver for TerraTec DMX 6Fire USB Takashi Iwai
2011-01-20 22:38 ` Torsten Schenk
2011-01-21 8:57 ` Takashi Iwai
2011-01-21 11:48 ` Torsten Schenk
2011-01-22 16:35 ` Takashi Iwai
2011-01-24 12:10 ` Torsten Schenk
2011-01-25 10:25 ` Takashi Iwai
2011-01-25 14:12 ` Torsten Schenk
2011-03-31 19:25 ` TerraTec DMX 6Fire USB updates Torsten Schenk
2011-04-01 12:52 ` Takashi Iwai
2011-04-03 12:30 ` Torsten Schenk
2011-04-04 7:28 ` Takashi Iwai
2011-04-04 9:41 ` Torsten Schenk
2011-04-04 9:45 ` [PATCH 1/5] " Torsten Schenk
2011-04-04 10:29 ` Takashi Iwai
2011-04-04 9:47 ` [PATCH 2/5] " Torsten Schenk
2011-04-04 9:49 ` [PATCH 3/5] " Torsten Schenk
2011-04-04 9:49 ` [PATCH 4/5] " Torsten Schenk
2011-04-04 9:50 ` [PATCH 5/5] " Torsten Schenk
2011-06-16 19:06 ` Torsten Schenk [this message]
2011-06-16 19:33 ` [PATCH] final issues in snd-usb-6fire concerning signedness bug Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13099d8e809.-433657093718378069.6298655438333370759@zoho.com \
--to=torsten.schenk@zoho.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.