All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Torsten Schenk <torsten.schenk@zoho.com>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: TerraTec DMX 6Fire USB updates
Date: Mon, 04 Apr 2011 09:28:03 +0200	[thread overview]
Message-ID: <s5hwrjamq64.wl%tiwai@suse.de> (raw)
In-Reply-To: <12f1b580363.6419672029244585187.-6233154609191024090@zoho.com>

At Sun, 03 Apr 2011 14:30:43 +0200,
Torsten Schenk wrote:
> 
> Ok, fixed your two issues. Here the changelog and the patch again:
> 
> - control: digital thru added (for conversion optical<->tos)
> - restructuring: samplerate, channel and streaming control moved to control.c
> - firmware loader: loader now accepts all hardware versions of the device
> - firmware loader: if firmware is already present it will be accepted if it is known to be working
> - pcm: added support for s32_le sampleformat
> - makefile: "experimental" dependency removed (tested and confirmed by users on http://sixfireusb.sourceforge.net)
> - makefile: description updated
> - bugfix: unsigned pcm_runtime.rate now never uses negative values (completion of signedness bug correction submitted by Dan Carpenter)
> - bugfix: firmware leak fixed if error occurs (already submitted by Jesper Juhl but not in kernel yet)

Thanks.  But, as you see, there are too many changes done in a single
patch.  Could you split the changes into several incremental patches?
In principle, one patch should contain one change.  Of course, some
trivial changes can be merged, but the above is way too much.


Takashi

  reply	other threads:[~2011-04-04  7:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <12d995c1fa0.477955495632923443.5387390398635058860@zoho.com>
2011-01-20 16:54 ` Driver for TerraTec DMX 6Fire USB Takashi Iwai
2011-01-20 22:38   ` Torsten Schenk
2011-01-21  8:57     ` Takashi Iwai
2011-01-21 11:48       ` Torsten Schenk
2011-01-22 16:35         ` Takashi Iwai
2011-01-24 12:10           ` Torsten Schenk
2011-01-25 10:25             ` Takashi Iwai
2011-01-25 14:12               ` Torsten Schenk
2011-03-31 19:25         ` TerraTec DMX 6Fire USB updates Torsten Schenk
2011-04-01 12:52           ` Takashi Iwai
2011-04-03 12:30             ` Torsten Schenk
2011-04-04  7:28               ` Takashi Iwai [this message]
2011-04-04  9:41                 ` Torsten Schenk
2011-04-04  9:45                 ` [PATCH 1/5] " Torsten Schenk
2011-04-04 10:29                   ` Takashi Iwai
2011-04-04  9:47                 ` [PATCH 2/5] " Torsten Schenk
2011-04-04  9:49                 ` [PATCH 3/5] " Torsten Schenk
2011-04-04  9:49                 ` [PATCH 4/5] " Torsten Schenk
2011-04-04  9:50                 ` [PATCH 5/5] " Torsten Schenk
2011-06-16 19:06             ` [PATCH] final issues in snd-usb-6fire concerning signedness bug Torsten Schenk
2011-06-16 19:33               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwrjamq64.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=torsten.schenk@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.