From: Dong Aisheng <b29396@freescale.com> To: alsa-devel@alsa-project.org Cc: s.hauer@pengutronix.de, lrg@ti.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Date: Fri, 8 Jul 2011 23:59:50 +0800 [thread overview] Message-ID: <1310140790-2132-11-git-send-email-b29396@freescale.com> (raw) In-Reply-To: <1310140790-2132-1-git-send-email-b29396@freescale.com> Other files using dma.h may fail to compile as follows: In file included from sound/soc/mxs/mxs-pcm.h:22, from sound/soc/mxs/mxs-saif.h:112, from sound/soc/mxs/mxs-sgtl5000.c:34: arch/arm/mach-mxs/include/mach/dma.h:16: warning: 'struct dma_chan' declared inside parameter list arch/arm/mach-mxs/include/mach/dma.h:16: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbh': arch/arm/mach-mxs/include/mach/dma.h:18: error: dereferencing pointer to incomplete type arch/arm/mach-mxs/include/mach/dma.h: At top level: arch/arm/mach-mxs/include/mach/dma.h:21: warning: 'struct dma_chan' declared inside parameter list arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbx': arch/arm/mach-mxs/include/mach/dma.h:23: error: dereferencing pointer to incomplete type make[3]: *** [sound/soc/mxs/mxs-sgtl5000.o] Error 1 make[2]: *** [sound/soc/mxs] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2 It seems it's better for dma.h to include dmaengine.h himself. Signed-off-by: Dong Aisheng <b29396@freescale.com> --- arch/arm/mach-mxs/include/mach/dma.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/dma.h b/arch/arm/mach-mxs/include/mach/dma.h index 7f4aeea..203d7c4 100644 --- a/arch/arm/mach-mxs/include/mach/dma.h +++ b/arch/arm/mach-mxs/include/mach/dma.h @@ -9,6 +9,8 @@ #ifndef __MACH_MXS_DMA_H__ #define __MACH_MXS_DMA_H__ +#include <linux/dmaengine.h> + struct mxs_dma_data { int chan_irq; }; -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: b29396@freescale.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Date: Fri, 8 Jul 2011 23:59:50 +0800 [thread overview] Message-ID: <1310140790-2132-11-git-send-email-b29396@freescale.com> (raw) In-Reply-To: <1310140790-2132-1-git-send-email-b29396@freescale.com> Other files using dma.h may fail to compile as follows: In file included from sound/soc/mxs/mxs-pcm.h:22, from sound/soc/mxs/mxs-saif.h:112, from sound/soc/mxs/mxs-sgtl5000.c:34: arch/arm/mach-mxs/include/mach/dma.h:16: warning: 'struct dma_chan' declared inside parameter list arch/arm/mach-mxs/include/mach/dma.h:16: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbh': arch/arm/mach-mxs/include/mach/dma.h:18: error: dereferencing pointer to incomplete type arch/arm/mach-mxs/include/mach/dma.h: At top level: arch/arm/mach-mxs/include/mach/dma.h:21: warning: 'struct dma_chan' declared inside parameter list arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbx': arch/arm/mach-mxs/include/mach/dma.h:23: error: dereferencing pointer to incomplete type make[3]: *** [sound/soc/mxs/mxs-sgtl5000.o] Error 1 make[2]: *** [sound/soc/mxs] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2 It seems it's better for dma.h to include dmaengine.h himself. Signed-off-by: Dong Aisheng <b29396@freescale.com> --- arch/arm/mach-mxs/include/mach/dma.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/dma.h b/arch/arm/mach-mxs/include/mach/dma.h index 7f4aeea..203d7c4 100644 --- a/arch/arm/mach-mxs/include/mach/dma.h +++ b/arch/arm/mach-mxs/include/mach/dma.h @@ -9,6 +9,8 @@ #ifndef __MACH_MXS_DMA_H__ #define __MACH_MXS_DMA_H__ +#include <linux/dmaengine.h> + struct mxs_dma_data { int chan_irq; }; -- 1.7.0.4
next prev parent reply other threads:[~2011-07-08 15:59 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-08 15:59 [PATCH 00/10] ARM: mxs: add audio support Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-09 2:33 ` Mark Brown 2011-07-09 2:33 ` Mark Brown 2011-07-10 6:28 ` Dong Aisheng 2011-07-10 6:28 ` Dong Aisheng 2011-07-10 8:21 ` Mark Brown 2011-07-10 8:21 ` Mark Brown 2011-07-08 15:59 ` [PATCH 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 16:19 ` Sascha Hauer 2011-07-08 16:19 ` Sascha Hauer 2011-07-08 17:10 ` Wolfram Sang 2011-07-08 17:10 ` Wolfram Sang 2011-07-08 18:35 ` Dong Aisheng 2011-07-08 18:35 ` Dong Aisheng 2011-07-09 2:52 ` Mark Brown 2011-07-09 2:52 ` Mark Brown 2011-07-10 8:17 ` Dong Aisheng 2011-07-10 8:17 ` Dong Aisheng 2011-07-10 8:34 ` Mark Brown 2011-07-10 8:34 ` Mark Brown 2011-07-10 8:58 ` Dong Aisheng 2011-07-10 8:58 ` Dong Aisheng 2011-07-10 9:26 ` Mark Brown 2011-07-10 9:26 ` Mark Brown 2011-07-10 11:59 ` Dong Aisheng 2011-07-10 11:59 ` Dong Aisheng 2011-07-11 10:00 ` Wolfram Sang 2011-07-11 10:00 ` Wolfram Sang 2011-07-13 3:28 ` Dong Aisheng-B29396 2011-07-13 3:28 ` Dong Aisheng-B29396 2011-07-08 15:59 ` [PATCH 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-09 3:00 ` Mark Brown 2011-07-09 3:00 ` Mark Brown 2011-07-10 8:36 ` Dong Aisheng 2011-07-10 8:36 ` Dong Aisheng 2011-07-10 8:40 ` Mark Brown 2011-07-10 8:40 ` Mark Brown 2011-07-08 15:59 ` [PATCH 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-09 3:01 ` Mark Brown 2011-07-09 3:01 ` Mark Brown 2011-07-10 8:37 ` Dong Aisheng 2011-07-10 8:37 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 05/10] ARM: mxs: add saif clock Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 06/10] ARM: mxs: add saif device Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` [PATCH 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng 2011-07-08 15:59 ` Dong Aisheng [this message] 2011-07-08 15:59 ` [PATCH 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1310140790-2132-11-git-send-email-b29396@freescale.com \ --to=b29396@freescale.com \ --cc=alsa-devel@alsa-project.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lrg@ti.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.