* [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image
@ 2011-07-11 18:49 Dirk Behme
2011-07-12 7:20 ` Chander Kashyap
0 siblings, 1 reply; 4+ messages in thread
From: Dirk Behme @ 2011-07-11 18:49 UTC (permalink / raw)
To: u-boot
From: Dirk Behme <dirk.behme@googlemail.com>
Fix compilation of mkv310_image host tool
tools/mkv310_image.c: In function 'main':
tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function)
tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once
tools/mkv310_image.c:67: error: for each function it appears in.)
tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function)
tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function)
tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function)
tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function)
tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function)
resulting from a 'make smdkv310_config'.
Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
---
Changes in v2: Use sys/stat.h instead of linux/stat.h
Note: mkv310_image is compiled for the host by the host's gcc:
cd mmc_spl/board/samsung/smdkv310
gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec
mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | 1 +
1 file changed, 1 insertion(+)
Index: u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
===================================================================
--- u-boot.git.orig/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
+++ u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
@@ -26,6 +26,7 @@
#include <fcntl.h>
#include <errno.h>
#include <string.h>
+#include <sys/stat.h>
#define CHECKSUM_OFFSET (14*1024-4)
#define BUFSIZE (16*1024)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image
2011-07-11 18:49 [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image Dirk Behme
@ 2011-07-12 7:20 ` Chander Kashyap
2011-07-13 8:53 ` Minkyu Kang
0 siblings, 1 reply; 4+ messages in thread
From: Chander Kashyap @ 2011-07-12 7:20 UTC (permalink / raw)
To: u-boot
On 12 July 2011 00:19, Dirk Behme <dirk.behme@googlemail.com> wrote:
> From: Dirk Behme <dirk.behme@googlemail.com>
>
> Fix compilation of mkv310_image host tool
>
> tools/mkv310_image.c: In function 'main':
> tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function)
> tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once
> tools/mkv310_image.c:67: error: for each function it appears in.)
> tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function)
> tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function)
> tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function)
> tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function)
> tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function)
>
> resulting from a 'make smdkv310_config'.
>
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>
> ---
> Changes in v2: Use sys/stat.h instead of linux/stat.h
>
> Note: mkv310_image is compiled for the host by the host's gcc:
>
> cd mmc_spl/board/samsung/smdkv310
> gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec
>
> ?mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | ? ?1 +
> ?1 file changed, 1 insertion(+)
>
> Index: u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
> ===================================================================
> --- u-boot.git.orig/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
> +++ u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
> @@ -26,6 +26,7 @@
> ?#include <fcntl.h>
> ?#include <errno.h>
> ?#include <string.h>
> +#include <sys/stat.h>
>
> ?#define CHECKSUM_OFFSET ? ? ? ? ? ? ? ?(14*1024-4)
> ?#define BUFSIZE ? ? ? ? ? ? ? ? ? ? ? ?(16*1024)
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Ok.
Dear Minkyu,
Please apply
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image
2011-07-12 7:20 ` Chander Kashyap
@ 2011-07-13 8:53 ` Minkyu Kang
2011-08-05 19:24 ` Dirk Behme
0 siblings, 1 reply; 4+ messages in thread
From: Minkyu Kang @ 2011-07-13 8:53 UTC (permalink / raw)
To: u-boot
Dear Dirk Behme,
On 12 July 2011 16:20, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> On 12 July 2011 00:19, Dirk Behme <dirk.behme@googlemail.com> wrote:
>> From: Dirk Behme <dirk.behme@googlemail.com>
>>
>> Fix compilation of mkv310_image host tool
>>
>> tools/mkv310_image.c: In function 'main':
>> tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function)
>> tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once
>> tools/mkv310_image.c:67: error: for each function it appears in.)
>> tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function)
>> tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function)
>> tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function)
>> tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function)
>> tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function)
>>
>> resulting from a 'make smdkv310_config'.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>
>> ---
>> Changes in v2: Use sys/stat.h instead of linux/stat.h
>>
>> Note: mkv310_image is compiled for the host by the host's gcc:
>>
>> cd mmc_spl/board/samsung/smdkv310
>> gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec
>>
>> ?mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | ? ?1 +
>> ?1 file changed, 1 insertion(+)
>>
applied to u-boot-samsung.
Please use "git format-patch" to make patches.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image
2011-07-13 8:53 ` Minkyu Kang
@ 2011-08-05 19:24 ` Dirk Behme
0 siblings, 0 replies; 4+ messages in thread
From: Dirk Behme @ 2011-08-05 19:24 UTC (permalink / raw)
To: u-boot
On 13.07.2011 10:53, Minkyu Kang wrote:
> Dear Dirk Behme,
>
> On 12 July 2011 16:20, Chander Kashyap<chander.kashyap@linaro.org> wrote:
>> On 12 July 2011 00:19, Dirk Behme<dirk.behme@googlemail.com> wrote:
>>> From: Dirk Behme<dirk.behme@googlemail.com>
>>>
>>> Fix compilation of mkv310_image host tool
>>>
>>> tools/mkv310_image.c: In function 'main':
>>> tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function)
>>> tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once
>>> tools/mkv310_image.c:67: error: for each function it appears in.)
>>> tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function)
>>> tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function)
>>> tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function)
>>> tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function)
>>> tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function)
>>>
>>> resulting from a 'make smdkv310_config'.
>>>
>>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>>>
>>> ---
>>> Changes in v2: Use sys/stat.h instead of linux/stat.h
>>>
>>> Note: mkv310_image is compiled for the host by the host's gcc:
>>>
>>> cd mmc_spl/board/samsung/smdkv310
>>> gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec
>>>
>>> mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>
> applied to u-boot-samsung.
Could we get a pull request for u-boot-samsung to get this fixed in
mainline?
Many thanks
Dirk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-05 19:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-11 18:49 [U-Boot] [PATCH v2] SMDKV310: Fix host compilation of mkv310_image Dirk Behme
2011-07-12 7:20 ` Chander Kashyap
2011-07-13 8:53 ` Minkyu Kang
2011-08-05 19:24 ` Dirk Behme
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.