All of lore.kernel.org
 help / color / mirror / Atom feed
From: utx@penguin.cz (Stanislav Brabec)
To: linux-arm-kernel@lists.infradead.org
Subject: [Zaurus-devel] [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception
Date: Mon, 11 Jul 2011 22:56:31 +0200	[thread overview]
Message-ID: <1310417791.17423.3.camel@utx.lan> (raw)
In-Reply-To: <1310410051-13127-1-git-send-email-morpheus.ibis@gmail.com>

Pavel Herrmann wrote:
> spi_sync call uses its spi_message parameter to keep completion information,
> having this structure static is not thread-safe, potentially causing one
> thread having pointers to memory on or above other threads stack. use mutex
> to prevent multiple access
> 
> Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> Acked-by: Cyril Hrubis <metan@ucw.cz>
Tested-by: Stanislav Brabec <utx@penguin.cz>

Tested on spitz, fixed previously reproducible OOPSes and kernel panic.

(See thread "kernel panic in spi_complete() on spitz (PXA270)" in
linux-arm-kernel at lists.infradead.org.)

-- 

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus

WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Brabec <utx@penguin.cz>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [Zaurus-devel] [PATCH v2] MAX1111: Fix Race
Date: Mon, 11 Jul 2011 20:56:31 +0000	[thread overview]
Message-ID: <1310417791.17423.3.camel@utx.lan> (raw)
In-Reply-To: <1310410051-13127-1-git-send-email-morpheus.ibis@gmail.com>

Pavel Herrmann wrote:
> spi_sync call uses its spi_message parameter to keep completion information,
> having this structure static is not thread-safe, potentially causing one
> thread having pointers to memory on or above other threads stack. use mutex
> to prevent multiple access
> 
> Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> Acked-by: Cyril Hrubis <metan@ucw.cz>
Tested-by: Stanislav Brabec <utx@penguin.cz>

Tested on spitz, fixed previously reproducible OOPSes and kernel panic.

(See thread "kernel panic in spi_complete() on spitz (PXA270)" in
linux-arm-kernel@lists.infradead.org.)

-- 

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-07-11 20:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 18:47 [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Pavel Herrmann
2011-07-11 18:47 ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing NULL Pavel Herrmann
2011-07-11 20:11 ` [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Jean Delvare
2011-07-11 20:11   ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing Jean Delvare
2011-07-11 20:36   ` [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Pavel Herrmann
2011-07-11 20:36     ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing Pavel Herrmann
2011-07-11 21:03     ` [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Guenter Roeck
2011-07-11 21:03       ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing Guenter Roeck
2011-07-11 21:49       ` [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Pavel Herrmann
2011-07-11 21:49         ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing Pavel Herrmann
2011-07-12  6:48         ` [PATCH v2] MAX1111: Fix Race condition causing NULL pointer exception Jean Delvare
2011-07-12  6:48           ` [lm-sensors] [PATCH v2] MAX1111: Fix Race condition causing Jean Delvare
2011-07-11 20:56 ` Stanislav Brabec [this message]
2011-07-11 20:56   ` [lm-sensors] [Zaurus-devel] [PATCH v2] MAX1111: Fix Race Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310417791.17423.3.camel@utx.lan \
    --to=utx@penguin.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.