[Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

[Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

[Luiz Capitulino]

Please, see individual patches for details.

v2

 o Correct man-page text
 o Document -drive options in qemu-config.c

 qemu-config.c   |    6 ++++++
 qemu-options.hx |    8 ++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 1/2] qemu-options.hx: Document missing -drive options

[Luiz Capitulino]

They are 'werror', 'rerror' and 'readonly'.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-options.hx |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index e6d7adc..64114dd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -160,6 +160,14 @@ an untrusted format header.
 This option specifies the serial number to assign to the device.
 @item addr=@var{addr}
 Specify the controller's PCI address (if=virtio only).
+@item werror=@var{action},rerror=@var{action}
+Specify which @var{action} to take on write and read errors. Valid actions are:
+"ignore" (ignore the error and try to continue), "stop" (pause QEMU),
+"report" (report the error to the guest), "enospc" (pause QEMU only if the
+host disk is full; report the error to the guest otherwise).
+The default setting is @option{werror=enospc} and @option{rerror=report}.
+@item readonly
+Open drive @option{file} as read-only. Guest write attempts will fail.
 @end table
 
 By default, writethrough caching is used for all block device.  This means that
-- 
1.7.6.134.gcf13f

[Qemu-devel] [PATCH 2/2] qemu-config: Document -drive options

[Luiz Capitulino]

From: Luiz Capitulino <lcapitulino@gmail.com>

Signed-off-by: Luiz Capitulino <lcapitulino@gmail.com>
---
 qemu-config.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/qemu-config.c b/qemu-config.c
index c63741c..93d20c6 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -23,6 +23,7 @@ static QemuOptsList qemu_drive_opts = {
         },{
             .name = "index",
             .type = QEMU_OPT_NUMBER,
+            .help = "index number",
         },{
             .name = "cyls",
             .type = QEMU_OPT_NUMBER,
@@ -46,6 +47,7 @@ static QemuOptsList qemu_drive_opts = {
         },{
             .name = "snapshot",
             .type = QEMU_OPT_BOOL,
+            .help = "enable/disable snapshot mode",
         },{
             .name = "file",
             .type = QEMU_OPT_STRING,
@@ -65,12 +67,15 @@ static QemuOptsList qemu_drive_opts = {
         },{
             .name = "serial",
             .type = QEMU_OPT_STRING,
+            .help = "disk serial number",
         },{
             .name = "rerror",
             .type = QEMU_OPT_STRING,
+            .help = "read error action",
         },{
             .name = "werror",
             .type = QEMU_OPT_STRING,
+            .help = "write error action",
         },{
             .name = "addr",
             .type = QEMU_OPT_STRING,
@@ -78,6 +83,7 @@ static QemuOptsList qemu_drive_opts = {
         },{
             .name = "readonly",
             .type = QEMU_OPT_BOOL,
+            .help = "open drive file as read-only",
         },
         { /* end of list */ }
     },
-- 
1.7.6.134.gcf13f

Re: [Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

[Kevin Wolf]

Am 12.07.2011 22:35, schrieb Luiz Capitulino:
> Please, see individual patches for details.
> 
> v2
> 
>  o Correct man-page text
>  o Document -drive options in qemu-config.c
> 
>  qemu-config.c   |    6 ++++++
>  qemu-options.hx |    8 ++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)

Thanks, applied both to the block branch.

Are the help texts in qemu-config.c actually used anywhere?

Kevin

Re: [Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

[Luiz Capitulino]

On Wed, 13 Jul 2011 10:01:49 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 12.07.2011 22:35, schrieb Luiz Capitulino:
> > Please, see individual patches for details.
> > 
> > v2
> > 
> >  o Correct man-page text
> >  o Document -drive options in qemu-config.c
> > 
> >  qemu-config.c   |    6 ++++++
> >  qemu-options.hx |    8 ++++++++
> >  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> Thanks, applied both to the block branch.
> 
> Are the help texts in qemu-config.c actually used anywhere?

Good question. I thought we had something like 'qemu -drive ?' but apparently
we don't.