* [PATCH 0/2] Hob integration patches
@ 2011-07-12 23:24 Joshua Lock
2011-07-12 23:24 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Joshua Lock @ 2011-07-12 23:24 UTC (permalink / raw)
To: openembedded-core
Hob is the BitBake GUI I've been working on, the following pair of patches
make it a little more nicely integrated into OE-Core.
The first adds a variable to image_types.bbclass that the GUI can use to
determine what image types are available.
The second adds a wrapper script to call the GUI with a postfile, if the UI
can find hob.local.conf any configuration settings made in the UI will be
written to that file, rather than local.conf, ensuring that configuration
changes made in the GUI don't affect CLI builds.
The following changes since commit a6e9edb7b4b5b0bdb067a59d691d33fba8948963:
sato-sdk: add clutter for sato-sdk image (2011-07-12 15:23:35 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib josh/hob
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/hob
Joshua Lock (2):
classes/image_types: add a variable to list available IMAGE_FSTYPE's
scripts/hob: wrapper script to run hob gui with a UI specific config
file
meta/classes/image_types.bbclass | 2 ++
scripts/hob | 18 ++++++++++++++++++
2 files changed, 20 insertions(+), 0 deletions(-)
create mode 100755 scripts/hob
--
1.7.6
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-12 23:24 [PATCH 0/2] Hob integration patches Joshua Lock @ 2011-07-12 23:24 ` Joshua Lock 2011-07-12 23:38 ` Tom Rini 2011-07-12 23:24 ` [PATCH 2/2] scripts/hob: wrapper script to run hob gui with a UI specific config file Joshua Lock 2011-07-19 18:29 ` [PATCH 0/2] Hob integration patches Saul Wold 2 siblings, 1 reply; 16+ messages in thread From: Joshua Lock @ 2011-07-12 23:24 UTC (permalink / raw) To: openembedded-core This is for use in the Hob GUI to enable the user to change the type of the generated image. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- meta/classes/image_types.bbclass | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass index 89a745c..29d7a57 100644 --- a/meta/classes/image_types.bbclass +++ b/meta/classes/image_types.bbclass @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" IMAGE_DEPENDS_ubi = "mtd-utils-native" IMAGE_DEPENDS_ubifs = "mtd-utils-native" +# This variable is available to request which values are suitable for IMAGE_FSTYPES +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi ubifs" -- 1.7.6 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-12 23:24 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock @ 2011-07-12 23:38 ` Tom Rini 2011-07-13 0:37 ` Gary Thomas 2011-07-13 2:33 ` Joshua Lock 0 siblings, 2 replies; 16+ messages in thread From: Tom Rini @ 2011-07-12 23:38 UTC (permalink / raw) To: openembedded-core On 07/12/2011 04:24 PM, Joshua Lock wrote: > This is for use in the Hob GUI to enable the user to change the type of the > generated image. > > Signed-off-by: Joshua Lock <josh@linux.intel.com> > --- > meta/classes/image_types.bbclass | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass > index 89a745c..29d7a57 100644 > --- a/meta/classes/image_types.bbclass > +++ b/meta/classes/image_types.bbclass > @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" > IMAGE_DEPENDS_ubi = "mtd-utils-native" > IMAGE_DEPENDS_ubifs = "mtd-utils-native" > > +# This variable is available to request which values are suitable for IMAGE_FSTYPES > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi ubifs" Concept is fine, but please don't list ubi and ubifs just list ubi. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-12 23:38 ` Tom Rini @ 2011-07-13 0:37 ` Gary Thomas 2011-07-13 0:44 ` Tom Rini 2011-07-13 2:33 ` Joshua Lock 1 sibling, 1 reply; 16+ messages in thread From: Gary Thomas @ 2011-07-13 0:37 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On 07/12/2011 05:38 PM, Tom Rini wrote: > On 07/12/2011 04:24 PM, Joshua Lock wrote: >> This is for use in the Hob GUI to enable the user to change the type of the >> generated image. >> >> Signed-off-by: Joshua Lock<josh@linux.intel.com> >> --- >> meta/classes/image_types.bbclass | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass >> index 89a745c..29d7a57 100644 >> --- a/meta/classes/image_types.bbclass >> +++ b/meta/classes/image_types.bbclass >> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >> IMAGE_DEPENDS_ubi = "mtd-utils-native" >> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >> >> +# This variable is available to request which values are suitable for IMAGE_FSTYPES >> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi ubifs" > > Concept is fine, but please don't list ubi and ubifs just list ubi. Perhaps the [brokwn] rule to explicitly build ubifs should also be purged? -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 0:37 ` Gary Thomas @ 2011-07-13 0:44 ` Tom Rini 2011-07-13 0:52 ` Gary Thomas 0 siblings, 1 reply; 16+ messages in thread From: Tom Rini @ 2011-07-13 0:44 UTC (permalink / raw) To: Gary Thomas; +Cc: Patches and discussions about the oe-core layer On 07/12/2011 05:37 PM, Gary Thomas wrote: > On 07/12/2011 05:38 PM, Tom Rini wrote: >> On 07/12/2011 04:24 PM, Joshua Lock wrote: >>> This is for use in the Hob GUI to enable the user to change the type >>> of the >>> generated image. >>> >>> Signed-off-by: Joshua Lock<josh@linux.intel.com> >>> --- >>> meta/classes/image_types.bbclass | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta/classes/image_types.bbclass >>> b/meta/classes/image_types.bbclass >>> index 89a745c..29d7a57 100644 >>> --- a/meta/classes/image_types.bbclass >>> +++ b/meta/classes/image_types.bbclass >>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>> >>> +# This variable is available to request which values are suitable >>> for IMAGE_FSTYPES >>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs >>> squashfs-lzma ubi ubifs" >> >> Concept is fine, but please don't list ubi and ubifs just list ubi. > > Perhaps the [brokwn] rule to explicitly build ubifs should also be purged? Nope, that's how the ubi is created. Essentially at the time anyhow, OE didn't make it too easy to add in an image that needs to be in a container to be used. So we have the ubifs rule (yes, that needs a cherry-pick from oe.dev) for 'advanced' users and the ubi rule to create a simple ubi image. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 0:44 ` Tom Rini @ 2011-07-13 0:52 ` Gary Thomas 2011-07-13 1:11 ` Tom Rini 0 siblings, 1 reply; 16+ messages in thread From: Gary Thomas @ 2011-07-13 0:52 UTC (permalink / raw) To: Tom Rini; +Cc: Patches and discussions about the oe-core layer On 07/12/2011 06:44 PM, Tom Rini wrote: > On 07/12/2011 05:37 PM, Gary Thomas wrote: >> On 07/12/2011 05:38 PM, Tom Rini wrote: >>> On 07/12/2011 04:24 PM, Joshua Lock wrote: >>>> This is for use in the Hob GUI to enable the user to change the type >>>> of the >>>> generated image. >>>> >>>> Signed-off-by: Joshua Lock<josh@linux.intel.com> >>>> --- >>>> meta/classes/image_types.bbclass | 2 ++ >>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/meta/classes/image_types.bbclass >>>> b/meta/classes/image_types.bbclass >>>> index 89a745c..29d7a57 100644 >>>> --- a/meta/classes/image_types.bbclass >>>> +++ b/meta/classes/image_types.bbclass >>>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >>>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>>> >>>> +# This variable is available to request which values are suitable >>>> for IMAGE_FSTYPES >>>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs >>>> squashfs-lzma ubi ubifs" >>> >>> Concept is fine, but please don't list ubi and ubifs just list ubi. >> >> Perhaps the [brokwn] rule to explicitly build ubifs should also be purged? > > Nope, that's how the ubi is created. Essentially at the time anyhow, OE > didn't make it too easy to add in an image that needs to be in a > container to be used. So we have the ubifs rule (yes, that needs a > cherry-pick from oe.dev) for 'advanced' users and the ubi rule to create > a simple ubi image. I might be missing something, but I don't see why this rule is necessary in image_types.bbclass: IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" Having it there leads to the confusion (I was) that ubifs was useful. At least for me, I can build ubi images with that rule removed. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 0:52 ` Gary Thomas @ 2011-07-13 1:11 ` Tom Rini 2011-07-13 11:24 ` Richard Purdie 0 siblings, 1 reply; 16+ messages in thread From: Tom Rini @ 2011-07-13 1:11 UTC (permalink / raw) To: Gary Thomas; +Cc: Patches and discussions about the oe-core layer On 07/12/2011 05:52 PM, Gary Thomas wrote: > On 07/12/2011 06:44 PM, Tom Rini wrote: >> On 07/12/2011 05:37 PM, Gary Thomas wrote: >>> On 07/12/2011 05:38 PM, Tom Rini wrote: >>>> On 07/12/2011 04:24 PM, Joshua Lock wrote: >>>>> This is for use in the Hob GUI to enable the user to change the type >>>>> of the >>>>> generated image. >>>>> >>>>> Signed-off-by: Joshua Lock<josh@linux.intel.com> >>>>> --- >>>>> meta/classes/image_types.bbclass | 2 ++ >>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/meta/classes/image_types.bbclass >>>>> b/meta/classes/image_types.bbclass >>>>> index 89a745c..29d7a57 100644 >>>>> --- a/meta/classes/image_types.bbclass >>>>> +++ b/meta/classes/image_types.bbclass >>>>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >>>>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>>>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>>>> >>>>> +# This variable is available to request which values are suitable >>>>> for IMAGE_FSTYPES >>>>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs >>>>> squashfs-lzma ubi ubifs" >>>> >>>> Concept is fine, but please don't list ubi and ubifs just list ubi. >>> >>> Perhaps the [brokwn] rule to explicitly build ubifs should also be >>> purged? >> >> Nope, that's how the ubi is created. Essentially at the time anyhow, OE >> didn't make it too easy to add in an image that needs to be in a >> container to be used. So we have the ubifs rule (yes, that needs a >> cherry-pick from oe.dev) for 'advanced' users and the ubi rule to create >> a simple ubi image. > > I might be missing something, but I don't see why this rule is necessary > in image_types.bbclass: > IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" > > Having it there leads to the confusion (I was) that ubifs was useful. > > At least for me, I can build ubi images with that rule removed. OK, refreshed my memory again. We have ubifs (and it might indeed need some quick kicking/fixing) target (a) since that's what was there to start with, but not quite enough (b) for advanced users. There is a point to making a ubifs image which is when you're making a complex ubi volume (either outside of OE or in your collection/layer that provides a more complex ubinize conf). The problem in oe-core today is that we were using non-standard extensions on the ubifs part to try and distinguish between usable standalone files (ubi) and parts (ubifs). -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 1:11 ` Tom Rini @ 2011-07-13 11:24 ` Richard Purdie 2011-07-13 14:10 ` Tom Rini 0 siblings, 1 reply; 16+ messages in thread From: Richard Purdie @ 2011-07-13 11:24 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, 2011-07-12 at 18:11 -0700, Tom Rini wrote: > On 07/12/2011 05:52 PM, Gary Thomas wrote: > > On 07/12/2011 06:44 PM, Tom Rini wrote: > >> On 07/12/2011 05:37 PM, Gary Thomas wrote: > >>> On 07/12/2011 05:38 PM, Tom Rini wrote: > >>>> On 07/12/2011 04:24 PM, Joshua Lock wrote: > >>>>> This is for use in the Hob GUI to enable the user to change the type > >>>>> of the > >>>>> generated image. > >>>>> > >>>>> Signed-off-by: Joshua Lock<josh@linux.intel.com> > >>>>> --- > >>>>> meta/classes/image_types.bbclass | 2 ++ > >>>>> 1 files changed, 2 insertions(+), 0 deletions(-) > >>>>> > >>>>> diff --git a/meta/classes/image_types.bbclass > >>>>> b/meta/classes/image_types.bbclass > >>>>> index 89a745c..29d7a57 100644 > >>>>> --- a/meta/classes/image_types.bbclass > >>>>> +++ b/meta/classes/image_types.bbclass > >>>>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" > >>>>> IMAGE_DEPENDS_ubi = "mtd-utils-native" > >>>>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" > >>>>> > >>>>> +# This variable is available to request which values are suitable > >>>>> for IMAGE_FSTYPES > >>>>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs > >>>>> squashfs-lzma ubi ubifs" > >>>> > >>>> Concept is fine, but please don't list ubi and ubifs just list ubi. > >>> > >>> Perhaps the [brokwn] rule to explicitly build ubifs should also be > >>> purged? > >> > >> Nope, that's how the ubi is created. Essentially at the time anyhow, OE > >> didn't make it too easy to add in an image that needs to be in a > >> container to be used. So we have the ubifs rule (yes, that needs a > >> cherry-pick from oe.dev) for 'advanced' users and the ubi rule to create > >> a simple ubi image. > > > > I might be missing something, but I don't see why this rule is necessary > > in image_types.bbclass: > > IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o > > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" > > > > Having it there leads to the confusion (I was) that ubifs was useful. > > > > At least for me, I can build ubi images with that rule removed. > > OK, refreshed my memory again. We have ubifs (and it might indeed need > some quick kicking/fixing) target (a) since that's what was there to > start with, but not quite enough (b) for advanced users. There is a > point to making a ubifs image which is when you're making a complex ubi > volume (either outside of OE or in your collection/layer that provides a > more complex ubinize conf). > > The problem in oe-core today is that we were using non-standard > extensions on the ubifs part to try and distinguish between usable > standalone files (ubi) and parts (ubifs). Surely if you're doing this extra processing, you could just define the IMAGE_CMD_ubifs variable too? I'm a little worried about having something there that is effectively unusable on its own... Cheers, Richard ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 11:24 ` Richard Purdie @ 2011-07-13 14:10 ` Tom Rini 2011-07-13 19:55 ` Koen Kooi 0 siblings, 1 reply; 16+ messages in thread From: Tom Rini @ 2011-07-13 14:10 UTC (permalink / raw) To: openembedded-core On 07/13/2011 04:24 AM, Richard Purdie wrote: > On Tue, 2011-07-12 at 18:11 -0700, Tom Rini wrote: >> On 07/12/2011 05:52 PM, Gary Thomas wrote: >>> On 07/12/2011 06:44 PM, Tom Rini wrote: >>>> On 07/12/2011 05:37 PM, Gary Thomas wrote: >>>>> On 07/12/2011 05:38 PM, Tom Rini wrote: >>>>>> On 07/12/2011 04:24 PM, Joshua Lock wrote: >>>>>>> This is for use in the Hob GUI to enable the user to change the type >>>>>>> of the >>>>>>> generated image. >>>>>>> >>>>>>> Signed-off-by: Joshua Lock<josh@linux.intel.com> >>>>>>> --- >>>>>>> meta/classes/image_types.bbclass | 2 ++ >>>>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/meta/classes/image_types.bbclass >>>>>>> b/meta/classes/image_types.bbclass >>>>>>> index 89a745c..29d7a57 100644 >>>>>>> --- a/meta/classes/image_types.bbclass >>>>>>> +++ b/meta/classes/image_types.bbclass >>>>>>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >>>>>>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>>>>>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>>>>>> >>>>>>> +# This variable is available to request which values are suitable >>>>>>> for IMAGE_FSTYPES >>>>>>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs >>>>>>> squashfs-lzma ubi ubifs" >>>>>> >>>>>> Concept is fine, but please don't list ubi and ubifs just list ubi. >>>>> >>>>> Perhaps the [brokwn] rule to explicitly build ubifs should also be >>>>> purged? >>>> >>>> Nope, that's how the ubi is created. Essentially at the time anyhow, OE >>>> didn't make it too easy to add in an image that needs to be in a >>>> container to be used. So we have the ubifs rule (yes, that needs a >>>> cherry-pick from oe.dev) for 'advanced' users and the ubi rule to create >>>> a simple ubi image. >>> >>> I might be missing something, but I don't see why this rule is necessary >>> in image_types.bbclass: >>> IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o >>> ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" >>> >>> Having it there leads to the confusion (I was) that ubifs was useful. >>> >>> At least for me, I can build ubi images with that rule removed. >> >> OK, refreshed my memory again. We have ubifs (and it might indeed need >> some quick kicking/fixing) target (a) since that's what was there to >> start with, but not quite enough (b) for advanced users. There is a >> point to making a ubifs image which is when you're making a complex ubi >> volume (either outside of OE or in your collection/layer that provides a >> more complex ubinize conf). >> >> The problem in oe-core today is that we were using non-standard >> extensions on the ubifs part to try and distinguish between usable >> standalone files (ubi) and parts (ubifs). > > Surely if you're doing this extra processing, you could just define the > IMAGE_CMD_ubifs variable too? > > I'm a little worried about having something there that is effectively > unusable on its own... Well, ubifs is unusable without being in a ubi contanier. But a ubi container can have anything in it, we just make a simple container to give people a starting point. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 14:10 ` Tom Rini @ 2011-07-13 19:55 ` Koen Kooi 0 siblings, 0 replies; 16+ messages in thread From: Koen Kooi @ 2011-07-13 19:55 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 13 jul 2011, om 16:10 heeft Tom Rini het volgende geschreven: > On 07/13/2011 04:24 AM, Richard Purdie wrote: >> On Tue, 2011-07-12 at 18:11 -0700, Tom Rini wrote: >>> On 07/12/2011 05:52 PM, Gary Thomas wrote: >>>> On 07/12/2011 06:44 PM, Tom Rini wrote: >>>>> On 07/12/2011 05:37 PM, Gary Thomas wrote: >>>>>> On 07/12/2011 05:38 PM, Tom Rini wrote: >>>>>>> On 07/12/2011 04:24 PM, Joshua Lock wrote: >>>>>>>> This is for use in the Hob GUI to enable the user to change >>>>>>>> the type >>>>>>>> of the >>>>>>>> generated image. >>>>>>>> >>>>>>>> Signed-off-by: Joshua Lock<josh@linux.intel.com> >>>>>>>> --- >>>>>>>> meta/classes/image_types.bbclass | 2 ++ >>>>>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>>>>> >>>>>>>> diff --git a/meta/classes/image_types.bbclass >>>>>>>> b/meta/classes/image_types.bbclass >>>>>>>> index 89a745c..29d7a57 100644 >>>>>>>> --- a/meta/classes/image_types.bbclass >>>>>>>> +++ b/meta/classes/image_types.bbclass >>>>>>>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" >>>>>>>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>>>>>>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>>>>>>> >>>>>>>> +# This variable is available to request which values are >>>>>>>> suitable >>>>>>>> for IMAGE_FSTYPES >>>>>>>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs >>>>>>>> squashfs-lzma ubi ubifs" >>>>>>> >>>>>>> Concept is fine, but please don't list ubi and ubifs just list >>>>>>> ubi. >>>>>> >>>>>> Perhaps the [brokwn] rule to explicitly build ubifs should also >>>>>> be >>>>>> purged? >>>>> >>>>> Nope, that's how the ubi is created. Essentially at the time >>>>> anyhow, OE >>>>> didn't make it too easy to add in an image that needs to be in a >>>>> container to be used. So we have the ubifs rule (yes, that >>>>> needs a >>>>> cherry-pick from oe.dev) for 'advanced' users and the ubi rule >>>>> to create >>>>> a simple ubi image. >>>> >>>> I might be missing something, but I don't see why this rule is >>>> necessary >>>> in image_types.bbclass: >>>> IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o >>>> ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" >>>> >>>> Having it there leads to the confusion (I was) that ubifs was >>>> useful. >>>> >>>> At least for me, I can build ubi images with that rule removed. >>> >>> OK, refreshed my memory again. We have ubifs (and it might indeed >>> need >>> some quick kicking/fixing) target (a) since that's what was there to >>> start with, but not quite enough (b) for advanced users. There is a >>> point to making a ubifs image which is when you're making a >>> complex ubi >>> volume (either outside of OE or in your collection/layer that >>> provides a >>> more complex ubinize conf). >>> >>> The problem in oe-core today is that we were using non-standard >>> extensions on the ubifs part to try and distinguish between usable >>> standalone files (ubi) and parts (ubifs). >> >> Surely if you're doing this extra processing, you could just define >> the >> IMAGE_CMD_ubifs variable too? >> >> I'm a little worried about having something there that is effectively >> unusable on its own... > > Well, ubifs is unusable without being in a ubi contanier. But a ubi > container can have anything in it, we just make a simple container to > give people a starting point. Being able to generate a eaw ubifs is usefull when you already have the container and only want to reflash, but don't want to trash the ubi erase cycle count. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-12 23:38 ` Tom Rini 2011-07-13 0:37 ` Gary Thomas @ 2011-07-13 2:33 ` Joshua Lock 1 sibling, 0 replies; 16+ messages in thread From: Joshua Lock @ 2011-07-13 2:33 UTC (permalink / raw) To: openembedded-core On Tue, 2011-07-12 at 16:38 -0700, Tom Rini wrote: > On 07/12/2011 04:24 PM, Joshua Lock wrote: > > This is for use in the Hob GUI to enable the user to change the type of the > > generated image. > > > > Signed-off-by: Joshua Lock <josh@linux.intel.com> > > --- > > meta/classes/image_types.bbclass | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass > > index 89a745c..29d7a57 100644 > > --- a/meta/classes/image_types.bbclass > > +++ b/meta/classes/image_types.bbclass > > @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" > > IMAGE_DEPENDS_ubi = "mtd-utils-native" > > IMAGE_DEPENDS_ubifs = "mtd-utils-native" > > > > +# This variable is available to request which values are suitable for IMAGE_FSTYPES > > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi ubifs" > > Concept is fine, but please don't list ubi and ubifs just list ubi. > Okey dokes, v2 coming up with only ubi listed. If it's as complex as skimming this thread seems we probably don't want ubifs in a GUI... Thanks Tom, Joshua -- Joshua Lock Yocto Project "Johannes factotum" Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] scripts/hob: wrapper script to run hob gui with a UI specific config file 2011-07-12 23:24 [PATCH 0/2] Hob integration patches Joshua Lock 2011-07-12 23:24 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock @ 2011-07-12 23:24 ` Joshua Lock 2011-07-19 18:29 ` [PATCH 0/2] Hob integration patches Saul Wold 2 siblings, 0 replies; 16+ messages in thread From: Joshua Lock @ 2011-07-12 23:24 UTC (permalink / raw) To: openembedded-core This ensures any configuration changes made in the GUI are only set when using hob. The default hob.local.conf is generated with a line which adds image_types to INHERITS so that the GUI can introspect the available FSTYPES. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- scripts/hob | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) create mode 100755 scripts/hob diff --git a/scripts/hob b/scripts/hob new file mode 100755 index 0000000..19930ba --- /dev/null +++ b/scripts/hob @@ -0,0 +1,18 @@ +#!/usr/bin/env bash +if ! (test -r "$BUILDDIR/conf/hob.local.conf"); then + cat <<EOM +You had no conf/hob.local.conf file. An initial version of this configuration +file has therefore been created for you. This file will be used to store any +configuration values you set in hob. + +EOM +(cat <<EOF +INHERIT += "image_types" +EOF +) > conf/hob.local.conf +fi + +bitbake -R conf/hob.local.conf -t xmlrpc -u hob + +ret=$? +exit $ret -- 1.7.6 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] Hob integration patches 2011-07-12 23:24 [PATCH 0/2] Hob integration patches Joshua Lock 2011-07-12 23:24 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock 2011-07-12 23:24 ` [PATCH 2/2] scripts/hob: wrapper script to run hob gui with a UI specific config file Joshua Lock @ 2011-07-19 18:29 ` Saul Wold 2011-07-19 19:10 ` Joshua Lock 2 siblings, 1 reply; 16+ messages in thread From: Saul Wold @ 2011-07-19 18:29 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On 07/12/2011 04:24 PM, Joshua Lock wrote: > Hob is the BitBake GUI I've been working on, the following pair of patches > make it a little more nicely integrated into OE-Core. > > The first adds a variable to image_types.bbclass that the GUI can use to > determine what image types are available. > > The second adds a wrapper script to call the GUI with a postfile, if the UI > can find hob.local.conf any configuration settings made in the UI will be > written to that file, rather than local.conf, ensuring that configuration > changes made in the GUI don't affect CLI builds. > > The following changes since commit a6e9edb7b4b5b0bdb067a59d691d33fba8948963: > > sato-sdk: add clutter for sato-sdk image (2011-07-12 15:23:35 +0100) > > are available in the git repository at: > git://git.openembedded.org/openembedded-core-contrib josh/hob > http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/hob > > Joshua Lock (2): > classes/image_types: add a variable to list available IMAGE_FSTYPE's > scripts/hob: wrapper script to run hob gui with a UI specific config > file > The scripts/hob patch has been merged, but the image_types is pending a v2 I believe. Thanks Sau! > meta/classes/image_types.bbclass | 2 ++ > scripts/hob | 18 ++++++++++++++++++ > 2 files changed, 20 insertions(+), 0 deletions(-) > create mode 100755 scripts/hob > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] Hob integration patches 2011-07-19 18:29 ` [PATCH 0/2] Hob integration patches Saul Wold @ 2011-07-19 19:10 ` Joshua Lock 0 siblings, 0 replies; 16+ messages in thread From: Joshua Lock @ 2011-07-19 19:10 UTC (permalink / raw) To: Saul Wold; +Cc: Patches and discussions about the oe-core layer On Tue, 2011-07-19 at 11:29 -0700, Saul Wold wrote: > On 07/12/2011 04:24 PM, Joshua Lock wrote: > > Hob is the BitBake GUI I've been working on, the following pair of patches > > make it a little more nicely integrated into OE-Core. > > > > The first adds a variable to image_types.bbclass that the GUI can use to > > determine what image types are available. > > > > The second adds a wrapper script to call the GUI with a postfile, if the UI > > can find hob.local.conf any configuration settings made in the UI will be > > written to that file, rather than local.conf, ensuring that configuration > > changes made in the GUI don't affect CLI builds. > > > > The following changes since commit a6e9edb7b4b5b0bdb067a59d691d33fba8948963: > > > > sato-sdk: add clutter for sato-sdk image (2011-07-12 15:23:35 +0100) > > > > are available in the git repository at: > > git://git.openembedded.org/openembedded-core-contrib josh/hob > > http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/hob > > > > Joshua Lock (2): > > classes/image_types: add a variable to list available IMAGE_FSTYPE's > > scripts/hob: wrapper script to run hob gui with a UI specific config > > file > > > The scripts/hob patch has been merged, but the image_types is pending a > v2 I believe. The v2 was already merged: http://git.openembedded.org/cgit.cgi/openembedded-core/commit/?id=12600138721262ce02e9dd243bcf44e52e065179 Thanks, Joshua -- Joshua Lock Yocto Project "Johannes factotum" Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <cover.1310524498.git.josh@linux.intel.com>]
* [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's [not found] <cover.1310524498.git.josh@linux.intel.com> @ 2011-07-13 2:36 ` Joshua Lock 2011-07-13 11:22 ` Richard Purdie 0 siblings, 1 reply; 16+ messages in thread From: Joshua Lock @ 2011-07-13 2:36 UTC (permalink / raw) To: openembedded-core This is for use in the Hob GUI to enable the user to change the type of the generated image. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- meta/classes/image_types.bbclass | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass index 89a745c..1108802 100644 --- a/meta/classes/image_types.bbclass +++ b/meta/classes/image_types.bbclass @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" IMAGE_DEPENDS_ubi = "mtd-utils-native" IMAGE_DEPENDS_ubifs = "mtd-utils-native" +# This variable is available to request which values are suitable for IMAGE_FSTYPES +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi" -- 1.7.6 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's 2011-07-13 2:36 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock @ 2011-07-13 11:22 ` Richard Purdie 0 siblings, 0 replies; 16+ messages in thread From: Richard Purdie @ 2011-07-13 11:22 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, 2011-07-12 at 19:36 -0700, Joshua Lock wrote: > This is for use in the Hob GUI to enable the user to change the type of the > generated image. > > Signed-off-by: Joshua Lock <josh@linux.intel.com> > --- > meta/classes/image_types.bbclass | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass > index 89a745c..1108802 100644 > --- a/meta/classes/image_types.bbclass > +++ b/meta/classes/image_types.bbclass > @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native" > IMAGE_DEPENDS_ubi = "mtd-utils-native" > IMAGE_DEPENDS_ubifs = "mtd-utils-native" > > +# This variable is available to request which values are suitable for IMAGE_FSTYPES > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi" Merged to master, thanks. Richard ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2011-07-19 19:14 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-12 23:24 [PATCH 0/2] Hob integration patches Joshua Lock
2011-07-12 23:24 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock
2011-07-12 23:38 ` Tom Rini
2011-07-13 0:37 ` Gary Thomas
2011-07-13 0:44 ` Tom Rini
2011-07-13 0:52 ` Gary Thomas
2011-07-13 1:11 ` Tom Rini
2011-07-13 11:24 ` Richard Purdie
2011-07-13 14:10 ` Tom Rini
2011-07-13 19:55 ` Koen Kooi
2011-07-13 2:33 ` Joshua Lock
2011-07-12 23:24 ` [PATCH 2/2] scripts/hob: wrapper script to run hob gui with a UI specific config file Joshua Lock
2011-07-19 18:29 ` [PATCH 0/2] Hob integration patches Saul Wold
2011-07-19 19:10 ` Joshua Lock
[not found] <cover.1310524498.git.josh@linux.intel.com>
2011-07-13 2:36 ` [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's Joshua Lock
2011-07-13 11:22 ` Richard Purdie
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.