All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: xorg-driver-ati@lists.x.org, dri-devel@lists.freedesktop.org,
	"Cédric Cano" <ccano@interfaceconcept.com>
Subject: Re: [PATCH 2/6] drm/radeon: ATOM Endian fix for atombios_crtc_program_pll()
Date: Thu, 14 Jul 2011 07:40:44 +1000	[thread overview]
Message-ID: <1310593244.4968.263.camel@pasglop> (raw)
In-Reply-To: <CADnq5_Om6yhCC3Jo0mcqmXWj=moBu6RV1c3=Hns9pmQOTcLqDg@mail.gmail.com>

On Wed, 2011-07-13 at 10:38 -0400, Alex Deucher wrote:

> >                case 6:
> > -                       args.v6.ulCrtcPclkFreq.ucCRTC = crtc_id;
> > -                       args.v6.ulCrtcPclkFreq.ulPixelClock = cpu_to_le32(clock / 10);
> > +                       args.v6.ulDispEngClkFreq = cpu_to_le32(crtc_id << 24 | clock / 10);
> 
> For clarity (i can never remember op precedence), you might put:
> 
> cpu_to_le32((crtc_id << 24) | (clock / 10));

I can't either but I have a nice chart printed on my wall :-)

I can respin if you really want but the above is correct.

Cheers,
Ben.

> Other than that,
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> 
> >                        args.v6.ucRefDiv = ref_div;
> >                        args.v6.usFbDiv = cpu_to_le16(fb_div);
> >                        args.v6.ulFbDivDecFrac = cpu_to_le32(frac_fb_div * 100000);
> >
> >
> >
> >

  reply	other threads:[~2011-07-13 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13  6:28 [PATCH 2/6] drm/radeon: ATOM Endian fix for atombios_crtc_program_pll() Benjamin Herrenschmidt
2011-07-13 14:38 ` Alex Deucher
2011-07-13 21:40   ` Benjamin Herrenschmidt [this message]
2011-07-14  2:21     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310593244.4968.263.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=alexdeucher@gmail.com \
    --cc=ccano@interfaceconcept.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=xorg-driver-ati@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.