* [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
@ 2011-07-14 11:56 Horst Kronstorfer
2011-07-15 7:33 ` Detlev Zundel
2011-07-15 9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
0 siblings, 2 replies; 8+ messages in thread
From: Horst Kronstorfer @ 2011-07-14 11:56 UTC (permalink / raw)
To: u-boot
Without telling 'find' to follow symbolic links, files under include/asm
and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index e56fa02..deff642 100644
--- a/Makefile
+++ b/Makefile
@@ -479,7 +479,7 @@ etags:
etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
-name '*.[chS]' -print`
cscope:
- find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+ find -L $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
cscope -b -q -k
SYSTEM_MAP = \
--
1.7.6
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
2011-07-14 11:56 [U-Boot] [PATCH] Let target 'cscope' follow symbolic links Horst Kronstorfer
@ 2011-07-15 7:33 ` Detlev Zundel
2011-07-15 8:11 ` KRONSTORFER Horst
2011-07-15 9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
1 sibling, 1 reply; 8+ messages in thread
From: Detlev Zundel @ 2011-07-15 7:33 UTC (permalink / raw)
To: u-boot
Hi Horst,
> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
While your point seems valid, I see three occurrences of such a find
pattern and you fix only one. May I ask you to fix all of them so users
of tags and etags are not left behind?
Thanks!
Detlev
--
A zen-buddhist walked into a pizza shop and
said, "Make me one with everything."
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
2011-07-15 7:33 ` Detlev Zundel
@ 2011-07-15 8:11 ` KRONSTORFER Horst
0 siblings, 0 replies; 8+ messages in thread
From: KRONSTORFER Horst @ 2011-07-15 8:11 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Detlev Zundel [mailto:dzu at denx.de]
> Sent: Freitag, 15. Juli 2011 09:34
> To: KRONSTORFER Horst
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
>
> Hi Horst,
>
>> Without telling 'find' to follow symbolic links, files under include/asm
>> and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
>
> While your point seems valid, I see three occurrences of such a find
> pattern and you fix only one. May I ask you to fix all of them so
> users of tags and etags are not left behind?
you're right ... will do!
br
-h
> Thanks!
> Detlev
>
> --
> A zen-buddhist walked into a pizza shop and
> said, "Make me one with everything."
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] Let source cross-reference targets follow symbolic links
2011-07-14 11:56 [U-Boot] [PATCH] Let target 'cscope' follow symbolic links Horst Kronstorfer
2011-07-15 7:33 ` Detlev Zundel
@ 2011-07-15 9:24 ` hkronsto at frequentis.com
2011-07-15 15:19 ` Detlev Zundel
2011-07-18 11:21 ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
1 sibling, 2 replies; 8+ messages in thread
From: hkronsto at frequentis.com @ 2011-07-15 9:24 UTC (permalink / raw)
To: u-boot
From: Horst Kronstorfer <hkronsto@frequentis.com>
Without telling 'find' to follow symbolic links, files under include/asm
and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
Changes for v2:
- Apply this change to all source cross-reference targets
---
Makefile | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index e56fa02..e86a81a 100644
--- a/Makefile
+++ b/Makefile
@@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS)
TAG_SUBDIRS += $(dir $(__LIBS))
TAG_SUBDIRS += include
+FIND := find -L
+
tags ctags:
- ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \
+ ctags -w -o $(obj)ctags `$(FIND) $(TAG_SUBDIRS) \
-name '*.[chS]' -print`
etags:
- etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
+ etags -a -o $(obj)etags `$(FIND) $(TAG_SUBDIRS) \
-name '*.[chS]' -print`
cscope:
- find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+ $(FIND) $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
cscope -b -q -k
SYSTEM_MAP = \
--
1.7.6
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] Let source cross-reference targets follow symbolic links
2011-07-15 9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
@ 2011-07-15 15:19 ` Detlev Zundel
2011-07-18 11:21 ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
1 sibling, 0 replies; 8+ messages in thread
From: Detlev Zundel @ 2011-07-15 15:19 UTC (permalink / raw)
To: u-boot
Hi Horst,
> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Changes for v2:
> - Apply this change to all source cross-reference targets
This needs to go below the '---' as it is not part of the git commit
message.
> ---
> Makefile | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e56fa02..e86a81a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS)
> TAG_SUBDIRS += $(dir $(__LIBS))
> TAG_SUBDIRS += include
>
> +FIND := find -L
I really dislike this approach. I would never expect a variable $(FIND)
to already include options. So if you want to go that way then also
introduce FINDFLAGS.
Thanks
Detlev
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v3] Let source cross-reference targets follow symbolic links
2011-07-15 9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
2011-07-15 15:19 ` Detlev Zundel
@ 2011-07-18 11:21 ` hkronsto at frequentis.com
2011-07-19 16:32 ` Detlev Zundel
2011-07-28 14:30 ` Wolfgang Denk
1 sibling, 2 replies; 8+ messages in thread
From: hkronsto at frequentis.com @ 2011-07-18 11:21 UTC (permalink / raw)
To: u-boot
From: Horst Kronstorfer <hkronsto@frequentis.com>
Tell 'find' to follow symbolic links, so that files under include/asm
and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
---
Changes for v2:
- Apply this change to all source cross-reference targets
Changes for v3:
- Introduce FINDFLAGS
Makefile | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index e56fa02..bc51428 100644
--- a/Makefile
+++ b/Makefile
@@ -471,15 +471,19 @@ TAG_SUBDIRS = $(SUBDIRS)
TAG_SUBDIRS += $(dir $(__LIBS))
TAG_SUBDIRS += include
+FIND := find
+FINDFLAGS := -L
+
tags ctags:
- ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \
+ ctags -w -o $(obj)ctags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \
-name '*.[chS]' -print`
etags:
- etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
+ etags -a -o $(obj)etags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \
-name '*.[chS]' -print`
cscope:
- find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+ $(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) -name '*.[chS]' -print > \
+ cscope.files
cscope -b -q -k
SYSTEM_MAP = \
--
1.7.6
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v3] Let source cross-reference targets follow symbolic links
2011-07-18 11:21 ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
@ 2011-07-19 16:32 ` Detlev Zundel
2011-07-28 14:30 ` Wolfgang Denk
1 sibling, 0 replies; 8+ messages in thread
From: Detlev Zundel @ 2011-07-19 16:32 UTC (permalink / raw)
To: u-boot
Hi,
> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Tell 'find' to follow symbolic links, so that files under include/asm
> and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
I guess I would have placed the definitions more at the beginning of the
makefile but probably that's personal taste. So
Acked-by: Detlev Zundel <dzu@denx.de>
Thanks!
Detlev
--
Indeed, the author firmly believes that the best serious work is also
good fun. We needn't apologize if we enjoy doing research.
-- Donald Knuth
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v3] Let source cross-reference targets follow symbolic links
2011-07-18 11:21 ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
2011-07-19 16:32 ` Detlev Zundel
@ 2011-07-28 14:30 ` Wolfgang Denk
1 sibling, 0 replies; 8+ messages in thread
From: Wolfgang Denk @ 2011-07-28 14:30 UTC (permalink / raw)
To: u-boot
Dear hkronsto at frequentis.com,
In message <1310988078-30444-1-git-send-email-hkronsto@frequentis.com> you wrote:
> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Tell 'find' to follow symbolic links, so that files under include/asm
> and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
> ---
> Changes for v2:
> - Apply this change to all source cross-reference targets
> Changes for v3:
> - Introduce FINDFLAGS
>
> Makefile | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Swap read error. You lose your mind.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-07-28 14:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-14 11:56 [U-Boot] [PATCH] Let target 'cscope' follow symbolic links Horst Kronstorfer
2011-07-15 7:33 ` Detlev Zundel
2011-07-15 8:11 ` KRONSTORFER Horst
2011-07-15 9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
2011-07-15 15:19 ` Detlev Zundel
2011-07-18 11:21 ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
2011-07-19 16:32 ` Detlev Zundel
2011-07-28 14:30 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.