All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2
@ 2011-08-05  7:19 ` Archit Taneja
  0 siblings, 0 replies; 5+ messages in thread
From: Archit Taneja @ 2011-08-05  7:19 UTC (permalink / raw)
  To: hvaibhav, linux-media; +Cc: koen, tomi.valkeinen, linux-omap, Archit Taneja

The DSS2 driver does not support the configuration of the update_mode of a
panel anymore. Remove the setting of update_mode done in omap_vout_probe().
Ignore configuration of TE since omap_vout driver doesn't support manual update
displays anyway.

Signed-off-by: Archit Taneja <archit@ti.com>
---
 drivers/media/video/omap/omap_vout.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c
index b5ef362..b3a5ecd 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/drivers/media/video/omap/omap_vout.c
@@ -2194,19 +2194,6 @@ static int __init omap_vout_probe(struct platform_device *pdev)
 					"'%s' Display already enabled\n",
 					def_display->name);
 			}
-			/* set the update mode */
-			if (def_display->caps &
-					OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE) {
-				if (dssdrv->enable_te)
-					dssdrv->enable_te(def_display, 0);
-				if (dssdrv->set_update_mode)
-					dssdrv->set_update_mode(def_display,
-							OMAP_DSS_UPDATE_MANUAL);
-			} else {
-				if (dssdrv->set_update_mode)
-					dssdrv->set_update_mode(def_display,
-							OMAP_DSS_UPDATE_AUTO);
-			}
 		}
 	}
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2
@ 2011-08-05  7:19 ` Archit Taneja
  0 siblings, 0 replies; 5+ messages in thread
From: Archit Taneja @ 2011-08-05  7:19 UTC (permalink / raw)
  To: hvaibhav, linux-media; +Cc: koen, tomi.valkeinen, linux-omap, Archit Taneja

The DSS2 driver does not support the configuration of the update_mode of a
panel anymore. Remove the setting of update_mode done in omap_vout_probe().
Ignore configuration of TE since omap_vout driver doesn't support manual update
displays anyway.

Signed-off-by: Archit Taneja <archit@ti.com>
---
 drivers/media/video/omap/omap_vout.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c
index b5ef362..b3a5ecd 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/drivers/media/video/omap/omap_vout.c
@@ -2194,19 +2194,6 @@ static int __init omap_vout_probe(struct platform_device *pdev)
 					"'%s' Display already enabled\n",
 					def_display->name);
 			}
-			/* set the update mode */
-			if (def_display->caps &
-					OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE) {
-				if (dssdrv->enable_te)
-					dssdrv->enable_te(def_display, 0);
-				if (dssdrv->set_update_mode)
-					dssdrv->set_update_mode(def_display,
-							OMAP_DSS_UPDATE_MANUAL);
-			} else {
-				if (dssdrv->set_update_mode)
-					dssdrv->set_update_mode(def_display,
-							OMAP_DSS_UPDATE_AUTO);
-			}
 		}
 	}
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2
  2011-08-05  7:19 ` Archit Taneja
@ 2011-08-05 18:08   ` Koen Kooi
  -1 siblings, 0 replies; 5+ messages in thread
From: Koen Kooi @ 2011-08-05 18:08 UTC (permalink / raw)
  To: Archit Taneja; +Cc: hvaibhav, linux-media, tomi.valkeinen, linux-omap


Op 5 aug 2011, om 09:19 heeft Archit Taneja het volgende geschreven:

> The DSS2 driver does not support the configuration of the  
> update_mode of a
> panel anymore. Remove the setting of update_mode done in  
> omap_vout_probe().
> Ignore configuration of TE since omap_vout driver doesn't support  
> manual update
> displays anyway.
>
> Signed-off-by: Archit Taneja <archit@ti.com>

Tested-by: Koen Kooi <koen@dominion.thruhere.net>

> ---
> drivers/media/video/omap/omap_vout.c |   13 -------------
> 1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/ 
> video/omap/omap_vout.c
> index b5ef362..b3a5ecd 100644
> --- a/drivers/media/video/omap/omap_vout.c
> +++ b/drivers/media/video/omap/omap_vout.c
> @@ -2194,19 +2194,6 @@ static int __init omap_vout_probe(struct  
> platform_device *pdev)
> 					"'%s' Display already enabled\n",
> 					def_display->name);
> 			}
> -			/* set the update mode */
> -			if (def_display->caps &
> -					OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE) {
> -				if (dssdrv->enable_te)
> -					dssdrv->enable_te(def_display, 0);
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_MANUAL);
> -			} else {
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_AUTO);
> -			}
> 		}
> 	}
>
> -- 
> 1.7.1
>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2
@ 2011-08-05 18:08   ` Koen Kooi
  0 siblings, 0 replies; 5+ messages in thread
From: Koen Kooi @ 2011-08-05 18:08 UTC (permalink / raw)
  To: Archit Taneja; +Cc: hvaibhav, linux-media, tomi.valkeinen, linux-omap


Op 5 aug 2011, om 09:19 heeft Archit Taneja het volgende geschreven:

> The DSS2 driver does not support the configuration of the  
> update_mode of a
> panel anymore. Remove the setting of update_mode done in  
> omap_vout_probe().
> Ignore configuration of TE since omap_vout driver doesn't support  
> manual update
> displays anyway.
>
> Signed-off-by: Archit Taneja <archit@ti.com>

Tested-by: Koen Kooi <koen@dominion.thruhere.net>

> ---
> drivers/media/video/omap/omap_vout.c |   13 -------------
> 1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/ 
> video/omap/omap_vout.c
> index b5ef362..b3a5ecd 100644
> --- a/drivers/media/video/omap/omap_vout.c
> +++ b/drivers/media/video/omap/omap_vout.c
> @@ -2194,19 +2194,6 @@ static int __init omap_vout_probe(struct  
> platform_device *pdev)
> 					"'%s' Display already enabled\n",
> 					def_display->name);
> 			}
> -			/* set the update mode */
> -			if (def_display->caps &
> -					OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE) {
> -				if (dssdrv->enable_te)
> -					dssdrv->enable_te(def_display, 0);
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_MANUAL);
> -			} else {
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_AUTO);
> -			}
> 		}
> 	}
>
> -- 
> 1.7.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2
  2011-08-05  7:19 ` Archit Taneja
  (?)
  (?)
@ 2011-08-11 12:05 ` Hiremath, Vaibhav
  -1 siblings, 0 replies; 5+ messages in thread
From: Hiremath, Vaibhav @ 2011-08-11 12:05 UTC (permalink / raw)
  To: Taneja, Archit, linux-media; +Cc: koen, Valkeinen, Tomi, linux-omap


> -----Original Message-----
> From: Taneja, Archit
> Sent: Friday, August 05, 2011 12:49 PM
> To: Hiremath, Vaibhav; linux-media@vger.kernel.org
> Cc: koen@dominion.thruhere.net; Valkeinen, Tomi; linux-
> omap@vger.kernel.org; Taneja, Archit
> Subject: [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode
> removal in DSS2
> 
> The DSS2 driver does not support the configuration of the update_mode of a
> panel anymore. Remove the setting of update_mode done in omap_vout_probe().
> Ignore configuration of TE since omap_vout driver doesn't support manual
> update
> displays anyway.
> 
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
>  drivers/media/video/omap/omap_vout.c |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
> 
[Hiremath, Vaibhav] 

Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>
Tested-by: Vaibhav Hiremath <hvaibhav@ti.com>

Since this is bug fix (results in build failure), I will queue up for next rc.

Thanks,
Vaibhav

> diff --git a/drivers/media/video/omap/omap_vout.c
> b/drivers/media/video/omap/omap_vout.c
> index b5ef362..b3a5ecd 100644
> --- a/drivers/media/video/omap/omap_vout.c
> +++ b/drivers/media/video/omap/omap_vout.c
> @@ -2194,19 +2194,6 @@ static int __init omap_vout_probe(struct
> platform_device *pdev)
>  					"'%s' Display already enabled\n",
>  					def_display->name);
>  			}
> -			/* set the update mode */
> -			if (def_display->caps &
> -					OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE) {
> -				if (dssdrv->enable_te)
> -					dssdrv->enable_te(def_display, 0);
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_MANUAL);
> -			} else {
> -				if (dssdrv->set_update_mode)
> -					dssdrv->set_update_mode(def_display,
> -							OMAP_DSS_UPDATE_AUTO);
> -			}
>  		}
>  	}
> 
> --
> 1.7.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-11 12:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-05  7:19 [PATCH] [media] OMAP_VOUT: Fix build break caused by update_mode removal in DSS2 Archit Taneja
2011-08-05  7:19 ` Archit Taneja
2011-08-05 18:08 ` Koen Kooi
2011-08-05 18:08   ` Koen Kooi
2011-08-11 12:05 ` Hiremath, Vaibhav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.