* [PATCH] arm: mach-davinci: use kzalloc()
@ 2011-08-06 11:26 ` Thomas Meyer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Meyer @ 2011-08-06 11:26 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, Linux Kernel Mailing List
From: Thomas Meyer <thomas@m3y3r.de>
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
--- a/arch/arm/mach-davinci/dma.c 2010-10-26 18:50:12.713889353 +0200
+++ b/arch/arm/mach-davinci/dma.c 2011-08-01 20:40:38.326583216 +0200
@@ -1435,12 +1435,11 @@ static int __init edma_probe(struct plat
goto fail1;
}
- edma_cc[j] = kmalloc(sizeof(struct edma), GFP_KERNEL);
+ edma_cc[j] = kzalloc(sizeof(struct edma), GFP_KERNEL);
if (!edma_cc[j]) {
status = -ENOMEM;
goto fail1;
}
- memset(edma_cc[j], 0, sizeof(struct edma));
edma_cc[j]->num_channels = min_t(unsigned, info[j]->n_channel,
EDMA_MAX_DMACH);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: mach-davinci: use kzalloc()
@ 2011-08-06 11:26 ` Thomas Meyer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Meyer @ 2011-08-06 11:26 UTC (permalink / raw)
To: linux-arm-kernel
From: Thomas Meyer <thomas@m3y3r.de>
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
--- a/arch/arm/mach-davinci/dma.c 2010-10-26 18:50:12.713889353 +0200
+++ b/arch/arm/mach-davinci/dma.c 2011-08-01 20:40:38.326583216 +0200
@@ -1435,12 +1435,11 @@ static int __init edma_probe(struct plat
goto fail1;
}
- edma_cc[j] = kmalloc(sizeof(struct edma), GFP_KERNEL);
+ edma_cc[j] = kzalloc(sizeof(struct edma), GFP_KERNEL);
if (!edma_cc[j]) {
status = -ENOMEM;
goto fail1;
}
- memset(edma_cc[j], 0, sizeof(struct edma));
edma_cc[j]->num_channels = min_t(unsigned, info[j]->n_channel,
EDMA_MAX_DMACH);
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] arm: mach-davinci: use kzalloc()
2011-08-06 11:26 ` Thomas Meyer
@ 2011-09-01 11:57 ` Nori, Sekhar
-1 siblings, 0 replies; 4+ messages in thread
From: Nori, Sekhar @ 2011-09-01 11:57 UTC (permalink / raw)
To: Thomas Meyer, Russell King, linux-arm-kernel, Linux Kernel Mailing List
Cc: davinci-linux-open-source
On Sat, Aug 06, 2011 at 16:56:13, Thomas Meyer wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
>
> Use kzalloc rather than kmalloc followed by memset with 0
Queuing this for v3.2. While applying, I changed the
subject to:
"ARM: davinci: edma: use kzalloc()"
to be more consistent with other patch headlines.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: mach-davinci: use kzalloc()
@ 2011-09-01 11:57 ` Nori, Sekhar
0 siblings, 0 replies; 4+ messages in thread
From: Nori, Sekhar @ 2011-09-01 11:57 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 06, 2011 at 16:56:13, Thomas Meyer wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
>
> Use kzalloc rather than kmalloc followed by memset with 0
Queuing this for v3.2. While applying, I changed the
subject to:
"ARM: davinci: edma: use kzalloc()"
to be more consistent with other patch headlines.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-01 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-06 11:26 [PATCH] arm: mach-davinci: use kzalloc() Thomas Meyer
2011-08-06 11:26 ` Thomas Meyer
2011-09-01 11:57 ` Nori, Sekhar
2011-09-01 11:57 ` Nori, Sekhar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.