* [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
@ 2011-08-07 11:05 Dmitry Eremin-Solenikov
2011-08-18 11:46 ` Dmitry Eremin-Solenikov
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-08-07 11:05 UTC (permalink / raw)
To: linux-arm-kernel
The pxa2xx_sharpsl driver part is also used on collie, which (as
a StrongARM board) has different expectations for PCMCIA drivers.
So, on collie place sharpsl_pcmcia_ops in .data section rather than
in __initdata.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: stable at kernel.org
diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
index 69ae2fd..f2405dc 100644
--- a/drivers/pcmcia/pxa2xx_sharpsl.c
+++ b/drivers/pcmcia/pxa2xx_sharpsl.c
@@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
sharpsl_pcmcia_init_reset(skt);
}
+#ifdef CONFIG_SA1100_COLLIE
+static struct pcmcia_low_level sharpsl_pcmcia_ops = {
+#else
static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
+#endif
.owner = THIS_MODULE,
.hw_init = sharpsl_pcmcia_hw_init,
.hw_shutdown = sharpsl_pcmcia_hw_shutdown,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
2011-08-07 11:05 [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie Dmitry Eremin-Solenikov
@ 2011-08-18 11:46 ` Dmitry Eremin-Solenikov
2011-08-19 2:19 ` Eric Miao
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-08-18 11:46 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 7, 2011 at 3:05 PM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> The pxa2xx_sharpsl driver part is also used on collie, which (as
> a StrongARM board) has different expectations for PCMCIA drivers.
> So, on collie place sharpsl_pcmcia_ops in .data section rather than
> in __initdata.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: stable at kernel.org
Any comments on this patch?
> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
> index 69ae2fd..f2405dc 100644
> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
> @@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
> ? ? ? ?sharpsl_pcmcia_init_reset(skt);
> ?}
>
> +#ifdef CONFIG_SA1100_COLLIE
> +static struct pcmcia_low_level sharpsl_pcmcia_ops = {
> +#else
> ?static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
> +#endif
> ? ? ? ?.owner ? ? ? ? ? ? ? ? ?= THIS_MODULE,
> ? ? ? ?.hw_init ? ? ? ? ? ? ? ?= sharpsl_pcmcia_hw_init,
> ? ? ? ?.hw_shutdown ? ? ? ? ? ?= sharpsl_pcmcia_hw_shutdown,
> --
> 1.7.2.5
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
2011-08-18 11:46 ` Dmitry Eremin-Solenikov
@ 2011-08-19 2:19 ` Eric Miao
2011-08-26 20:34 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: Eric Miao @ 2011-08-19 2:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 18, 2011 at 7:46 PM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> On Sun, Aug 7, 2011 at 3:05 PM, Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com> wrote:
>> The pxa2xx_sharpsl driver part is also used on collie, which (as
>> a StrongARM board) has different expectations for PCMCIA drivers.
>> So, on collie place sharpsl_pcmcia_ops in .data section rather than
>> in __initdata.
>>
>> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> Cc: stable at kernel.org
>
> Any comments on this patch?
>
>> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
>> index 69ae2fd..f2405dc 100644
>> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
>> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
>> @@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
>> ? ? ? ?sharpsl_pcmcia_init_reset(skt);
>> ?}
>>
>> +#ifdef CONFIG_SA1100_COLLIE
>> +static struct pcmcia_low_level sharpsl_pcmcia_ops = {
>> +#else
>> ?static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
>> +#endif
Looks OK, and maybe we can put it even simpler by just removing __initdata.
>> ? ? ? ?.owner ? ? ? ? ? ? ? ? ?= THIS_MODULE,
>> ? ? ? ?.hw_init ? ? ? ? ? ? ? ?= sharpsl_pcmcia_hw_init,
>> ? ? ? ?.hw_shutdown ? ? ? ? ? ?= sharpsl_pcmcia_hw_shutdown,
>> --
>> 1.7.2.5
>>
>>
>
>
>
> --
> With best wishes
> Dmitry
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
2011-08-19 2:19 ` Eric Miao
@ 2011-08-26 20:34 ` Pavel Machek
2011-08-26 20:44 ` Dmitry Eremin-Solenikov
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2011-08-26 20:34 UTC (permalink / raw)
To: linux-arm-kernel
On Fri 2011-08-19 10:19:33, Eric Miao wrote:
> On Thu, Aug 18, 2011 at 7:46 PM, Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com> wrote:
> > On Sun, Aug 7, 2011 at 3:05 PM, Dmitry Eremin-Solenikov
> > <dbaryshkov@gmail.com> wrote:
> >> The pxa2xx_sharpsl driver part is also used on collie, which (as
> >> a StrongARM board) has different expectations for PCMCIA drivers.
> >> So, on collie place sharpsl_pcmcia_ops in .data section rather than
> >> in __initdata.
> >>
> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> >> Cc: stable at kernel.org
> >
> > Any comments on this patch?
> >
> >> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
> >> index 69ae2fd..f2405dc 100644
> >> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
> >> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
> >> @@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
> >> ? ? ? ?sharpsl_pcmcia_init_reset(skt);
> >> ?}
> >>
> >> +#ifdef CONFIG_SA1100_COLLIE
> >> +static struct pcmcia_low_level sharpsl_pcmcia_ops = {
> >> +#else
> >> ?static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
> >> +#endif
>
> Looks OK, and maybe we can put it even simpler by just removing __initdata.
I'd say so; ifdef to have initdata there is just too ugly. But I
don't think it is stable material...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie
2011-08-26 20:34 ` Pavel Machek
@ 2011-08-26 20:44 ` Dmitry Eremin-Solenikov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-08-26 20:44 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On 8/27/11, Pavel Machek <pavel@ucw.cz> wrote:
> On Fri 2011-08-19 10:19:33, Eric Miao wrote:
>> On Thu, Aug 18, 2011 at 7:46 PM, Dmitry Eremin-Solenikov
>> <dbaryshkov@gmail.com> wrote:
>> > On Sun, Aug 7, 2011 at 3:05 PM, Dmitry Eremin-Solenikov
>> > <dbaryshkov@gmail.com> wrote:
>> >> The pxa2xx_sharpsl driver part is also used on collie, which (as
>> >> a StrongARM board) has different expectations for PCMCIA drivers.
>> >> So, on collie place sharpsl_pcmcia_ops in .data section rather than
>> >> in __initdata.
>> >>
>> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> >> Cc: stable at kernel.org
>> >
>> > Any comments on this patch?
>> >
>> >> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c
>> >> b/drivers/pcmcia/pxa2xx_sharpsl.c
>> >> index 69ae2fd..f2405dc 100644
>> >> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
>> >> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
>> >> @@ -219,7 +219,11 @@ static void sharpsl_pcmcia_socket_suspend(struct
>> >> soc_pcmcia_socket *skt)
>> >> sharpsl_pcmcia_init_reset(skt);
>> >> }
>> >>
>> >> +#ifdef CONFIG_SA1100_COLLIE
>> >> +static struct pcmcia_low_level sharpsl_pcmcia_ops = {
>> >> +#else
>> >> static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = {
>> >> +#endif
>>
>> Looks OK, and maybe we can put it even simpler by just removing
>> __initdata.
>
> I'd say so; ifdef to have initdata there is just too ugly. But I
> don't think it is stable material...
Maybe... And memory lost on PXA will be minimal.
It's stable material in the sense that lack of this patch causes
kernel panics.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-26 20:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-07 11:05 [PATCH] pcmcia/pxa2xx_sharpsl: retain ops structure on collie Dmitry Eremin-Solenikov
2011-08-18 11:46 ` Dmitry Eremin-Solenikov
2011-08-19 2:19 ` Eric Miao
2011-08-26 20:34 ` Pavel Machek
2011-08-26 20:44 ` Dmitry Eremin-Solenikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.