[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[Marek Vasut]

The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 drivers/mmc/mmc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

V2: Take SPI mode into account

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index cbd7567..00687d6 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout)
 
 	cmd.cmdidx = MMC_CMD_SEND_STATUS;
 	cmd.resp_type = MMC_RSP_R1;
-	cmd.cmdarg = 0;
+	if (!mmc_host_is_spi(mmc))
+		cmd.cmdarg = mmc->rca << 16;
 	cmd.flags = 0;
 
 	do {
-- 
1.7.5.4

[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[Detlev Zundel]

Hi Marek,

> The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.

Can you please use the --in-reply-to option of git-send-email (it
prompts for it when run interactively) to preserve threading for
superceding patches?  Thanks!

It would also be nice if you included the comment from your other mail
in the changelog, i.e. what problem/bug under which circumstances this
actually fixes.

Thanks
  Detlev

-- 
To summarize:  It is a well known and lamented fact  that those people who
most want to  rule people are,  ipso facto, those  least suited  to do it.
To summarize the summary: anyone who is capable of getting themselves made
President should on no account be allowed to do the job.
                              -- The Hitchhikers Guide To The Galaxy
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[Lei Wen]

Hi Marek,

On Wed, Aug 10, 2011 at 3:24 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> ?drivers/mmc/mmc.c | ? ?3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> V2: Take SPI mode into account
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index cbd7567..00687d6 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout)
>
> ? ? ? ?cmd.cmdidx = MMC_CMD_SEND_STATUS;
> ? ? ? ?cmd.resp_type = MMC_RSP_R1;
> - ? ? ? cmd.cmdarg = 0;
> + ? ? ? if (!mmc_host_is_spi(mmc))
> + ? ? ? ? ? ? ? cmd.cmdarg = mmc->rca << 16;
> ? ? ? ?cmd.flags = 0;
>
> ? ? ? ?do {
> --
> 1.7.5.4
>

This patch works fine on my MMP3 board.

Best regards,
Lei

[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[Detlev Zundel]

Hi Lei,

> Hi Marek,
>
> On Wed, Aug 10, 2011 at 3:24 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.
>>
>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> ---
>> ?drivers/mmc/mmc.c | ? ?3 ++-
>> ?1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> V2: Take SPI mode into account
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index cbd7567..00687d6 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout)
>>
>> ? ? ? ?cmd.cmdidx = MMC_CMD_SEND_STATUS;
>> ? ? ? ?cmd.resp_type = MMC_RSP_R1;
>> - ? ? ? cmd.cmdarg = 0;
>> + ? ? ? if (!mmc_host_is_spi(mmc))
>> + ? ? ? ? ? ? ? cmd.cmdarg = mmc->rca << 16;
>> ? ? ? ?cmd.flags = 0;
>>
>> ? ? ? ?do {
>> --
>> 1.7.5.4
>>
>
> This patch works fine on my MMP3 board.

We have a formal way of saying that which as a bonus gets you into the
commit-logs ;)

Tested-by: Lei Wen <adrian.wenl@gmail.com>

Cheers
  Detlev

-- 
I shall be telling this with a sigh / Somewhere ages and ages hence: /
Two roads diverged in a wood, and I-- / I took the one less traveled by, /
And that has made all the difference.              -- Robert Frost
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

[U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

[Andy Fleming]

On Aug 10, 2011, at 2:26 PM, Detlev Zundel wrote:

> Hi Lei,
> 
>> Hi Marek,
>> 
>> On Wed, Aug 10, 2011 at 3:24 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>>> The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.
>>> 
>>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>

Applied (with lei wen's "tested-by").

Thanks,
Andy