All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: linux-scsi@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
	Divy Le Ray <divy@chelsio.com>, Steve Wise <swise@chelsio.com>,
	Karen Xie <kxie@chelsio.com>,
	Mike Christie <michaelc@cs.wisc.edu>,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch
Date: Thu, 11 Aug 2011 06:47:24 -0400	[thread overview]
Message-ID: <1313059644-25087-1-git-send-email-nhorman@tuxdriver.com> (raw)

I recently submitted this:
http://marc.info/?l=linux-scsi&m=131228153521094&w=2

Patch to fix an oops in the cxgb3i iscsi driver.  I did what I thought was some
minor cleanup after testing and prior to submission.  Of course that bit me, and
and a result I introduced some build warnings that really don't need to be
there.  This patch corrects them.  Apologies for the noise

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Divy Le Ray <divy@chelsio.com>
CC: Steve Wise <swise@chelsio.com>
CC: Karen Xie <kxie@chelsio.com>
CC: Mike Christie <michaelc@cs.wisc.edu>
CC: "James E.J. Bottomley" <JBottomley@parallels.com>
---
 drivers/scsi/cxgbi/libcxgbi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index eb5625d..0890728 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -475,7 +475,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
 	struct sockaddr_in *daddr = (struct sockaddr_in *)dst_addr;
 	struct dst_entry *dst;
 	struct net_device *ndev;
-	struct cxgbi_device *cdev;
+	struct cxgbi_device *cdev = NULL;
 	struct rtable *rt = NULL;
 	struct flowi4 fl4;
 	struct cxgbi_sock *csk = NULL;
@@ -2499,7 +2499,7 @@ struct iscsi_endpoint *cxgbi_ep_connect(struct Scsi_Host *shost,
 	return ep;
 
 release_conn:
-	cdev_put(&csk->cdev);
+	cdev_put(csk->cdev);
 	cxgbi_sock_put(csk);
 	cxgbi_sock_closed(csk);
 err_out:
-- 
1.7.6


             reply	other threads:[~2011-08-11 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 10:47 Neil Horman [this message]
2011-08-11 14:04 ` [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch James Bottomley
2011-08-11 14:45   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313059644-25087-1-git-send-email-nhorman@tuxdriver.com \
    --to=nhorman@tuxdriver.com \
    --cc=JBottomley@parallels.com \
    --cc=divy@chelsio.com \
    --cc=kxie@chelsio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=swise@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.