From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: Russell King <linux@arm.linux.org.uk>,
"b-cousson@ti.com" <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>, "rnayak@ti.com" <rnayak@ti.com>,
"balbi@ti.com" <balbi@ti.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"vishwanath.bs@ti.com" <vishwanath.bs@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver
Date: Thu, 11 Aug 2011 09:38:22 -0700 [thread overview]
Message-ID: <1313080702.2214.69.camel@groeck-laptop> (raw)
In-Reply-To: <CAJ6a13bxg8po-Csc10LsFH-oES4YOKkqFoTm3kG4XzS=b2boMw@mail.gmail.com>
On Thu, 2011-08-11 at 09:00 -0400, J, KEERTHY wrote:
> On Thu, Aug 11, 2011 at 4:06 PM, Felipe Balbi <balbi@ti.com> wrote:
[ ... ]
> >> >> + temp = omap_temp_sensor_readl(temp_sensor,
> >> >> + temp_sensor->registers->bgap_counter);
> >> >> + temp = (temp & temp_sensor->registers->counter_mask) >>
> >> >> + __ffs(temp_sensor->registers->counter_mask);
> >> >
> >> > temp &= ??
> >> >
> >> >> + temp = temp * 1000 / (temp_sensor->clk_rate);
> >> >
> >> > temp *= ??
> >>
> >> Need to multiply the temp with 1000 before dividing.
> >> temp *= evaluates the RHS first and then multiplies LHS.
> >
> > temp *= 1000;
> > temp /= clk_rate;
> >
>
> Different coding style. I preferred to do it in a single line.
>
Me too.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: guenter.roeck@ericsson.com (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver
Date: Thu, 11 Aug 2011 09:38:22 -0700 [thread overview]
Message-ID: <1313080702.2214.69.camel@groeck-laptop> (raw)
In-Reply-To: <CAJ6a13bxg8po-Csc10LsFH-oES4YOKkqFoTm3kG4XzS=b2boMw@mail.gmail.com>
On Thu, 2011-08-11 at 09:00 -0400, J, KEERTHY wrote:
> On Thu, Aug 11, 2011 at 4:06 PM, Felipe Balbi <balbi@ti.com> wrote:
[ ... ]
> >> >> + temp = omap_temp_sensor_readl(temp_sensor,
> >> >> + temp_sensor->registers->bgap_counter);
> >> >> + temp = (temp & temp_sensor->registers->counter_mask) >>
> >> >> + __ffs(temp_sensor->registers->counter_mask);
> >> >
> >> > temp &= ??
> >> >
> >> >> + temp = temp * 1000 / (temp_sensor->clk_rate);
> >> >
> >> > temp *= ??
> >>
> >> Need to multiply the temp with 1000 before dividing.
> >> temp *= evaluates the RHS first and then multiplies LHS.
> >
> > temp *= 1000;
> > temp /= clk_rate;
> >
>
> Different coding style. I preferred to do it in a single line.
>
Me too.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: Russell King <linux@arm.linux.org.uk>,
"b-cousson@ti.com" <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>, "rnayak@ti.com" <rnayak@ti.com>,
"balbi@ti.com" <balbi@ti.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"vishwanath.bs@ti.com" <vishwanath.bs@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature
Date: Thu, 11 Aug 2011 16:38:22 +0000 [thread overview]
Message-ID: <1313080702.2214.69.camel@groeck-laptop> (raw)
In-Reply-To: <CAJ6a13bxg8po-Csc10LsFH-oES4YOKkqFoTm3kG4XzS=b2boMw@mail.gmail.com>
On Thu, 2011-08-11 at 09:00 -0400, J, KEERTHY wrote:
> On Thu, Aug 11, 2011 at 4:06 PM, Felipe Balbi <balbi@ti.com> wrote:
[ ... ]
> >> >> + temp = omap_temp_sensor_readl(temp_sensor,
> >> >> + temp_sensor->registers->bgap_counter);
> >> >> + temp = (temp & temp_sensor->registers->counter_mask) >>
> >> >> + __ffs(temp_sensor->registers->counter_mask);
> >> >
> >> > temp &= ??
> >> >
> >> >> + temp = temp * 1000 / (temp_sensor->clk_rate);
> >> >
> >> > temp *= ??
> >>
> >> Need to multiply the temp with 1000 before dividing.
> >> temp *= evaluates the RHS first and then multiplies LHS.
> >
> > temp *= 1000;
> > temp /= clk_rate;
> >
>
> Different coding style. I preferred to do it in a single line.
>
Me too.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-08-11 16:38 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 12:25 [RFC PATCH 0/6] OMAP4: Temperature sensor driver Keerthy
2011-08-10 12:37 ` [lm-sensors] " Keerthy
2011-08-10 12:25 ` [RFC PATCH 1/6] OMAP4: Clock: Associate clocks for OMAP temperature sensor Keerthy
2011-08-10 12:37 ` [lm-sensors] [RFC PATCH 1/6] OMAP4: Clock: Associate clocks for Keerthy
2011-08-10 12:25 ` [RFC PATCH 2/6] OMAP4: Adding the temperature sensor register set bit fields Keerthy
2011-08-10 12:37 ` [lm-sensors] [RFC PATCH 2/6] OMAP4: Adding the temperature sensor Keerthy
2011-08-10 12:25 ` [RFC PATCH 3/6] OMAP4: Hwmod: OMAP " Keerthy
2011-08-10 12:37 ` [lm-sensors] " Keerthy
2011-08-10 12:25 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Keerthy
2011-08-10 12:37 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Keerthy
2011-08-10 12:36 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Felipe Balbi
2011-08-10 12:36 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Felipe Balbi
2011-08-10 12:41 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Tony Lindgren
2011-08-10 12:41 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Tony Lindgren
2011-08-10 12:48 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Felipe Balbi
2011-08-10 12:48 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Felipe Balbi
2011-08-10 14:17 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Cousson, Benoit
2011-08-10 14:17 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Cousson, Benoit
2011-08-10 21:37 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Felipe Balbi
2011-08-10 21:37 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Felipe Balbi
2011-08-11 2:40 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support J, KEERTHY
2011-08-11 2:52 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device J, KEERTHY
2011-08-11 10:30 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Felipe Balbi
2011-08-11 10:30 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Felipe Balbi
2011-08-11 11:01 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support J, KEERTHY
2011-08-11 11:13 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device J, KEERTHY
2011-08-11 14:05 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Felipe Balbi
2011-08-11 14:05 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device Felipe Balbi
2011-08-11 14:15 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support J, KEERTHY
2011-08-11 14:27 ` [lm-sensors] [RFC PATCH 4/6] OMAP4: Temperature sensor device J, KEERTHY
2011-08-10 12:25 ` [RFC PATCH 5/6] OMAP4460: Temperature sensor data Keerthy
2011-08-10 12:37 ` [lm-sensors] " Keerthy
2011-08-10 12:37 ` Felipe Balbi
2011-08-10 12:37 ` [lm-sensors] " Felipe Balbi
2011-08-10 15:08 ` J, KEERTHY
2011-08-10 15:20 ` [lm-sensors] " J, KEERTHY
2011-08-10 12:25 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Keerthy
2011-08-10 12:37 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Keerthy
2011-08-10 12:46 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-10 12:46 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-10 12:46 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 9:57 ` J, KEERTHY
2011-08-11 10:09 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-11 9:57 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-11 10:36 ` Felipe Balbi
2011-08-11 10:36 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-11 10:36 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 13:00 ` J, KEERTHY
2011-08-11 13:12 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-11 13:00 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-11 14:12 ` Felipe Balbi
2011-08-11 14:12 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-11 14:12 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 14:25 ` Rajendra Nayak
2011-08-11 14:37 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Rajendra Nayak
2011-08-11 14:25 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Rajendra Nayak
2011-08-11 14:32 ` J, KEERTHY
2011-08-11 14:44 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-11 14:32 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-11 18:54 ` Felipe Balbi
2011-08-11 18:54 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-11 18:54 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 18:55 ` Felipe Balbi
2011-08-11 18:55 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-11 18:55 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 21:37 ` Roger Quadros
2011-08-11 21:37 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Roger Quadros
2011-08-11 21:37 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Roger Quadros
2011-08-12 1:02 ` J, KEERTHY
2011-08-12 1:14 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-12 1:02 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-12 3:26 ` Rajendra Nayak
2011-08-12 3:38 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Rajendra Nayak
2011-08-12 3:26 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Rajendra Nayak
2011-08-12 8:44 ` Felipe Balbi
2011-08-12 8:44 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Felipe Balbi
2011-08-12 8:44 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-22 23:58 ` Kevin Hilman
2011-08-22 23:58 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Kevin Hilman
2011-08-22 23:58 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Kevin Hilman
2011-08-23 4:18 ` Rajendra Nayak
2011-08-23 4:30 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Rajendra Nayak
2011-08-23 4:18 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Rajendra Nayak
2011-08-23 6:42 ` J, KEERTHY
2011-08-23 6:54 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-23 6:42 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-23 17:15 ` Kevin Hilman
2011-08-23 17:15 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Kevin Hilman
2011-08-23 17:15 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Kevin Hilman
2011-08-24 4:07 ` Rajendra Nayak
2011-08-24 4:19 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Rajendra Nayak
2011-08-24 4:07 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Rajendra Nayak
2011-08-11 16:38 ` Guenter Roeck [this message]
2011-08-11 16:38 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Guenter Roeck
2011-08-11 16:38 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Guenter Roeck
2011-08-10 16:35 ` [lm-sensors] " R, Durgadoss
2011-08-10 16:47 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die R, Durgadoss
2011-08-15 6:22 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-15 6:34 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-17 10:37 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-17 10:49 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
2011-08-17 13:45 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Guenter Roeck
2011-08-17 13:45 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Guenter Roeck
2011-08-17 15:03 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-08-17 15:15 ` [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313080702.2214.69.camel@groeck-laptop \
--to=guenter.roeck@ericsson.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=j-keerthy@ti.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lm-sensors@lm-sensors.org \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.