All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@free.fr>
To: akpm@linux-foundation.org
Cc: oleg@tv-sign.ru, bonbons@linux-vserver.org,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, serge@hallyn.com
Subject: [PATCH 2/2] Notify container-init parent a 'reboot' occured
Date: Thu, 11 Aug 2011 22:24:01 +0200	[thread overview]
Message-ID: <1313094241-3674-3-git-send-email-daniel.lezcano@free.fr> (raw)
In-Reply-To: <1313094241-3674-1-git-send-email-daniel.lezcano@free.fr>

When the reboot syscall is called and the pid namespace where the calling
process belongs to is not from the init pidns, we send a SIGCHLD with CLD_REBOOTED
to the parent of this pid namespace.

Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
---
 include/asm-generic/siginfo.h |    3 ++-
 include/linux/sched.h         |    1 +
 kernel/signal.c               |   40 ++++++++++++++++++++++++++++++++++++++++
 kernel/sys.c                  |   20 ++++++++++++++++++--
 4 files changed, 61 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/siginfo.h b/include/asm-generic/siginfo.h
index 0dd4e87..9bff4a2 100644
--- a/include/asm-generic/siginfo.h
+++ b/include/asm-generic/siginfo.h
@@ -218,7 +218,8 @@ typedef struct siginfo {
 #define CLD_TRAPPED	(__SI_CHLD|4)	/* traced child has trapped */
 #define CLD_STOPPED	(__SI_CHLD|5)	/* child has stopped */
 #define CLD_CONTINUED	(__SI_CHLD|6)	/* stopped child has continued */
-#define NSIGCHLD	6
+#define CLD_REBOOTED    (__SI_CHLD|7)   /* process was killed by a reboot */
+#define NSIGCHLD	7
 
 /*
  * SIGPOLL si_codes
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 20b03bf..c62dc9e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2170,6 +2170,7 @@ extern int kill_pgrp(struct pid *pid, int sig, int priv);
 extern int kill_pid(struct pid *pid, int sig, int priv);
 extern int kill_proc_info(int, struct siginfo *, pid_t);
 extern __must_check bool do_notify_parent(struct task_struct *, int);
+extern void do_notify_parent_cldreboot(struct task_struct *, int, char *);
 extern void __wake_up_parent(struct task_struct *p, struct task_struct *parent);
 extern void force_sig(int, struct task_struct *);
 extern int send_sig(int, struct task_struct *, int);
diff --git a/kernel/signal.c b/kernel/signal.c
index 291c970..7d3d44c 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1668,6 +1668,46 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 	return autoreap;
 }
 
+void do_notify_parent_cldreboot(struct task_struct *tsk, int why, char *buffer)
+{
+	struct siginfo info = { };
+	struct task_struct *parent;
+	struct sighand_struct *sighand;
+	unsigned long flags;
+
+	if (tsk->ptrace)
+		parent = tsk->parent;
+	else {
+		tsk = tsk->group_leader;
+		parent = tsk->real_parent;
+	}
+
+	info.si_signo = SIGCHLD;
+	info.si_errno = 0;
+	info.si_status = why;
+
+	rcu_read_lock();
+	info.si_pid = task_pid_nr_ns(tsk, parent->nsproxy->pid_ns);
+	info.si_uid = __task_cred(tsk)->uid;
+	rcu_read_unlock();
+
+	info.si_utime = cputime_to_clock_t(tsk->utime);
+	info.si_stime = cputime_to_clock_t(tsk->stime);
+
+	info.si_code = CLD_REBOOTED;
+
+	sighand = parent->sighand;
+	spin_lock_irqsave(&sighand->siglock, flags);
+	if (sighand->action[SIGCHLD-1].sa.sa_handler != SIG_IGN &&
+	    sighand->action[SIGCHLD-1].sa.sa_flags & SA_CLDREBOOT)
+		__group_send_sig_info(SIGCHLD, &info, parent);
+	/*
+	 * Even if SIGCHLD is not generated, we must wake up wait4 calls.
+	 */
+	__wake_up_parent(tsk, parent);
+	spin_unlock_irqrestore(&sighand->siglock, flags);
+}
+
 /**
  * do_notify_parent_cldstop - notify parent of stopped/continued state change
  * @tsk: task reporting the state change
diff --git a/kernel/sys.c b/kernel/sys.c
index a101ba3..8f7a9ed 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -42,6 +42,7 @@
 #include <linux/syscalls.h>
 #include <linux/kprobes.h>
 #include <linux/user_namespace.h>
+#include <linux/sched.h>
 
 #include <linux/kmsg_dump.h>
 
@@ -411,6 +412,13 @@ void kernel_power_off(void)
 }
 EXPORT_SYMBOL_GPL(kernel_power_off);
 
+static void pid_namespace_reboot(struct pid_namespace *pid_ns,
+				int cmd, char *buffer)
+{
+	struct task_struct *tsk = pid_ns->child_reaper;
+	do_notify_parent_cldreboot(tsk, cmd, buffer);
+}
+
 static DEFINE_MUTEX(reboot_mutex);
 
 /*
@@ -426,10 +434,18 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
 {
 	char buffer[256];
 	int ret = 0;
+	struct pid_namespace *pid_ns = current->nsproxy->pid_ns;
+
+        /* We only trust the superuser with rebooting the system. */
+	if (!capable(CAP_SYS_BOOT)) {
+		/* If we are not in the initial pid namespace, we send a signal
+		 * to the parent of this init pid namespace, notifying a shutdown
+		 * occured */
+		if (pid_ns != &init_pid_ns)
+			pid_namespace_reboot(pid_ns, cmd, buffer);
 
-	/* We only trust the superuser with rebooting the system. */
-	if (!capable(CAP_SYS_BOOT))
 		return -EPERM;
+	}
 
 	/* For safety, we require "magic" arguments. */
 	if (magic1 != LINUX_REBOOT_MAGIC1 ||
-- 
1.7.4.1


  parent reply	other threads:[~2011-08-11 20:25 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 20:23 [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Daniel Lezcano
     [not found] ` <1313094241-3674-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-11 20:24   ` [PATCH 1/2] add SA_CLDREBOOT flag Daniel Lezcano
2011-08-11 20:24   ` [PATCH 2/2] Notify container-init parent a 'reboot' occured Daniel Lezcano
2011-08-14 16:17   ` [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Oleg Nesterov
2011-08-11 20:24 ` [PATCH 1/2] add SA_CLDREBOOT flag Daniel Lezcano
     [not found]   ` <1313094241-3674-2-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-14 16:15     ` Oleg Nesterov
2011-08-14 16:15   ` Oleg Nesterov
     [not found]     ` <20110814161532.GA30846-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-14 16:36       ` Bruno Prémont
2011-08-14 16:36     ` Bruno Prémont
2011-08-14 17:10       ` Oleg Nesterov
     [not found]       ` <20110814183611.05937c96-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-14 17:10         ` Oleg Nesterov
2011-08-11 20:24 ` Daniel Lezcano [this message]
2011-08-11 21:09   ` [PATCH 2/2] Notify container-init parent a 'reboot' occured Serge Hallyn
2011-08-11 21:30     ` Daniel Lezcano
2011-08-11 21:30     ` Daniel Lezcano
     [not found]       ` <4E444A04.3070403-GANU6spQydw@public.gmane.org>
2011-08-11 21:50         ` Serge Hallyn
2011-08-12 16:29         ` Serge Hallyn
2011-08-12 16:29           ` Serge Hallyn
2011-08-12 20:42           ` Daniel Lezcano
     [not found]             ` <4E45904F.60904-GANU6spQydw@public.gmane.org>
2011-08-12 21:13               ` Serge Hallyn
2011-08-12 21:13             ` Serge Hallyn
2011-08-12 20:42           ` Daniel Lezcano
2011-08-11 21:50       ` Serge Hallyn
     [not found]   ` <1313094241-3674-3-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-11 21:09     ` Serge Hallyn
2011-08-13  0:19     ` Matt Helsley
2011-08-14 16:01     ` Oleg Nesterov
2011-08-13  0:19   ` Matt Helsley
2011-08-13 14:41     ` Daniel Lezcano
     [not found]     ` <20110813001959.GB5777-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2011-08-13 14:41       ` Daniel Lezcano
2011-08-14 16:01   ` Oleg Nesterov
2011-08-14 16:17 ` [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Oleg Nesterov
2011-08-14 21:36   ` Serge E. Hallyn
2011-08-15 14:47     ` Oleg Nesterov
2011-08-15 17:39       ` Serge E. Hallyn
2011-08-15 17:50         ` Daniel Lezcano
     [not found]         ` <20110815173940.GA19620-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2011-08-15 17:50           ` Daniel Lezcano
     [not found]       ` <20110815144744.GA9660-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-15 17:39         ` Serge E. Hallyn
2011-08-18 23:46         ` Daniel Lezcano
2011-08-18 23:46       ` Daniel Lezcano
2011-08-19 15:24         ` Oleg Nesterov
     [not found]           ` <20110819152416.GA17034-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 12:28             ` Daniel Lezcano
2011-08-22 12:28           ` Daniel Lezcano
2011-08-22 15:44             ` Oleg Nesterov
     [not found]               ` <20110822154448.GA8527-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 16:31                 ` Bruno Prémont
2011-08-22 16:31               ` Bruno Prémont
     [not found]                 ` <20110822183134.10390b46-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-22 17:39                   ` Oleg Nesterov
2011-08-22 17:39                 ` Oleg Nesterov
     [not found]                   ` <20110822173949.GA13242-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 19:17                     ` Bruno Prémont
2011-08-22 19:17                   ` Bruno Prémont
2011-08-23 13:33                     ` Oleg Nesterov
2011-08-23 14:09                       ` Greg Kurz
     [not found]                         ` <1314108566.3465.29.camel-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2011-08-23 14:29                           ` Oleg Nesterov
2011-08-23 14:29                         ` Oleg Nesterov
     [not found]                           ` <20110823142914.GA22593-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-24 19:44                             ` Bruno Prémont
2011-08-24 19:44                           ` Bruno Prémont
2011-08-25 15:37                             ` Oleg Nesterov
     [not found]                             ` <20110824214418.474b24c6-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-25 15:37                               ` Oleg Nesterov
     [not found]                       ` <20110823133302.GA19582-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-23 14:09                         ` Greg Kurz
     [not found]                     ` <20110822211716.7c141d5c-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-23 13:33                       ` Oleg Nesterov
     [not found]             ` <4E524B73.3050704-GANU6spQydw@public.gmane.org>
2011-08-22 15:44               ` Oleg Nesterov
     [not found]         ` <4E4DA461.8030006-GANU6spQydw@public.gmane.org>
2011-08-19 15:24           ` Oleg Nesterov
     [not found]     ` <20110814213642.GB13799-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2011-08-15 14:47       ` Oleg Nesterov
     [not found]   ` <20110814161707.GB30846-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-14 21:36     ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313094241-3674-3-git-send-email-daniel.lezcano@free.fr \
    --to=daniel.lezcano@free.fr \
    --cc=akpm@linux-foundation.org \
    --cc=bonbons@linux-vserver.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.