From: Greg Kurz <gkurz-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Bruno Prémont"
<bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot
Date: Tue, 23 Aug 2011 16:09:26 +0200 [thread overview]
Message-ID: <1314108566.3465.29.camel__2153.91122405908$1314108637$gmane$org@bahia.local> (raw)
In-Reply-To: <20110823133302.GA19582-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, 2011-08-23 at 15:33 +0200, Oleg Nesterov wrote:
> [...]
> At least now I understand why did you mention si_code/CLD before. You
> meant waitid(). I thought you were talking about the death-notifications
> which can't report CLD_ you need.
>
> I strongly object. We shouldn't uglify wait_task_zombie() to solve the
> very specific problem.
>
> And once again. sub_init->parent does wiat(&status) and sees
> WIFSIGNALED() && WTERMSIG(status) == SIGHUP. This can only mean that
> sys_reboot(LINUX_REBOOT_CMD_RESTART) was called. It _can not_ be really
> killed by SIGHUP, it must be CMD_RESTART.
>
> Why this can't work? Why do you want the additional complications?
>
I don't see either what could go wrong with you approach. It doesn't
mess with critical wait() or signal paths. It's definitely the way to
go.
Thanks.
--
Gregory Kurz gkurz-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org
Software Engineer @ IBM/Meiosys http://www.ibm.com
Tel +33 (0)534 638 479 Fax +33 (0)561 400 420
"Anarchy is about taking complete responsibility for yourself."
Alan Moore.
next prev parent reply other threads:[~2011-08-23 14:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 20:23 [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Daniel Lezcano
[not found] ` <1313094241-3674-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-11 20:24 ` [PATCH 1/2] add SA_CLDREBOOT flag Daniel Lezcano
2011-08-11 20:24 ` [PATCH 2/2] Notify container-init parent a 'reboot' occured Daniel Lezcano
2011-08-14 16:17 ` [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Oleg Nesterov
2011-08-11 20:24 ` [PATCH 1/2] add SA_CLDREBOOT flag Daniel Lezcano
[not found] ` <1313094241-3674-2-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-14 16:15 ` Oleg Nesterov
2011-08-14 16:15 ` Oleg Nesterov
[not found] ` <20110814161532.GA30846-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-14 16:36 ` Bruno Prémont
2011-08-14 16:36 ` Bruno Prémont
2011-08-14 17:10 ` Oleg Nesterov
[not found] ` <20110814183611.05937c96-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-14 17:10 ` Oleg Nesterov
2011-08-11 20:24 ` [PATCH 2/2] Notify container-init parent a 'reboot' occured Daniel Lezcano
2011-08-11 21:09 ` Serge Hallyn
2011-08-11 21:30 ` Daniel Lezcano
2011-08-11 21:30 ` Daniel Lezcano
[not found] ` <4E444A04.3070403-GANU6spQydw@public.gmane.org>
2011-08-11 21:50 ` Serge Hallyn
2011-08-12 16:29 ` Serge Hallyn
2011-08-12 16:29 ` Serge Hallyn
2011-08-12 20:42 ` Daniel Lezcano
[not found] ` <4E45904F.60904-GANU6spQydw@public.gmane.org>
2011-08-12 21:13 ` Serge Hallyn
2011-08-12 21:13 ` Serge Hallyn
2011-08-12 20:42 ` Daniel Lezcano
2011-08-11 21:50 ` Serge Hallyn
[not found] ` <1313094241-3674-3-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-08-11 21:09 ` Serge Hallyn
2011-08-13 0:19 ` Matt Helsley
2011-08-14 16:01 ` Oleg Nesterov
2011-08-13 0:19 ` Matt Helsley
2011-08-13 14:41 ` Daniel Lezcano
[not found] ` <20110813001959.GB5777-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2011-08-13 14:41 ` Daniel Lezcano
2011-08-14 16:01 ` Oleg Nesterov
2011-08-14 16:17 ` [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Oleg Nesterov
2011-08-14 21:36 ` Serge E. Hallyn
2011-08-15 14:47 ` Oleg Nesterov
2011-08-15 17:39 ` Serge E. Hallyn
2011-08-15 17:50 ` Daniel Lezcano
[not found] ` <20110815173940.GA19620-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2011-08-15 17:50 ` Daniel Lezcano
[not found] ` <20110815144744.GA9660-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-15 17:39 ` Serge E. Hallyn
2011-08-18 23:46 ` Daniel Lezcano
2011-08-18 23:46 ` Daniel Lezcano
2011-08-19 15:24 ` Oleg Nesterov
[not found] ` <20110819152416.GA17034-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 12:28 ` Daniel Lezcano
2011-08-22 12:28 ` Daniel Lezcano
2011-08-22 15:44 ` Oleg Nesterov
[not found] ` <20110822154448.GA8527-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 16:31 ` Bruno Prémont
2011-08-22 16:31 ` Bruno Prémont
[not found] ` <20110822183134.10390b46-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-22 17:39 ` Oleg Nesterov
2011-08-22 17:39 ` Oleg Nesterov
[not found] ` <20110822173949.GA13242-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-22 19:17 ` Bruno Prémont
2011-08-22 19:17 ` Bruno Prémont
2011-08-23 13:33 ` Oleg Nesterov
2011-08-23 14:09 ` Greg Kurz
[not found] ` <1314108566.3465.29.camel-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2011-08-23 14:29 ` Oleg Nesterov
2011-08-23 14:29 ` Oleg Nesterov
[not found] ` <20110823142914.GA22593-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-24 19:44 ` Bruno Prémont
2011-08-24 19:44 ` Bruno Prémont
2011-08-25 15:37 ` Oleg Nesterov
[not found] ` <20110824214418.474b24c6-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-25 15:37 ` Oleg Nesterov
[not found] ` <20110823133302.GA19582-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-23 14:09 ` Greg Kurz [this message]
[not found] ` <20110822211716.7c141d5c-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2011-08-23 13:33 ` Oleg Nesterov
[not found] ` <4E524B73.3050704-GANU6spQydw@public.gmane.org>
2011-08-22 15:44 ` Oleg Nesterov
[not found] ` <4E4DA461.8030006-GANU6spQydw@public.gmane.org>
2011-08-19 15:24 ` Oleg Nesterov
[not found] ` <20110814213642.GB13799-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2011-08-15 14:47 ` Oleg Nesterov
[not found] ` <20110814161707.GB30846-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-14 21:36 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 20:23 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1314108566.3465.29.camel__2153.91122405908$1314108637$gmane$org@bahia.local' \
--to=gkurz-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.