[PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

[PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This changeset replaces s3c-pl330.x clock device names with
dma-pl330.x, otherwise there won't be a correspondence between clock
device name and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

The changes are based on linux-samsung/next/topic-dma-pl330 branch.

Vladimir Zapolskiy (3):
  ARM: EXYNOS4: use dma-pl330 device name for clock
  ARM: S5PC100: use dma-pl330 device name for clock
  ARM: S5PV210: use dma-pl330 device name for clock

 arch/arm/mach-exynos4/clock.c |    4 ++--
 arch/arm/mach-s5pc100/clock.c |    4 ++--
 arch/arm/mach-s5pv210/clock.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
1.7.5.1

[PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This changeset replaces s3c-pl330.x clock device names with
dma-pl330.x, otherwise there won't be a correspondence between clock
device name and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

The changes are based on linux-samsung/next/topic-dma-pl330 branch.

Vladimir Zapolskiy (3):
  ARM: EXYNOS4: use dma-pl330 device name for clock
  ARM: S5PC100: use dma-pl330 device name for clock
  ARM: S5PV210: use dma-pl330 device name for clock

 arch/arm/mach-exynos4/clock.c |    4 ++--
 arch/arm/mach-s5pc100/clock.c |    4 ++--
 arch/arm/mach-s5pv210/clock.c |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
1.7.5.1

[PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-exynos4/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
index fee2dd8..04c997a 100644
--- a/arch/arm/mach-exynos4/clock.c
+++ b/arch/arm/mach-exynos4/clock.c
@@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 10),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.enable		= exynos4_clk_ip_fsys_ctrl,
 		.ctrlbit	= (1 << 0),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.enable		= exynos4_clk_ip_fsys_ctrl,
 		.ctrlbit	= (1 << 1),
 	}, {
-- 
1.7.5.1

[PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-exynos4/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
index fee2dd8..04c997a 100644
--- a/arch/arm/mach-exynos4/clock.c
+++ b/arch/arm/mach-exynos4/clock.c
@@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 10),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.enable		= exynos4_clk_ip_fsys_ctrl,
 		.ctrlbit	= (1 << 0),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.enable		= exynos4_clk_ip_fsys_ctrl,
 		.ctrlbit	= (1 << 1),
 	}, {
-- 
1.7.5.1

[PATCH 2/3] ARM: S5PC100: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-s5pc100/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/mach-s5pc100/clock.c
index 6527c05..8d47709 100644
--- a/arch/arm/mach-s5pc100/clock.c
+++ b/arch/arm/mach-s5pc100/clock.c
@@ -460,13 +460,13 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 2),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.parent		= &clk_div_d1_bus.clk,
 		.enable		= s5pc100_d1_0_ctrl,
 		.ctrlbit	= (1 << 1),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.parent		= &clk_div_d1_bus.clk,
 		.enable		= s5pc100_d1_0_ctrl,
 		.ctrlbit	= (1 << 0),
-- 
1.7.5.1

[PATCH 2/3] ARM: S5PC100: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-s5pc100/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/mach-s5pc100/clock.c
index 6527c05..8d47709 100644
--- a/arch/arm/mach-s5pc100/clock.c
+++ b/arch/arm/mach-s5pc100/clock.c
@@ -460,13 +460,13 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 2),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.parent		= &clk_div_d1_bus.clk,
 		.enable		= s5pc100_d1_0_ctrl,
 		.ctrlbit	= (1 << 1),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.parent		= &clk_div_d1_bus.clk,
 		.enable		= s5pc100_d1_0_ctrl,
 		.ctrlbit	= (1 << 0),
-- 
1.7.5.1

[PATCH 3/3] ARM: S5PV210: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-s5pv210/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
index d35726a..239aaad 100644
--- a/arch/arm/mach-s5pv210/clock.c
+++ b/arch/arm/mach-s5pv210/clock.c
@@ -295,13 +295,13 @@ static struct clk_ops clk_fout_apll_ops = {
 static struct clk init_clocks_off[] = {
 	{
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.parent		= &clk_hclk_psys.clk,
 		.enable		= s5pv210_clk_ip0_ctrl,
 		.ctrlbit	= (1 << 3),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.parent		= &clk_hclk_psys.clk,
 		.enable		= s5pv210_clk_ip0_ctrl,
 		.ctrlbit	= (1 << 4),
-- 
1.7.5.1

[PATCH 3/3] ARM: S5PV210: use dma-pl330 device name for clock

[Vladimir Zapolskiy]

This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.

Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
  dma-pl330 dma-pl330.0: Cannot get operation clock.
  dma-pl330: probe of dma-pl330.0 failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Boojin Kim <boojin.kim@samsung.com>
---
 arch/arm/mach-s5pv210/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
index d35726a..239aaad 100644
--- a/arch/arm/mach-s5pv210/clock.c
+++ b/arch/arm/mach-s5pv210/clock.c
@@ -295,13 +295,13 @@ static struct clk_ops clk_fout_apll_ops = {
 static struct clk init_clocks_off[] = {
 	{
 		.name		= "dma",
-		.devname	= "s3c-pl330.0",
+		.devname	= "dma-pl330.0",
 		.parent		= &clk_hclk_psys.clk,
 		.enable		= s5pv210_clk_ip0_ctrl,
 		.ctrlbit	= (1 << 3),
 	}, {
 		.name		= "dma",
-		.devname	= "s3c-pl330.1",
+		.devname	= "dma-pl330.1",
 		.parent		= &clk_hclk_psys.clk,
 		.enable		= s5pv210_clk_ip0_ctrl,
 		.ctrlbit	= (1 << 4),
-- 
1.7.5.1

RE: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock

[Boojin Kim]

Vladimir Zapolskiy wrote:
> Sent: Wednesday, August 17, 2011 6:31 AM
> To: Kukjin Kim
> Cc: linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Vladimir Zapolskiy; Boojin Kim
> Subject: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock
>
> This change replaces s3c-pl330.x clock device names with dma-pl330.x,
> otherwise there won't be a correspondence between clock device name
> and amba device name, thus clocks can't be enabled.
>
> Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
>   dma-pl330 dma-pl330.0: Cannot get operation clock.
>   dma-pl330: probe of dma-pl330.0 failed with error -22
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Boojin Kim <boojin.kim@samsung.com>
> ---
>  arch/arm/mach-exynos4/clock.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-
> exynos4/clock.c
> index fee2dd8..04c997a 100644
> --- a/arch/arm/mach-exynos4/clock.c
> +++ b/arch/arm/mach-exynos4/clock.c
> @@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
>  		.ctrlbit	= (1 << 10),
>  	}, {
>  		.name		= "dma",
> -		.devname	= "s3c-pl330.0",
> +		.devname	= "dma-pl330.0",
>  		.enable		= exynos4_clk_ip_fsys_ctrl,
>  		.ctrlbit	= (1 << 0),
>  	}, {
>  		.name		= "dma",
> -		.devname	= "s3c-pl330.1",
> +		.devname	= "dma-pl330.1",
>  		.enable		= exynos4_clk_ip_fsys_ctrl,
>  		.ctrlbit	= (1 << 1),
>  	}, {
> --
> 1.7.5.1

I checked this patch just now.
This patch looks good to me. but this missed regarding s5p64x0 dma-pl330
clock.
So, need to following.

diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c
b/arch/arm/mach-s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 8),
 	}, {
 		.name		= "dma",
+		.devname	= "dma-pl330",
 		.parent		= &clk_hclk_low.clk,
 		.enable		= s5p64x0_hclk0_ctrl,
 		.ctrlbit	= (1 << 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c
b/arch/arm/mach-s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 3),
 	}, {
 		.name		= "dma",
+		.devname	= "dma-pl330",
 		.parent		= &clk_hclk_low.clk,
 		.enable		= s5p64x0_hclk0_ctrl,
 		.ctrlbit	= (1 << 12),

Ohters, looks ok to me
Acked-by: Boojin Kim <boojin.kim@samsung.com>

[PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock

[Boojin Kim]

Vladimir Zapolskiy wrote:
> Sent: Wednesday, August 17, 2011 6:31 AM
> To: Kukjin Kim
> Cc: linux-samsung-soc at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; Vladimir Zapolskiy; Boojin Kim
> Subject: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock
>
> This change replaces s3c-pl330.x clock device names with dma-pl330.x,
> otherwise there won't be a correspondence between clock device name
> and amba device name, thus clocks can't be enabled.
>
> Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
>   dma-pl330 dma-pl330.0: Cannot get operation clock.
>   dma-pl330: probe of dma-pl330.0 failed with error -22
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Boojin Kim <boojin.kim@samsung.com>
> ---
>  arch/arm/mach-exynos4/clock.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-
> exynos4/clock.c
> index fee2dd8..04c997a 100644
> --- a/arch/arm/mach-exynos4/clock.c
> +++ b/arch/arm/mach-exynos4/clock.c
> @@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
>  		.ctrlbit	= (1 << 10),
>  	}, {
>  		.name		= "dma",
> -		.devname	= "s3c-pl330.0",
> +		.devname	= "dma-pl330.0",
>  		.enable		= exynos4_clk_ip_fsys_ctrl,
>  		.ctrlbit	= (1 << 0),
>  	}, {
>  		.name		= "dma",
> -		.devname	= "s3c-pl330.1",
> +		.devname	= "dma-pl330.1",
>  		.enable		= exynos4_clk_ip_fsys_ctrl,
>  		.ctrlbit	= (1 << 1),
>  	}, {
> --
> 1.7.5.1

I checked this patch just now.
This patch looks good to me. but this missed regarding s5p64x0 dma-pl330
clock.
So, need to following.

diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c
b/arch/arm/mach-s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 8),
 	}, {
 		.name		= "dma",
+		.devname	= "dma-pl330",
 		.parent		= &clk_hclk_low.clk,
 		.enable		= s5p64x0_hclk0_ctrl,
 		.ctrlbit	= (1 << 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c
b/arch/arm/mach-s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
 		.ctrlbit	= (1 << 3),
 	}, {
 		.name		= "dma",
+		.devname	= "dma-pl330",
 		.parent		= &clk_hclk_low.clk,
 		.enable		= s5p64x0_hclk0_ctrl,
 		.ctrlbit	= (1 << 12),

Ohters, looks ok to me
Acked-by: Boojin Kim <boojin.kim@samsung.com>

RE: [PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

[Kukjin Kim]

Vladimir Zapolskiy wrote:
> 
> This changeset replaces s3c-pl330.x clock device names with
> dma-pl330.x, otherwise there won't be a correspondence between clock
> device name and amba device name, thus clocks can't be enabled.
> 
> Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
>   dma-pl330 dma-pl330.0: Cannot get operation clock.
>   dma-pl330: probe of dma-pl330.0 failed with error -22
> 
> The changes are based on linux-samsung/next/topic-dma-pl330 branch.
> 
> Vladimir Zapolskiy (3):
>   ARM: EXYNOS4: use dma-pl330 device name for clock
>   ARM: S5PC100: use dma-pl330 device name for clock
>   ARM: S5PV210: use dma-pl330 device name for clock
> 
>  arch/arm/mach-exynos4/clock.c |    4 ++--
>  arch/arm/mach-s5pc100/clock.c |    4 ++--
>  arch/arm/mach-s5pv210/clock.c |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> --
> 1.7.5.1

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

[Kukjin Kim]

Vladimir Zapolskiy wrote:
> 
> This changeset replaces s3c-pl330.x clock device names with
> dma-pl330.x, otherwise there won't be a correspondence between clock
> device name and amba device name, thus clocks can't be enabled.
> 
> Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
>   dma-pl330 dma-pl330.0: Cannot get operation clock.
>   dma-pl330: probe of dma-pl330.0 failed with error -22
> 
> The changes are based on linux-samsung/next/topic-dma-pl330 branch.
> 
> Vladimir Zapolskiy (3):
>   ARM: EXYNOS4: use dma-pl330 device name for clock
>   ARM: S5PC100: use dma-pl330 device name for clock
>   ARM: S5PV210: use dma-pl330 device name for clock
> 
>  arch/arm/mach-exynos4/clock.c |    4 ++--
>  arch/arm/mach-s5pc100/clock.c |    4 ++--
>  arch/arm/mach-s5pv210/clock.c |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> --
> 1.7.5.1

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.