* [U-Boot] [PATCH v2 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all'
@ 2011-08-16 23:38 Joel A Fernandes
0 siblings, 0 replies; only message in thread
From: Joel A Fernandes @ 2011-08-16 23:38 UTC (permalink / raw)
To: u-boot
Fix for only one led getting set or reset when the led_name is 'all'
Previous discussion:
http://lists.denx.de/pipermail/u-boot/2011-May/093068.html
Changes since v1:
Fixed checkpatch if statement error noticed by Sergei.
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
---
common/cmd_led.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/common/cmd_led.c b/common/cmd_led.c
index d14dd5a..183dc0b 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -108,7 +108,9 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} else {
__led_set(led_commands[i].mask, state);
}
- break;
+ /* Need to set only 1 led if led_name wasn't 'all' */
+ if (strcmp("all", argv[1]) != 0)
+ break;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-16 23:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-16 23:38 [U-Boot] [PATCH v2 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all' Joel A Fernandes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.