From: Anand Gadiyar <gadiyar@ti.com> To: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-usb@vger.kernel.org> Cc: Anand Gadiyar <gadiyar@ti.com>, Keshava Munegowda <keshava_mgowda@ti.com>, Samuel Ortiz <sameo@linux.intel.com> Subject: [PATCH] mfd: omap-usb-host: Make TLL mode work again Date: Thu, 18 Aug 2011 16:14:31 +0530 [thread overview] Message-ID: <1313664271-694-1-git-send-email-gadiyar@ti.com> (raw) This code section seems to have been accidentally copy pasted. It causes incorrect bits to be set up in the TLL_CHANNEL_CONF register and prevents the TLL mode from working correctly. Signed-off-by: Anand Gadiyar <gadiyar@ti.com> Cc: Keshava Munegowda <keshava_mgowda@ti.com> Cc: Samuel Ortiz <sameo@linux.intel.com> --- Against v3.1-rc2; tested against linux-next as of 20110817 as well. This probably needs to go to -stable as well. The original code by me worked fine but this was broken during the code reorganization Keshava did. drivers/mfd/omap-usb-host.c | 1 - 1 file changed, 1 deletion(-) Index: linux-2.6/drivers/mfd/omap-usb-host.c =================================================================== --- linux-2.6.orig/drivers/mfd/omap-usb-host.c +++ linux-2.6/drivers/mfd/omap-usb-host.c @@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); - reg |= (1 << (i + 1)); } else continue;
WARNING: multiple messages have this Message-ID (diff)
From: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org> To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>, Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>, Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Subject: [PATCH] mfd: omap-usb-host: Make TLL mode work again Date: Thu, 18 Aug 2011 16:14:31 +0530 [thread overview] Message-ID: <1313664271-694-1-git-send-email-gadiyar@ti.com> (raw) This code section seems to have been accidentally copy pasted. It causes incorrect bits to be set up in the TLL_CHANNEL_CONF register and prevents the TLL mode from working correctly. Signed-off-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org> Cc: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> --- Against v3.1-rc2; tested against linux-next as of 20110817 as well. This probably needs to go to -stable as well. The original code by me worked fine but this was broken during the code reorganization Keshava did. drivers/mfd/omap-usb-host.c | 1 - 1 file changed, 1 deletion(-) Index: linux-2.6/drivers/mfd/omap-usb-host.c =================================================================== --- linux-2.6.orig/drivers/mfd/omap-usb-host.c +++ linux-2.6/drivers/mfd/omap-usb-host.c @@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); - reg |= (1 << (i + 1)); } else continue; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-08-18 10:44 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-18 10:44 Anand Gadiyar [this message] 2011-08-18 10:44 ` [PATCH] mfd: omap-usb-host: Make TLL mode work again Anand Gadiyar 2011-08-18 11:22 ` Munegowda, Keshava 2011-08-18 11:24 ` Felipe Balbi 2011-08-18 11:44 ` Gadiyar, Anand 2011-08-18 18:26 ` Greg KH 2011-08-19 5:12 ` Gadiyar, Anand 2011-08-22 14:45 ` Samuel Ortiz 2011-08-22 14:45 ` Samuel Ortiz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1313664271-694-1-git-send-email-gadiyar@ti.com \ --to=gadiyar@ti.com \ --cc=keshava_mgowda@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.