* [PATCH 0/3] treewide: rcar-dmac: Add support for R-Car S4-8
@ 2021-12-21 5:27 Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support Yoshihiro Shimoda
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-21 5:27 UTC (permalink / raw)
To: vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc, Yoshihiro Shimoda
This patch series adds support for rcar-dmac of R-Car S4-8.
To use the rcar-dmac, we also need to enable the module clocks
by the following patch:
https://patchwork.kernel.org/project/linux-renesas-soc/patch/20211221052423.597283-1-yoshihiro.shimoda.uh@renesas.com/
Yoshihiro Shimoda (3):
dt-bindings: renesas,rcar-dmac: Add r8a779f0 support
dmaengine: rcar-dmac: Add support for R-Car S4-8
arm64: dts: renesas: r8a779f0: Add sys-dmac nodes
.../bindings/dma/renesas,rcar-dmac.yaml | 5 ++
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 70 +++++++++++++++++++
drivers/dma/sh/rcar-dmac.c | 7 +-
3 files changed, 80 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support
2021-12-21 5:27 [PATCH 0/3] treewide: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
@ 2021-12-21 5:27 ` Yoshihiro Shimoda
2021-12-22 9:12 ` Geert Uytterhoeven
2021-12-21 5:27 ` [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes Yoshihiro Shimoda
2 siblings, 1 reply; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-21 5:27 UTC (permalink / raw)
To: vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc, Yoshihiro Shimoda
Document the compatible value for the Direct Memory Access Controller
blocks in the Renesas R-Car S4-8 (R8A779F0) SoC.
The most visible difference with DMAC blocks on other R-Car SoCs
(except R8A779F0) is the move of the per-channel registers to
a separate register block.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
index d8142cbd13d3..7c6badf39921 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
@@ -44,6 +44,10 @@ properties:
- items:
- const: renesas,dmac-r8a779a0 # R-Car V3U
+ - items:
+ - const: renesas,dmac-r8a779f0 # R-Car S4-8
+ - const: renesas,rcar-gen4-dmac
+
reg: true
interrupts:
@@ -118,6 +122,7 @@ if:
contains:
enum:
- renesas,dmac-r8a779a0
+ - renesas,rcar-gen4-dmac
then:
properties:
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-21 5:27 [PATCH 0/3] treewide: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support Yoshihiro Shimoda
@ 2021-12-21 5:27 ` Yoshihiro Shimoda
2021-12-21 9:46 ` Ulrich Hecht
2021-12-22 9:16 ` Geert Uytterhoeven
2021-12-21 5:27 ` [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes Yoshihiro Shimoda
2 siblings, 2 replies; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-21 5:27 UTC (permalink / raw)
To: vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc, Yoshihiro Shimoda
Add support for R-Car S4-8. We can reuse R-Car V3U code so that
renames variable names as "gen4".
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/dma/sh/rcar-dmac.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index 5c7716fd6bc5..e409c89edca1 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -2009,7 +2009,7 @@ static const struct rcar_dmac_of_data rcar_dmac_data = {
.chan_offset_stride = 0x80,
};
-static const struct rcar_dmac_of_data rcar_v3u_dmac_data = {
+static const struct rcar_dmac_of_data rcar_gen4_dmac_data = {
.chan_offset_base = 0x0,
.chan_offset_stride = 0x1000,
};
@@ -2018,9 +2018,12 @@ static const struct of_device_id rcar_dmac_of_ids[] = {
{
.compatible = "renesas,rcar-dmac",
.data = &rcar_dmac_data,
+ }, {
+ .compatible = "renesas,rcar-gen4-dmac",
+ .data = &rcar_gen4_dmac_data,
}, {
.compatible = "renesas,dmac-r8a779a0",
- .data = &rcar_v3u_dmac_data,
+ .data = &rcar_gen4_dmac_data,
},
{ /* Sentinel */ }
};
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes
2021-12-21 5:27 [PATCH 0/3] treewide: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
@ 2021-12-21 5:27 ` Yoshihiro Shimoda
2021-12-21 9:56 ` Ulrich Hecht
2021-12-22 9:17 ` Geert Uytterhoeven
2 siblings, 2 replies; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-21 5:27 UTC (permalink / raw)
To: vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc, Yoshihiro Shimoda
Add SYS-DMAC nodes for r8a779f0.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 70 +++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index eda597766eaf..5426532d10e2 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -94,6 +94,76 @@ scif3: serial@e6c50000 {
status = "disabled";
};
+ dmac0: dma-controller@e7350000 {
+ compatible = "renesas,dmac-r8a779f0",
+ "renesas,rcar-gen4-dmac";
+ reg = <0 0xe7350000 0 0x1000>,
+ <0 0xe7300000 0 0x10000>;
+ interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3", "ch4",
+ "ch5", "ch6", "ch7", "ch8", "ch9",
+ "ch10", "ch11", "ch12", "ch13",
+ "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 709>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ resets = <&cpg 709>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
+ dmac1: dma-controller@e7351000 {
+ compatible = "renesas,dmac-r8a779f0",
+ "renesas,rcar-gen4-dmac";
+ reg = <0 0xe7351000 0 0x1000>,
+ <0 0xe7310000 0 0x10000>;
+ interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3", "ch4",
+ "ch5", "ch6", "ch7", "ch8", "ch9",
+ "ch10", "ch11", "ch12", "ch13",
+ "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 710>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ resets = <&cpg 710>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
gic: interrupt-controller@f1000000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-21 5:27 ` [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
@ 2021-12-21 9:46 ` Ulrich Hecht
2021-12-22 9:16 ` Geert Uytterhoeven
1 sibling, 0 replies; 13+ messages in thread
From: Ulrich Hecht @ 2021-12-21 9:46 UTC (permalink / raw)
To: Yoshihiro Shimoda, vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc
> On 12/21/2021 6:27 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
>
>
> Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> renames variable names as "gen4".
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/dma/sh/rcar-dmac.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 5c7716fd6bc5..e409c89edca1 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -2009,7 +2009,7 @@ static const struct rcar_dmac_of_data rcar_dmac_data = {
> .chan_offset_stride = 0x80,
> };
>
> -static const struct rcar_dmac_of_data rcar_v3u_dmac_data = {
> +static const struct rcar_dmac_of_data rcar_gen4_dmac_data = {
> .chan_offset_base = 0x0,
> .chan_offset_stride = 0x1000,
> };
> @@ -2018,9 +2018,12 @@ static const struct of_device_id rcar_dmac_of_ids[] = {
> {
> .compatible = "renesas,rcar-dmac",
> .data = &rcar_dmac_data,
> + }, {
> + .compatible = "renesas,rcar-gen4-dmac",
> + .data = &rcar_gen4_dmac_data,
> }, {
> .compatible = "renesas,dmac-r8a779a0",
> - .data = &rcar_v3u_dmac_data,
> + .data = &rcar_gen4_dmac_data,
> },
> { /* Sentinel */ }
> };
> --
> 2.25.1
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes
2021-12-21 5:27 ` [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes Yoshihiro Shimoda
@ 2021-12-21 9:56 ` Ulrich Hecht
2021-12-22 9:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 13+ messages in thread
From: Ulrich Hecht @ 2021-12-21 9:56 UTC (permalink / raw)
To: Yoshihiro Shimoda, vkoul, robh+dt
Cc: dmaengine, devicetree, linux-renesas-soc
> On 12/21/2021 6:27 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
>
>
> Add SYS-DMAC nodes for r8a779f0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 70 +++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> index eda597766eaf..5426532d10e2 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> @@ -94,6 +94,76 @@ scif3: serial@e6c50000 {
> status = "disabled";
> };
>
> + dmac0: dma-controller@e7350000 {
> + compatible = "renesas,dmac-r8a779f0",
> + "renesas,rcar-gen4-dmac";
> + reg = <0 0xe7350000 0 0x1000>,
> + <0 0xe7300000 0 0x10000>;
> + interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "error",
> + "ch0", "ch1", "ch2", "ch3", "ch4",
> + "ch5", "ch6", "ch7", "ch8", "ch9",
> + "ch10", "ch11", "ch12", "ch13",
> + "ch14", "ch15";
> + clocks = <&cpg CPG_MOD 709>;
> + clock-names = "fck";
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + resets = <&cpg 709>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + };
> +
> + dmac1: dma-controller@e7351000 {
> + compatible = "renesas,dmac-r8a779f0",
> + "renesas,rcar-gen4-dmac";
> + reg = <0 0xe7351000 0 0x1000>,
> + <0 0xe7310000 0 0x10000>;
> + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "error",
> + "ch0", "ch1", "ch2", "ch3", "ch4",
> + "ch5", "ch6", "ch7", "ch8", "ch9",
> + "ch10", "ch11", "ch12", "ch13",
> + "ch14", "ch15";
> + clocks = <&cpg CPG_MOD 710>;
> + clock-names = "fck";
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + resets = <&cpg 710>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + };
> +
> gic: interrupt-controller@f1000000 {
> compatible = "arm,gic-v3";
> #interrupt-cells = <3>;
> --
> 2.25.1
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support
2021-12-21 5:27 ` [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support Yoshihiro Shimoda
@ 2021-12-22 9:12 ` Geert Uytterhoeven
2021-12-22 10:08 ` Yoshihiro Shimoda
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-12-22 9:12 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Shimoda-san,
Thanks for your patch!
On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Document the compatible value for the Direct Memory Access Controller
> blocks in the Renesas R-Car S4-8 (R8A779F0) SoC.
>
> The most visible difference with DMAC blocks on other R-Car SoCs
> (except R8A779F0) is the move of the per-channel registers to
R8A779A0.
> a separate register block.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-21 5:27 ` [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 9:46 ` Ulrich Hecht
@ 2021-12-22 9:16 ` Geert Uytterhoeven
2021-12-22 10:08 ` Yoshihiro Shimoda
1 sibling, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-12-22 9:16 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Shimoda-san,
On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> renames variable names as "gen4".
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks for your patch!
Perhaps you want to rename RCAR_V3U_DMACHCLR, too?
As some registers do not exist (or are not documented) on R-Car S4-8,
perhaps you want to document that in the comments for the register
definitions, too? Fortunately none of them are used by the driver.
As this patch is correct:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes
2021-12-21 5:27 ` [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes Yoshihiro Shimoda
2021-12-21 9:56 ` Ulrich Hecht
@ 2021-12-22 9:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-12-22 9:17 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add SYS-DMAC nodes for r8a779f0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.18.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support
2021-12-22 9:12 ` Geert Uytterhoeven
@ 2021-12-22 10:08 ` Yoshihiro Shimoda
0 siblings, 0 replies; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-22 10:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:13 PM
>
> Hi Shimoda-san,
>
> Thanks for your patch!
>
> On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
> > Document the compatible value for the Direct Memory Access Controller
> > blocks in the Renesas R-Car S4-8 (R8A779F0) SoC.
> >
> > The most visible difference with DMAC blocks on other R-Car SoCs
> > (except R8A779F0) is the move of the per-channel registers to
>
> R8A779A0.
Oops. I'll fix it on v2.
> > a separate register block.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-22 9:16 ` Geert Uytterhoeven
@ 2021-12-22 10:08 ` Yoshihiro Shimoda
2021-12-22 10:10 ` Geert Uytterhoeven
0 siblings, 1 reply; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-22 10:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM
>
> Hi Shimoda-san,
>
> On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
> > Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> > renames variable names as "gen4".
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks for your patch!
>
> Perhaps you want to rename RCAR_V3U_DMACHCLR, too?
Yes, I should have to rename it, too. I'll fix it on v2.
> As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments
> for the register definitions, too? Fortunately none of them are used by the driver.
You're correct. So, I'll modify the following code:
-#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */
+#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */
(sorry these tabs are replaced as spaces)
Also, I'll add such information in the commit description
like below.
-----
Add support for R-Car S4-8. We can reuse R-Car V3U code so that
renames variable names as "gen4".
Note that some registers of R-Car V3U do not exist on R-Car S4-8,
but none of them are used by the driver for now.
-----
Are they acceptable?
> As this patch is correct:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-22 10:08 ` Yoshihiro Shimoda
@ 2021-12-22 10:10 ` Geert Uytterhoeven
2021-12-22 10:47 ` Yoshihiro Shimoda
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-12-22 10:10 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Shimoda-san,
On Wed, Dec 22, 2021 at 11:08 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM
> > As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments
> > for the register definitions, too? Fortunately none of them are used by the driver.
>
> You're correct. So, I'll modify the following code:
>
> -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */
> +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */
> (sorry these tabs are replaced as spaces)
>
> Also, I'll add such information in the commit description
> like below.
> -----
> Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> renames variable names as "gen4".
>
> Note that some registers of R-Car V3U do not exist on R-Car S4-8,
> but none of them are used by the driver for now.
> -----
>
> Are they acceptable?
Perfect! Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8
2021-12-22 10:10 ` Geert Uytterhoeven
@ 2021-12-22 10:47 ` Yoshihiro Shimoda
0 siblings, 0 replies; 13+ messages in thread
From: Yoshihiro Shimoda @ 2021-12-22 10:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod, Rob Herring, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 7:10 PM
<snip>
> > You're correct. So, I'll modify the following code:
> >
> > -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */
> > +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */
> > (sorry these tabs are replaced as spaces)
> >
> > Also, I'll add such information in the commit description like below.
> > -----
> > Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> > renames variable names as "gen4".
> >
> > Note that some registers of R-Car V3U do not exist on R-Car S4-8, but
> > none of them are used by the driver for now.
> > -----
> >
> > Are they acceptable?
>
> Perfect! Thanks!
Thank you for your reply! I'll fix it on v2.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-12-22 10:47 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 5:27 [PATCH 0/3] treewide: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 1/3] dt-bindings: renesas,rcar-dmac: Add r8a779f0 support Yoshihiro Shimoda
2021-12-22 9:12 ` Geert Uytterhoeven
2021-12-22 10:08 ` Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-12-21 9:46 ` Ulrich Hecht
2021-12-22 9:16 ` Geert Uytterhoeven
2021-12-22 10:08 ` Yoshihiro Shimoda
2021-12-22 10:10 ` Geert Uytterhoeven
2021-12-22 10:47 ` Yoshihiro Shimoda
2021-12-21 5:27 ` [PATCH 3/3] arm64: dts: renesas: r8a779f0: Add sys-dmac nodes Yoshihiro Shimoda
2021-12-21 9:56 ` Ulrich Hecht
2021-12-22 9:17 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.