All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Do not use C++-style comments
@ 2011-08-22 10:33 Michael Haggerty
  2011-08-22 11:55 ` Johan Herland
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Haggerty @ 2011-08-22 10:33 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johan Herland, Michael Haggerty

Detected by "gcc -std=iso9899:1990 ...".  This patch applies against
"maint".

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 notes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notes.c b/notes.c
index f6ce848..93e9868 100644
--- a/notes.c
+++ b/notes.c
@@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const unsigned char *object_sha1)
 	hashcpy(l.key_sha1, object_sha1);
 	hashclr(l.val_sha1);
 	note_tree_remove(t, t->root, 0, &l);
-	if (is_null_sha1(l.val_sha1)) // no note was removed
+	if (is_null_sha1(l.val_sha1)) /* no note was removed */
 		return 1;
 	t->dirty = 1;
 	return 0;
-- 
1.7.6.8.gd2879

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Do not use C++-style comments
  2011-08-22 10:33 [PATCH] Do not use C++-style comments Michael Haggerty
@ 2011-08-22 11:55 ` Johan Herland
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Herland @ 2011-08-22 11:55 UTC (permalink / raw)
  To: Michael Haggerty; +Cc: git, Junio C Hamano

On Monday 22. August 2011, Michael Haggerty wrote:
> Detected by "gcc -std=iso9899:1990 ...".  This patch applies against
> "maint".
> 
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  notes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/notes.c b/notes.c
> index f6ce848..93e9868 100644
> --- a/notes.c
> +++ b/notes.c
> @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const
> unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1);
>  	hashclr(l.val_sha1);
>  	note_tree_remove(t, t->root, 0, &l);
> -	if (is_null_sha1(l.val_sha1)) // no note was removed
> +	if (is_null_sha1(l.val_sha1)) /* no note was removed */

ACK!


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-22 11:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-22 10:33 [PATCH] Do not use C++-style comments Michael Haggerty
2011-08-22 11:55 ` Johan Herland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.