All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c
@ 2011-08-22 11:53 Jason Liu
  2011-08-22 11:53 ` [PATCH 1/2] ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c Jason Liu
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Jason Liu @ 2011-08-22 11:53 UTC (permalink / raw)
  To: linux-arm-kernel

The two patches work for consolidate and clean up the arch/arm/mach-mx5/mm-*.c

Jason Liu (2):
  ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c
  ARM: i.MX5/mm: use static mapping for TZIC

 arch/arm/mach-mx5/Makefile            |    1 -
 arch/arm/mach-mx5/mm-mx50.c           |   72 ---------------------------------
 arch/arm/mach-mx5/mm.c                |   61 +++++++++++++++++++++-------
 arch/arm/plat-mxc/include/mach/mx51.h |    1 +
 arch/arm/plat-mxc/include/mach/mx53.h |    1 +
 5 files changed, 48 insertions(+), 88 deletions(-)
 delete mode 100644 arch/arm/mach-mx5/mm-mx50.c

-- 
1.7.4.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c
  2011-08-22 11:53 [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
@ 2011-08-22 11:53 ` Jason Liu
  2011-08-22 11:53 ` [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC Jason Liu
  2011-08-29  7:33 ` [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
  2 siblings, 0 replies; 7+ messages in thread
From: Jason Liu @ 2011-08-22 11:53 UTC (permalink / raw)
  To: linux-arm-kernel

We don't need one seperate file to deal with i.mx50
related stuff, which is very similar with i.mx51/53.
We can put it together into one file.So, just merge
function from mm-mx50.c to mm.c and remove mm-mx50.c

No function change by this commit.

Signed-off-by: Jason Liu <jason.hui@linaro.org>
---
 arch/arm/mach-mx5/Makefile  |    1 -
 arch/arm/mach-mx5/mm-mx50.c |   72 -------------------------------------------
 arch/arm/mach-mx5/mm.c      |   43 +++++++++++++++++++++++++
 3 files changed, 43 insertions(+), 73 deletions(-)

diff --git a/arch/arm/mach-mx5/Makefile b/arch/arm/mach-mx5/Makefile
index 7f45243..9565304 100644
--- a/arch/arm/mach-mx5/Makefile
+++ b/arch/arm/mach-mx5/Makefile
@@ -4,7 +4,6 @@
 
 # Object file lists.
 obj-y   := cpu.o mm.o clock-mx51-mx53.o ehci.o system.o
-obj-$(CONFIG_SOC_IMX50) += mm-mx50.o
 
 obj-$(CONFIG_PM) += pm-imx5.o
 obj-$(CONFIG_CPU_FREQ_IMX)    += cpu_op-mx51.o
diff --git a/arch/arm/mach-mx5/mm-mx50.c b/arch/arm/mach-mx5/mm-mx50.c
deleted file mode 100644
index 77e374c..0000000
--- a/arch/arm/mach-mx5/mm-mx50.c
+++ /dev/null
@@ -1,72 +0,0 @@
-/*
- * Copyright (C) 2010 Freescale Semiconductor, Inc. All Rights Reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
-
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
-
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Create static mapping between physical to virtual memory.
- */
-
-#include <linux/mm.h>
-#include <linux/init.h>
-
-#include <asm/mach/map.h>
-
-#include <mach/hardware.h>
-#include <mach/common.h>
-#include <mach/iomux-v3.h>
-#include <mach/irqs.h>
-
-/*
- * Define the MX50 memory map.
- */
-static struct map_desc mx50_io_desc[] __initdata = {
-	imx_map_entry(MX50, TZIC, MT_DEVICE),
-	imx_map_entry(MX50, SPBA0, MT_DEVICE),
-	imx_map_entry(MX50, AIPS1, MT_DEVICE),
-	imx_map_entry(MX50, AIPS2, MT_DEVICE),
-};
-
-/*
- * This function initializes the memory map. It is called during the
- * system startup to create static physical to virtual memory mappings
- * for the IO modules.
- */
-void __init mx50_map_io(void)
-{
-	iotable_init(mx50_io_desc, ARRAY_SIZE(mx50_io_desc));
-}
-
-void __init imx50_init_early(void)
-{
-	mxc_set_cpu_type(MXC_CPU_MX50);
-	mxc_iomux_v3_init(MX50_IO_ADDRESS(MX50_IOMUXC_BASE_ADDR));
-	mxc_arch_reset_init(MX50_IO_ADDRESS(MX50_WDOG_BASE_ADDR));
-}
-
-void __init mx50_init_irq(void)
-{
-	tzic_init_irq(MX50_IO_ADDRESS(MX50_TZIC_BASE_ADDR));
-}
-
-void __init imx50_soc_init(void)
-{
-	/* i.mx50 has the i.mx31 type gpio */
-	mxc_register_gpio("imx31-gpio", 0, MX50_GPIO1_BASE_ADDR, SZ_16K, MX50_INT_GPIO1_LOW, MX50_INT_GPIO1_HIGH);
-	mxc_register_gpio("imx31-gpio", 1, MX50_GPIO2_BASE_ADDR, SZ_16K, MX50_INT_GPIO2_LOW, MX50_INT_GPIO2_HIGH);
-	mxc_register_gpio("imx31-gpio", 2, MX50_GPIO3_BASE_ADDR, SZ_16K, MX50_INT_GPIO3_LOW, MX50_INT_GPIO3_HIGH);
-	mxc_register_gpio("imx31-gpio", 3, MX50_GPIO4_BASE_ADDR, SZ_16K, MX50_INT_GPIO4_LOW, MX50_INT_GPIO4_HIGH);
-	mxc_register_gpio("imx31-gpio", 4, MX50_GPIO5_BASE_ADDR, SZ_16K, MX50_INT_GPIO5_LOW, MX50_INT_GPIO5_HIGH);
-	mxc_register_gpio("imx31-gpio", 5, MX50_GPIO6_BASE_ADDR, SZ_16K, MX50_INT_GPIO6_LOW, MX50_INT_GPIO6_HIGH);
-}
diff --git a/arch/arm/mach-mx5/mm.c b/arch/arm/mach-mx5/mm.c
index fcc5c4c..f8ebe37 100644
--- a/arch/arm/mach-mx5/mm.c
+++ b/arch/arm/mach-mx5/mm.c
@@ -42,6 +42,16 @@ static struct map_desc mx53_io_desc[] __initdata = {
 };
 
 /*
+ * Define the MX50 memory map.
+ */
+static struct map_desc mx50_io_desc[] __initdata = {
+	imx_map_entry(MX50, TZIC, MT_DEVICE),
+	imx_map_entry(MX50, SPBA0, MT_DEVICE),
+	imx_map_entry(MX50, AIPS1, MT_DEVICE),
+	imx_map_entry(MX50, AIPS2, MT_DEVICE),
+};
+
+/*
  * This function initializes the memory map. It is called during the
  * system startup to create static physical to virtual memory mappings
  * for the IO modules.
@@ -70,6 +80,23 @@ void __init imx53_init_early(void)
 	mxc_arch_reset_init(MX53_IO_ADDRESS(MX53_WDOG1_BASE_ADDR));
 }
 
+/*
+ * This function initializes the memory map. It is called during the
+ * system startup to create static physical to virtual memory mappings
+ * for the IO modules.
+ */
+void __init mx50_map_io(void)
+{
+	iotable_init(mx50_io_desc, ARRAY_SIZE(mx50_io_desc));
+}
+
+void __init imx50_init_early(void)
+{
+	mxc_set_cpu_type(MXC_CPU_MX50);
+	mxc_iomux_v3_init(MX50_IO_ADDRESS(MX50_IOMUXC_BASE_ADDR));
+	mxc_arch_reset_init(MX50_IO_ADDRESS(MX50_WDOG_BASE_ADDR));
+}
+
 void __init mx51_init_irq(void)
 {
 	unsigned long tzic_addr;
@@ -101,6 +128,11 @@ void __init mx53_init_irq(void)
 	tzic_init_irq(tzic_virt);
 }
 
+void __init mx50_init_irq(void)
+{
+	tzic_init_irq(MX50_IO_ADDRESS(MX50_TZIC_BASE_ADDR));
+}
+
 static struct sdma_script_start_addrs imx51_sdma_script __initdata = {
 	.ap_2_ap_addr = 642,
 	.uart_2_mcu_addr = 817,
@@ -164,3 +196,14 @@ void __init imx53_soc_init(void)
 	/* i.mx53 has the i.mx35 type sdma */
 	imx_add_imx_sdma("imx35-sdma", MX53_SDMA_BASE_ADDR, MX53_INT_SDMA, &imx53_sdma_pdata);
 }
+
+void __init imx50_soc_init(void)
+{
+	/* i.mx50 has the i.mx31 type gpio */
+	mxc_register_gpio("imx31-gpio", 0, MX50_GPIO1_BASE_ADDR, SZ_16K, MX50_INT_GPIO1_LOW, MX50_INT_GPIO1_HIGH);
+	mxc_register_gpio("imx31-gpio", 1, MX50_GPIO2_BASE_ADDR, SZ_16K, MX50_INT_GPIO2_LOW, MX50_INT_GPIO2_HIGH);
+	mxc_register_gpio("imx31-gpio", 2, MX50_GPIO3_BASE_ADDR, SZ_16K, MX50_INT_GPIO3_LOW, MX50_INT_GPIO3_HIGH);
+	mxc_register_gpio("imx31-gpio", 3, MX50_GPIO4_BASE_ADDR, SZ_16K, MX50_INT_GPIO4_LOW, MX50_INT_GPIO4_HIGH);
+	mxc_register_gpio("imx31-gpio", 4, MX50_GPIO5_BASE_ADDR, SZ_16K, MX50_INT_GPIO5_LOW, MX50_INT_GPIO5_HIGH);
+	mxc_register_gpio("imx31-gpio", 5, MX50_GPIO6_BASE_ADDR, SZ_16K, MX50_INT_GPIO6_LOW, MX50_INT_GPIO6_HIGH);
+}
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC
  2011-08-22 11:53 [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
  2011-08-22 11:53 ` [PATCH 1/2] ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c Jason Liu
@ 2011-08-22 11:53 ` Jason Liu
  2011-08-23  7:05   ` Uwe Kleine-König
  2011-08-29  7:33 ` [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
  2 siblings, 1 reply; 7+ messages in thread
From: Jason Liu @ 2011-08-22 11:53 UTC (permalink / raw)
  To: linux-arm-kernel

We can use static mapping for TZIC to get rid of the
duplicated code for ioremap and the error handling of
ioremap, which will made code more clean and consistent.

Signed-off-by: Jason Liu <jason.hui@linaro.org>
---
 arch/arm/mach-mx5/mm.c                |   20 ++++----------------
 arch/arm/plat-mxc/include/mach/mx51.h |    1 +
 arch/arm/plat-mxc/include/mach/mx53.h |    1 +
 3 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/arch/arm/mach-mx5/mm.c b/arch/arm/mach-mx5/mm.c
index f8ebe37..adfe889 100644
--- a/arch/arm/mach-mx5/mm.c
+++ b/arch/arm/mach-mx5/mm.c
@@ -25,6 +25,7 @@
  * Define the MX51 memory map.
  */
 static struct map_desc mx51_io_desc[] __initdata = {
+	imx_map_entry(MX51, TZIC, MT_DEVICE),
 	imx_map_entry(MX51, IRAM, MT_DEVICE),
 	imx_map_entry(MX51, DEBUG, MT_DEVICE),
 	imx_map_entry(MX51, AIPS1, MT_DEVICE),
@@ -36,6 +37,7 @@ static struct map_desc mx51_io_desc[] __initdata = {
  * Define the MX53 memory map.
  */
 static struct map_desc mx53_io_desc[] __initdata = {
+	imx_map_entry(MX53, TZIC, MT_DEVICE),
 	imx_map_entry(MX53, AIPS1, MT_DEVICE),
 	imx_map_entry(MX53, SPBA0, MT_DEVICE),
 	imx_map_entry(MX53, AIPS2, MT_DEVICE),
@@ -100,32 +102,18 @@ void __init imx50_init_early(void)
 void __init mx51_init_irq(void)
 {
 	unsigned long tzic_addr;
-	void __iomem *tzic_virt;
 
 	if (mx51_revision() < IMX_CHIP_REVISION_2_0)
 		tzic_addr = MX51_TZIC_BASE_ADDR_TO1;
 	else
 		tzic_addr = MX51_TZIC_BASE_ADDR;
 
-	tzic_virt = ioremap(tzic_addr, SZ_16K);
-	if (!tzic_virt)
-		panic("unable to map TZIC interrupt controller\n");
-
-	tzic_init_irq(tzic_virt);
+	tzic_init_irq(MX51_IO_ADDRESS(tzic_addr));
 }
 
 void __init mx53_init_irq(void)
 {
-	unsigned long tzic_addr;
-	void __iomem *tzic_virt;
-
-	tzic_addr = MX53_TZIC_BASE_ADDR;
-
-	tzic_virt = ioremap(tzic_addr, SZ_16K);
-	if (!tzic_virt)
-		panic("unable to map TZIC interrupt controller\n");
-
-	tzic_init_irq(tzic_virt);
+	tzic_init_irq(MX53_IO_ADDRESS(MX53_TZIC_BASE_ADDR));
 }
 
 void __init mx50_init_irq(void)
diff --git a/arch/arm/plat-mxc/include/mach/mx51.h b/arch/arm/plat-mxc/include/mach/mx51.h
index 9666e31..1e74210 100644
--- a/arch/arm/plat-mxc/include/mach/mx51.h
+++ b/arch/arm/plat-mxc/include/mach/mx51.h
@@ -135,6 +135,7 @@
 
 #define MX51_GPU2D_BASE_ADDR		0xd0000000
 #define MX51_TZIC_BASE_ADDR		0xe0000000
+#define MX51_TZIC_SIZE                  SZ_16K
 
 #define MX51_IO_P2V(x)			IMX_IO_P2V(x)
 #define MX51_IO_ADDRESS(x)		IOMEM(MX51_IO_P2V(x))
diff --git a/arch/arm/plat-mxc/include/mach/mx53.h b/arch/arm/plat-mxc/include/mach/mx53.h
index 5e3c323..fbf2610 100644
--- a/arch/arm/plat-mxc/include/mach/mx53.h
+++ b/arch/arm/plat-mxc/include/mach/mx53.h
@@ -9,6 +9,7 @@
 
 /* TZIC */
 #define MX53_TZIC_BASE_ADDR		0x0FFFC000
+#define MX53_TZIC_SIZE                  SZ_16K
 
 /*
  * AHCI SATA
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC
  2011-08-22 11:53 ` [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC Jason Liu
@ 2011-08-23  7:05   ` Uwe Kleine-König
  2011-08-23  8:27     ` Jason Hui
  0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2011-08-23  7:05 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Jason,

On Mon, Aug 22, 2011 at 07:53:25PM +0800, Jason Liu wrote:
> We can use static mapping for TZIC to get rid of the
> duplicated code for ioremap and the error handling of
> ioremap, which will made code more clean and consistent.
> 
> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> ---
>  arch/arm/mach-mx5/mm.c                |   20 ++++----------------
>  arch/arm/plat-mxc/include/mach/mx51.h |    1 +
>  arch/arm/plat-mxc/include/mach/mx53.h |    1 +
>  3 files changed, 6 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/mm.c b/arch/arm/mach-mx5/mm.c
> index f8ebe37..adfe889 100644
> --- a/arch/arm/mach-mx5/mm.c
> +++ b/arch/arm/mach-mx5/mm.c
> @@ -25,6 +25,7 @@
>   * Define the MX51 memory map.
>   */
>  static struct map_desc mx51_io_desc[] __initdata = {
> +	imx_map_entry(MX51, TZIC, MT_DEVICE),
>  	imx_map_entry(MX51, IRAM, MT_DEVICE),
>  	imx_map_entry(MX51, DEBUG, MT_DEVICE),
>  	imx_map_entry(MX51, AIPS1, MT_DEVICE),
> @@ -36,6 +37,7 @@ static struct map_desc mx51_io_desc[] __initdata = {
>   * Define the MX53 memory map.
>   */
>  static struct map_desc mx53_io_desc[] __initdata = {
> +	imx_map_entry(MX53, TZIC, MT_DEVICE),
>  	imx_map_entry(MX53, AIPS1, MT_DEVICE),
>  	imx_map_entry(MX53, SPBA0, MT_DEVICE),
>  	imx_map_entry(MX53, AIPS2, MT_DEVICE),
> @@ -100,32 +102,18 @@ void __init imx50_init_early(void)
>  void __init mx51_init_irq(void)
>  {
>  	unsigned long tzic_addr;
> -	void __iomem *tzic_virt;
>  
>  	if (mx51_revision() < IMX_CHIP_REVISION_2_0)
>  		tzic_addr = MX51_TZIC_BASE_ADDR_TO1;
>  	else
>  		tzic_addr = MX51_TZIC_BASE_ADDR;
>  
> -	tzic_virt = ioremap(tzic_addr, SZ_16K);
> -	if (!tzic_virt)
> -		panic("unable to map TZIC interrupt controller\n");
> -
> -	tzic_init_irq(tzic_virt);
> +	tzic_init_irq(MX51_IO_ADDRESS(tzic_addr));
arch/arm/plat-mxc/include/mach/hardware.h has a list of all SoCs with
the memory areas mapped that you are expected to update if you add
another mapping. If you had done that, you would have noticed that
MX51_TZIC_BASE_ADDR (== 0xe0000000) maps to the very same address as
MX51_DEBUG_BASE_ADDR (== 0x60000000).
So only one of these two can be statically mapped (or the function needs
to change).

Having said that it would be nice to use a static mapping for TZIC. Do
we really need MX51_DEBUG mapped?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC
  2011-08-23  7:05   ` Uwe Kleine-König
@ 2011-08-23  8:27     ` Jason Hui
  0 siblings, 0 replies; 7+ messages in thread
From: Jason Hui @ 2011-08-23  8:27 UTC (permalink / raw)
  To: linux-arm-kernel

Hi, Uwe,

2011/8/23 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Hello Jason,
>
> On Mon, Aug 22, 2011 at 07:53:25PM +0800, Jason Liu wrote:
>> We can use static mapping for TZIC to get rid of the
>> duplicated code for ioremap and the error handling of
>> ioremap, which will made code more clean and consistent.
>>
>> Signed-off-by: Jason Liu <jason.hui@linaro.org>
>> ---
>> ?arch/arm/mach-mx5/mm.c ? ? ? ? ? ? ? ?| ? 20 ++++----------------
>> ?arch/arm/plat-mxc/include/mach/mx51.h | ? ?1 +
>> ?arch/arm/plat-mxc/include/mach/mx53.h | ? ?1 +
>> ?3 files changed, 6 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx5/mm.c b/arch/arm/mach-mx5/mm.c
>> index f8ebe37..adfe889 100644
>> --- a/arch/arm/mach-mx5/mm.c
>> +++ b/arch/arm/mach-mx5/mm.c
>> @@ -25,6 +25,7 @@
>> ? * Define the MX51 memory map.
>> ? */
>> ?static struct map_desc mx51_io_desc[] __initdata = {
>> + ? ? imx_map_entry(MX51, TZIC, MT_DEVICE),
>> ? ? ? imx_map_entry(MX51, IRAM, MT_DEVICE),
>> ? ? ? imx_map_entry(MX51, DEBUG, MT_DEVICE),
>> ? ? ? imx_map_entry(MX51, AIPS1, MT_DEVICE),
>> @@ -36,6 +37,7 @@ static struct map_desc mx51_io_desc[] __initdata = {
>> ? * Define the MX53 memory map.
>> ? */
>> ?static struct map_desc mx53_io_desc[] __initdata = {
>> + ? ? imx_map_entry(MX53, TZIC, MT_DEVICE),
>> ? ? ? imx_map_entry(MX53, AIPS1, MT_DEVICE),
>> ? ? ? imx_map_entry(MX53, SPBA0, MT_DEVICE),
>> ? ? ? imx_map_entry(MX53, AIPS2, MT_DEVICE),
>> @@ -100,32 +102,18 @@ void __init imx50_init_early(void)
>> ?void __init mx51_init_irq(void)
>> ?{
>> ? ? ? unsigned long tzic_addr;
>> - ? ? void __iomem *tzic_virt;
>>
>> ? ? ? if (mx51_revision() < IMX_CHIP_REVISION_2_0)
>> ? ? ? ? ? ? ? tzic_addr = MX51_TZIC_BASE_ADDR_TO1;
>> ? ? ? else
>> ? ? ? ? ? ? ? tzic_addr = MX51_TZIC_BASE_ADDR;
>>
>> - ? ? tzic_virt = ioremap(tzic_addr, SZ_16K);
>> - ? ? if (!tzic_virt)
>> - ? ? ? ? ? ? panic("unable to map TZIC interrupt controller\n");
>> -
>> - ? ? tzic_init_irq(tzic_virt);
>> + ? ? tzic_init_irq(MX51_IO_ADDRESS(tzic_addr));
> arch/arm/plat-mxc/include/mach/hardware.h has a list of all SoCs with
> the memory areas mapped that you are expected to update if you add
> another mapping. If you had done that, you would have noticed that
> MX51_TZIC_BASE_ADDR (== 0xe0000000) maps to the very same address as
> MX51_DEBUG_BASE_ADDR (== 0x60000000).
> So only one of these two can be statically mapped (or the function needs
> to change).

Yes, right. But I think we can get rid of DEBUG mapping, this is
useless and no-one
use it. And I also want to clean up the following def, it is dead code.

-#define MX51_DEBUG_BASE_ADDR           0x60000000
-#define MX51_DEBUG_SIZE                        SZ_1M
-
-#define MX51_ETB_BASE_ADDR             (MX51_DEBUG_BASE_ADDR + 0x01000)
-#define MX51_ETM_BASE_ADDR             (MX51_DEBUG_BASE_ADDR + 0x02000)
-#define MX51_TPIU_BASE_ADDR            (MX51_DEBUG_BASE_ADDR + 0x03000)
-#define MX51_CTI0_BASE_ADDR            (MX51_DEBUG_BASE_ADDR + 0x04000)
-#define MX51_CTI1_BASE_ADDR            (MX51_DEBUG_BASE_ADDR + 0x05000)
-#define MX51_CTI2_BASE_ADDR            (MX51_DEBUG_BASE_ADDR + 0x06000)
-#define MX51_CTI3_BASE_ADDR            (MX51_DEBUG_BASE_ADDR + 0x07000)
-#define MX51_CORTEX_DBG_BASE_ADDR      (MX51_DEBUG_BASE_ADDR + 0x08000)

>
> Having said that it would be nice to use a static mapping for TZIC. Do
> we really need MX51_DEBUG mapped?

IMHO, I think we don't need MX51_DEBUG  mapping.

I will give one v2 patch to include the above comments if you allow.

Thanks for your review.

Jason

>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | Uwe Kleine-K?nig ? ? ? ? ? ?|
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c
  2011-08-22 11:53 [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
  2011-08-22 11:53 ` [PATCH 1/2] ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c Jason Liu
  2011-08-22 11:53 ` [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC Jason Liu
@ 2011-08-29  7:33 ` Jason Liu
  2011-08-29  7:41   ` Robert Schwebel
  2 siblings, 1 reply; 7+ messages in thread
From: Jason Liu @ 2011-08-29  7:33 UTC (permalink / raw)
  To: linux-arm-kernel

Hi, Sascha,

2011/8/22 Jason Liu <jason.hui@linaro.org>:
> The two patches work for consolidate and clean up the arch/arm/mach-mx5/mm-*.c
>
> Jason Liu (2):
> ?ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c
> ?ARM: i.MX5/mm: use static mapping for TZIC
>
> ?arch/arm/mach-mx5/Makefile ? ? ? ? ? ?| ? ?1 -
> ?arch/arm/mach-mx5/mm-mx50.c ? ? ? ? ? | ? 72 ---------------------------------
> ?arch/arm/mach-mx5/mm.c ? ? ? ? ? ? ? ?| ? 61 +++++++++++++++++++++-------
> ?arch/arm/plat-mxc/include/mach/mx51.h | ? ?1 +
> ?arch/arm/plat-mxc/include/mach/mx53.h | ? ?1 +
> ?5 files changed, 48 insertions(+), 88 deletions(-)
> ?delete mode 100644 arch/arm/mach-mx5/mm-mx50.c

Any comments for this patch set?
The patch-set has the v2 version for :i.MX5/mm: use static mapping for
TZIC, which addresses
the comments from Uwe, the v2 is referenced here:
http://patchwork.ozlabs.org/patch/111075/



Thanks.

Jason
>
> --
> 1.7.4.1
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c
  2011-08-29  7:33 ` [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
@ 2011-08-29  7:41   ` Robert Schwebel
  0 siblings, 0 replies; 7+ messages in thread
From: Robert Schwebel @ 2011-08-29  7:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Aug 29, 2011 at 03:33:10PM +0800, Jason Liu wrote:
> Any comments for this patch set?

http://article.gmane.org/gmane.linux.ports.arm.kernel/130287

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-08-29  7:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-22 11:53 [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
2011-08-22 11:53 ` [PATCH 1/2] ARM: i.MX5/mm: Consolidate arch/arm/mach-mx5/mm-*.c Jason Liu
2011-08-22 11:53 ` [PATCH 2/2] ARM: i.MX5/mm: use static mapping for TZIC Jason Liu
2011-08-23  7:05   ` Uwe Kleine-König
2011-08-23  8:27     ` Jason Hui
2011-08-29  7:33 ` [PATCH 0/2] Consolidate and clean up the arch/arm/mach-mx5/mm-*.c Jason Liu
2011-08-29  7:41   ` Robert Schwebel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.