[Qemu-devel] [PATCH] qcow2: use always stderr for debugging

[Qemu-devel] [PATCH] qcow2: use always stderr for debugging

[Frediano Ziglio]

let all DEBUG_ALLOC2 printf goes to stderr

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
---
 block/qcow2-cluster.c  |    2 +-
 block/qcow2-refcount.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 9269dda..9034840 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -53,7 +53,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size, bool exact_size)
     }
 
 #ifdef DEBUG_ALLOC2
-    printf("grow l1_table from %d to %d\n", s->l1_size, new_l1_size);
+    fprintf(stderr, "grow l1_table from %d to %d\n", s->l1_size, new_l1_size);
 #endif
 
     new_l1_size2 = sizeof(uint64_t) * new_l1_size;
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 2a915be..fbf28da 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -422,7 +422,7 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
     int ret;
 
 #ifdef DEBUG_ALLOC2
-    printf("update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n",
+    fprintf(stderr, "update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n",
            offset, length, addend);
 #endif
     if (length < 0) {
@@ -556,7 +556,7 @@ retry:
         }
     }
 #ifdef DEBUG_ALLOC2
-    printf("alloc_clusters: size=%" PRId64 " -> %" PRId64 "\n",
+    fprintf(stderr, "alloc_clusters: size=%" PRId64 " -> %" PRId64 "\n",
             size,
             (s->free_cluster_index - nb_clusters) << s->cluster_bits);
 #endif
-- 
1.7.1

Re: [Qemu-devel] [PATCH] qcow2: use always stderr for debugging

[Kevin Wolf]

Am 25.08.2011 09:23, schrieb Frediano Ziglio:
> let all DEBUG_ALLOC2 printf goes to stderr
> 
> Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Thanks, applied to the block branch.

Kevin

Re: [Qemu-devel] [PATCH] qcow2: use always stderr for debugging

[Paolo Bonzini]

On 08/25/2011 09:23 AM, Frediano Ziglio wrote:
> let all DEBUG_ALLOC2 printf goes to stderr
>
> Signed-off-by: Frediano Ziglio<freddy77@gmail.com>
> ---
>   block/qcow2-cluster.c  |    2 +-
>   block/qcow2-refcount.c |    4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 9269dda..9034840 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -53,7 +53,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size, bool exact_size)
>       }
>
>   #ifdef DEBUG_ALLOC2
> -    printf("grow l1_table from %d to %d\n", s->l1_size, new_l1_size);
> +    fprintf(stderr, "grow l1_table from %d to %d\n", s->l1_size, new_l1_size);
>   #endif
>
>       new_l1_size2 = sizeof(uint64_t) * new_l1_size;
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 2a915be..fbf28da 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -422,7 +422,7 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
>       int ret;
>
>   #ifdef DEBUG_ALLOC2
> -    printf("update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n",
> +    fprintf(stderr, "update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n",
>              offset, length, addend);
>   #endif
>       if (length<  0) {
> @@ -556,7 +556,7 @@ retry:
>           }
>       }
>   #ifdef DEBUG_ALLOC2
> -    printf("alloc_clusters: size=%" PRId64 " ->  %" PRId64 "\n",
> +    fprintf(stderr, "alloc_clusters: size=%" PRId64 " ->  %" PRId64 "\n",
>               size,
>               (s->free_cluster_index - nb_clusters)<<  s->cluster_bits);
>   #endif

Adding trace events would be even better, no?

Paolo