* [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
@ 2011-08-29 14:55 Anthony Liguori
2011-08-30 15:33 ` Juan Quintela
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Anthony Liguori @ 2011-08-29 14:55 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Anthony Liguori
This has been discussed before in the past. The special casing really makes no
sense anymore. This seems like a good change to make for 1.0.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
Makefile | 5 ++---
Makefile.target | 4 ----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 8606849..51ecdb5 100644
--- a/Makefile
+++ b/Makefile
@@ -365,9 +365,8 @@ tar:
rm -rf /tmp/$(FILE)
SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
-SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
- $(patsubst %-softmmu,qemu-system-%, \
- $(SYSTEM_TARGETS)))
+SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
+ $(SYSTEM_TARGETS))
USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
diff --git a/Makefile.target b/Makefile.target
index 07af4d4..29287ed 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
QEMU_PROG=qemu-$(TARGET_ARCH2)
else
# system emulator name
-ifeq ($(TARGET_ARCH), i386)
-QEMU_PROG=qemu$(EXESUF)
-else
QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
endif
-endif
PROGS=$(QEMU_PROG)
STPFILES=
--
1.7.4.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-29 14:55 [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 Anthony Liguori
@ 2011-08-30 15:33 ` Juan Quintela
2011-08-30 15:41 ` Peter Maydell
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Juan Quintela @ 2011-08-30 15:33 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel
Anthony Liguori <aliguori@us.ibm.com> wrote:
> This has been discussed before in the past. The special casing really makes no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Acked-by: Juan Quintela <quintela@redhat.com>
/me never liked it in the 1st place
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-29 14:55 [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 Anthony Liguori
2011-08-30 15:33 ` Juan Quintela
@ 2011-08-30 15:41 ` Peter Maydell
2011-08-30 15:59 ` Anthony Liguori
2011-08-30 19:24 ` Blue Swirl
2011-09-02 15:40 ` Anthony Liguori
3 siblings, 1 reply; 12+ messages in thread
From: Peter Maydell @ 2011-08-30 15:41 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel
On 29 August 2011 15:55, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This has been discussed before in the past. The special casing really makes no
> sense anymore. This seems like a good change to make for 1.0.
No issues here. Obviously it would need to be flagged up to users,
which suggests a thought: should we create a ChangeLog/trunk wiki page
to list things we're going to have to release-note for 1.0 so we
don't have to try to remember them all later?
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-30 15:41 ` Peter Maydell
@ 2011-08-30 15:59 ` Anthony Liguori
0 siblings, 0 replies; 12+ messages in thread
From: Anthony Liguori @ 2011-08-30 15:59 UTC (permalink / raw)
To: Peter Maydell; +Cc: Blue Swirl, Anthony Liguori, qemu-devel
On 08/30/2011 10:41 AM, Peter Maydell wrote:
> On 29 August 2011 15:55, Anthony Liguori<aliguori@us.ibm.com> wrote:
>> This has been discussed before in the past. The special casing really makes no
>> sense anymore. This seems like a good change to make for 1.0.
>
> No issues here. Obviously it would need to be flagged up to users,
> which suggests a thought: should we create a ChangeLog/trunk wiki page
> to list things we're going to have to release-note for 1.0 so we
> don't have to try to remember them all later?
Excellent thought.
http://wiki.qemu.org/ChangeLog/Next
Regards,
Anthony Liguori
>
> -- PMM
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-29 14:55 [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 Anthony Liguori
2011-08-30 15:33 ` Juan Quintela
2011-08-30 15:41 ` Peter Maydell
@ 2011-08-30 19:24 ` Blue Swirl
2011-09-02 15:39 ` Anthony Liguori
2011-09-02 15:40 ` Anthony Liguori
3 siblings, 1 reply; 12+ messages in thread
From: Blue Swirl @ 2011-08-30 19:24 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This has been discussed before in the past. The special casing really makes no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> Makefile | 5 ++---
> Makefile.target | 4 ----
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8606849..51ecdb5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -365,9 +365,8 @@ tar:
> rm -rf /tmp/$(FILE)
>
> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
> - $(patsubst %-softmmu,qemu-system-%, \
> - $(SYSTEM_TARGETS)))
> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
> + $(SYSTEM_TARGETS))
Maybe the patsubst could be avoided, just rename the build directory
from *-softmmu to qemu-system-* while at it?
>
> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
Also here the directory and executable names could be made to match.
> diff --git a/Makefile.target b/Makefile.target
> index 07af4d4..29287ed 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
> QEMU_PROG=qemu-$(TARGET_ARCH2)
> else
> # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
> endif
> -endif
>
> PROGS=$(QEMU_PROG)
> STPFILES=
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-30 19:24 ` Blue Swirl
@ 2011-09-02 15:39 ` Anthony Liguori
2011-09-03 11:46 ` Blue Swirl
0 siblings, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2011-09-02 15:39 UTC (permalink / raw)
To: Blue Swirl; +Cc: Peter Maydell, qemu-devel
On 08/30/2011 02:24 PM, Blue Swirl wrote:
> On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori<aliguori@us.ibm.com> wrote:
>> This has been discussed before in the past. The special casing really makes no
>> sense anymore. This seems like a good change to make for 1.0.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>> ---
>> Makefile | 5 ++---
>> Makefile.target | 4 ----
>> 2 files changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 8606849..51ecdb5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -365,9 +365,8 @@ tar:
>> rm -rf /tmp/$(FILE)
>>
>> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
>> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
>> - $(patsubst %-softmmu,qemu-system-%, \
>> - $(SYSTEM_TARGETS)))
>> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
>> + $(SYSTEM_TARGETS))
>
> Maybe the patsubst could be avoided, just rename the build directory
> from *-softmmu to qemu-system-* while at it?
>
>>
>> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
>> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
>
> Also here the directory and executable names could be made to match.
I thought that historically the phrase softmmu was for the variant of
libcpu that had an emulated TLB.
I know Peter's been talking about a linux-user mode that uses softmmu
since certain combinations of architectures today are impossible with
linux-user (ia64 on x86_64 for instance).
So I think the current naming conventions probably are reasonable
although I'm not opposed to changing them. I think that should be a
separate patch though.
Regards,
Anthony Liguori
>
>> diff --git a/Makefile.target b/Makefile.target
>> index 07af4d4..29287ed 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
>> QEMU_PROG=qemu-$(TARGET_ARCH2)
>> else
>> # system emulator name
>> -ifeq ($(TARGET_ARCH), i386)
>> -QEMU_PROG=qemu$(EXESUF)
>> -else
>> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>> endif
>> -endif
>>
>> PROGS=$(QEMU_PROG)
>> STPFILES=
>> --
>> 1.7.4.1
>>
>>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-09-02 15:39 ` Anthony Liguori
@ 2011-09-03 11:46 ` Blue Swirl
0 siblings, 0 replies; 12+ messages in thread
From: Blue Swirl @ 2011-09-03 11:46 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Peter Maydell, qemu-devel
On Fri, Sep 2, 2011 at 3:39 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> On 08/30/2011 02:24 PM, Blue Swirl wrote:
>>
>> On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori<aliguori@us.ibm.com>
>> wrote:
>>>
>>> This has been discussed before in the past. The special casing really
>>> makes no
>>> sense anymore. This seems like a good change to make for 1.0.
>>>
>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>> ---
>>> Makefile | 5 ++---
>>> Makefile.target | 4 ----
>>> 2 files changed, 2 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 8606849..51ecdb5 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -365,9 +365,8 @@ tar:
>>> rm -rf /tmp/$(FILE)
>>>
>>> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
>>> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
>>> - $(patsubst %-softmmu,qemu-system-%, \
>>> - $(SYSTEM_TARGETS)))
>>> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
>>> + $(SYSTEM_TARGETS))
>>
>> Maybe the patsubst could be avoided, just rename the build directory
>> from *-softmmu to qemu-system-* while at it?
>>
>>>
>>> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
>>> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
>>
>> Also here the directory and executable names could be made to match.
>
> I thought that historically the phrase softmmu was for the variant of libcpu
> that had an emulated TLB.
>
> I know Peter's been talking about a linux-user mode that uses softmmu since
> certain combinations of architectures today are impossible with linux-user
> (ia64 on x86_64 for instance).
That could be qemu-linux-softmmu-xxx.
If we had a similar mode for system emulation which used host MMU,
those system emulators could be named qemu-system-hostmmu-xxx.
> So I think the current naming conventions probably are reasonable although
> I'm not opposed to changing them. I think that should be a separate patch
> though.
OK. The names of the build directories do not bring users any major
benefits in any case.
> Regards,
>
> Anthony Liguori
>
>>
>>> diff --git a/Makefile.target b/Makefile.target
>>> index 07af4d4..29287ed 100644
>>> --- a/Makefile.target
>>> +++ b/Makefile.target
>>> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
>>> QEMU_PROG=qemu-$(TARGET_ARCH2)
>>> else
>>> # system emulator name
>>> -ifeq ($(TARGET_ARCH), i386)
>>> -QEMU_PROG=qemu$(EXESUF)
>>> -else
>>> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>>> endif
>>> -endif
>>>
>>> PROGS=$(QEMU_PROG)
>>> STPFILES=
>>> --
>>> 1.7.4.1
>>>
>>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-08-29 14:55 [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 Anthony Liguori
` (2 preceding siblings ...)
2011-08-30 19:24 ` Blue Swirl
@ 2011-09-02 15:40 ` Anthony Liguori
2011-09-03 13:44 ` Andreas Färber
3 siblings, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2011-09-02 15:40 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel
On 08/29/2011 09:55 AM, Anthony Liguori wrote:
> This has been discussed before in the past. The special casing really makes no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
Applied.
Regards,
Anthony Liguori
> ---
> Makefile | 5 ++---
> Makefile.target | 4 ----
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8606849..51ecdb5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -365,9 +365,8 @@ tar:
> rm -rf /tmp/$(FILE)
>
> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
> - $(patsubst %-softmmu,qemu-system-%, \
> - $(SYSTEM_TARGETS)))
> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
> + $(SYSTEM_TARGETS))
>
> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
> diff --git a/Makefile.target b/Makefile.target
> index 07af4d4..29287ed 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
> QEMU_PROG=qemu-$(TARGET_ARCH2)
> else
> # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
> endif
> -endif
>
> PROGS=$(QEMU_PROG)
> STPFILES=
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-09-02 15:40 ` Anthony Liguori
@ 2011-09-03 13:44 ` Andreas Färber
2011-09-03 16:11 ` Paolo Bonzini
2011-09-03 20:09 ` Anthony Liguori
0 siblings, 2 replies; 12+ messages in thread
From: Andreas Färber @ 2011-09-03 13:44 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel
Am 02.09.2011 um 17:40 schrieb Anthony Liguori:
> On 08/29/2011 09:55 AM, Anthony Liguori wrote:
>> This has been discussed before in the past. The special casing
>> really makes no
>> sense anymore. This seems like a good change to make for 1.0.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> Applied.
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> Makefile | 5 ++---
>> Makefile.target | 4 ----
>> 2 files changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 8606849..51ecdb5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -365,9 +365,8 @@ tar:
>> rm -rf /tmp/$(FILE)
>>
>> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
>> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
>> - $(patsubst %-softmmu,qemu-system-%, \
>> - $(SYSTEM_TARGETS)))
>> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
>> + $(SYSTEM_TARGETS))
>>
>> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
>> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
>> diff --git a/Makefile.target b/Makefile.target
>> index 07af4d4..29287ed 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
>> QEMU_PROG=qemu-$(TARGET_ARCH2)
>> else
>> # system emulator name
>> -ifeq ($(TARGET_ARCH), i386)
>> -QEMU_PROG=qemu$(EXESUF)
>> -else
>> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>> endif
>> -endif
>>
>> PROGS=$(QEMU_PROG)
>> STPFILES=
This will leave an old qemu executable from a previous `make install`
behind.
We should check for it and, unless it's a symlink to qemu-system-i386,
remove it in the install target.
Andreas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-09-03 13:44 ` Andreas Färber
@ 2011-09-03 16:11 ` Paolo Bonzini
2011-09-03 20:09 ` Anthony Liguori
1 sibling, 0 replies; 12+ messages in thread
From: Paolo Bonzini @ 2011-09-03 16:11 UTC (permalink / raw)
To: Andreas Färber; +Cc: Blue Swirl, Anthony Liguori, qemu-devel
On 09/03/2011 03:44 PM, Andreas Färber wrote:
> This will leave an old qemu executable from a previous `make
> install` behind. We should check for it and, unless it's a symlink
> to qemu-system-i386, remove it in the install target.
No, "make install" should never remove anything.
Paolo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-09-03 13:44 ` Andreas Färber
2011-09-03 16:11 ` Paolo Bonzini
@ 2011-09-03 20:09 ` Anthony Liguori
2011-09-04 13:31 ` Andreas Färber
1 sibling, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2011-09-03 20:09 UTC (permalink / raw)
To: Andreas Färber; +Cc: Blue Swirl, Anthony Liguori, qemu-devel
On 09/03/2011 08:44 AM, Andreas Färber wrote:
> Am 02.09.2011 um 17:40 schrieb Anthony Liguori:
>
>> On 08/29/2011 09:55 AM, Anthony Liguori wrote:
>>> This has been discussed before in the past. The special casing really
>>> makes no
>>> sense anymore. This seems like a good change to make for 1.0.
>>>
>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>
>> Applied.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>> ---
>>> Makefile | 5 ++---
>>> Makefile.target | 4 ----
>>> 2 files changed, 2 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 8606849..51ecdb5 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -365,9 +365,8 @@ tar:
>>> rm -rf /tmp/$(FILE)
>>>
>>> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS))
>>> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \
>>> - $(patsubst %-softmmu,qemu-system-%, \
>>> - $(SYSTEM_TARGETS)))
>>> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \
>>> + $(SYSTEM_TARGETS))
>>>
>>> USER_TARGETS=$(filter %-user,$(TARGET_DIRS))
>>> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \
>>> diff --git a/Makefile.target b/Makefile.target
>>> index 07af4d4..29287ed 100644
>>> --- a/Makefile.target
>>> +++ b/Makefile.target
>>> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
>>> QEMU_PROG=qemu-$(TARGET_ARCH2)
>>> else
>>> # system emulator name
>>> -ifeq ($(TARGET_ARCH), i386)
>>> -QEMU_PROG=qemu$(EXESUF)
>>> -else
>>> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>>> endif
>>> -endif
>>>
>>> PROGS=$(QEMU_PROG)
>>> STPFILES=
>
> This will leave an old qemu executable from a previous `make install`
> behind.
You're not supposed to do a make install on top of another install.
You're supposed to first do a make uninstall in the old tree than a make
install in the new tree.
Semantically, this is how a distro package upgrade works.
> We should check for it and, unless it's a symlink to qemu-system-i386,
> remove it in the install target.
Once we're no longer generating an executable, we should be removing it
from the system.
It's up to the user to remove old files from the system.
Regards,
Anthony Liguori
>
> Andreas
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
2011-09-03 20:09 ` Anthony Liguori
@ 2011-09-04 13:31 ` Andreas Färber
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2011-09-04 13:31 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, Paolo Bonzini, QEMU Developers
Am 03.09.2011 um 22:09 schrieb Anthony Liguori:
> On 09/03/2011 08:44 AM, Andreas Färber wrote:
>> Am 02.09.2011 um 17:40 schrieb Anthony Liguori:
>>
>>> On 08/29/2011 09:55 AM, Anthony Liguori wrote:
>>>> diff --git a/Makefile.target b/Makefile.target
>>>> index 07af4d4..29287ed 100644
>>>> --- a/Makefile.target
>>>> +++ b/Makefile.target
>>>> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
>>>> QEMU_PROG=qemu-$(TARGET_ARCH2)
>>>> else
>>>> # system emulator name
>>>> -ifeq ($(TARGET_ARCH), i386)
>>>> -QEMU_PROG=qemu$(EXESUF)
>>>> -else
>>>> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>>>> endif
>>>> -endif
>>>>
>>>> PROGS=$(QEMU_PROG)
>>>> STPFILES=
>>
>> This will leave an old qemu executable from a previous `make install`
>> behind.
>
> You're not supposed to do a make install on top of another install.
> You're supposed to first do a make uninstall in the old tree than a
> make install in the new tree.
In practice though, I do git pull, make, make install and so will
others.
>> We should check for it and, unless it's a symlink to qemu-system-
>> i386,
>> remove it in the install target.
>
> Once we're no longer generating an executable, we should be removing
> it from the system.
>
> It's up to the user to remove old files from the system.
Yeah, Paolo is right there, install shouldn't remove.
What I had in mind was Git's switch from lots of git-* scripts to the
single git. `make install` checked for such artefacts. My point was, I
believe we should do the same here and *detect* it within the install
target.
I'd be fine with a prominent textual notice. And I'd contribute a
patch myself but have more urgent worries first, so if someone with
more shell foo wants to take a stab, please do.
We should also make sure `make clean` still removes an old qemu from
the build dir.
Andreas
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-09-04 13:31 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-29 14:55 [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 Anthony Liguori
2011-08-30 15:33 ` Juan Quintela
2011-08-30 15:41 ` Peter Maydell
2011-08-30 15:59 ` Anthony Liguori
2011-08-30 19:24 ` Blue Swirl
2011-09-02 15:39 ` Anthony Liguori
2011-09-03 11:46 ` Blue Swirl
2011-09-02 15:40 ` Anthony Liguori
2011-09-03 13:44 ` Andreas Färber
2011-09-03 16:11 ` Paolo Bonzini
2011-09-03 20:09 ` Anthony Liguori
2011-09-04 13:31 ` Andreas Färber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.