* [lm-sensors] [PATCH] hwmon: (smsc47b397) Fix checkpatch errors
@ 2011-08-29 13:14 Jean Delvare
2011-08-29 15:08 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2011-08-29 13:14 UTC (permalink / raw)
To: lm-sensors
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Guenter, this doesn't fix the warning you reported earlier, but
probably good to apply nevertheless.
drivers/hwmon/smsc47b397.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--- linux-3.1-rc3.orig/drivers/hwmon/smsc47b397.c 2011-08-29 14:44:07.000000000 +0200
+++ linux-3.1-rc3/drivers/hwmon/smsc47b397.c 2011-08-29 14:54:22.000000000 +0200
@@ -113,7 +113,7 @@ struct smsc47b397_data {
u8 temp[4];
};
-static int smsc47b397_read_value(struct smsc47b397_data* data, u8 reg)
+static int smsc47b397_read_value(struct smsc47b397_data *data, u8 reg)
{
int res;
@@ -265,7 +265,8 @@ static int __devinit smsc47b397_probe(st
return -EBUSY;
}
- if (!(data = kzalloc(sizeof(struct smsc47b397_data), GFP_KERNEL))) {
+ data = kzalloc(sizeof(struct smsc47b397_data), GFP_KERNEL);
+ if (!data) {
err = -ENOMEM;
goto error_release;
}
@@ -276,7 +277,8 @@ static int __devinit smsc47b397_probe(st
mutex_init(&data->update_lock);
platform_set_drvdata(pdev, data);
- if ((err = sysfs_create_group(&dev->kobj, &smsc47b397_group)))
+ err = sysfs_create_group(&dev->kobj, &smsc47b397_group);
+ if (err)
goto error_free;
data->hwmon_dev = hwmon_device_register(dev);
@@ -345,7 +347,7 @@ static int __init smsc47b397_find(unsign
superio_enter();
id = force_id ? force_id : superio_inb(SUPERIO_REG_DEVID);
- switch(id) {
+ switch (id) {
case 0x81:
name = "SCH5307-NS";
break;
@@ -379,7 +381,8 @@ static int __init smsc47b397_init(void)
unsigned short address;
int ret;
- if ((ret = smsc47b397_find(&address)))
+ ret = smsc47b397_find(&address);
+ if (ret)
return ret;
ret = platform_driver_register(&smsc47b397_driver);
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (smsc47b397) Fix checkpatch errors
2011-08-29 13:14 [lm-sensors] [PATCH] hwmon: (smsc47b397) Fix checkpatch errors Jean Delvare
@ 2011-08-29 15:08 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2011-08-29 15:08 UTC (permalink / raw)
To: lm-sensors
On Mon, 2011-08-29 at 09:14 -0400, Jean Delvare wrote:
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> Guenter, this doesn't fix the warning you reported earlier, but
> probably good to apply nevertheless.
>
Definitely. Looks good.
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-29 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-29 13:14 [lm-sensors] [PATCH] hwmon: (smsc47b397) Fix checkpatch errors Jean Delvare
2011-08-29 15:08 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.