[PATCH] ramfs: Remove module leftovers

[PATCH] ramfs: Remove module leftovers

[Richard Weinberger]

Since ramfs is hard-selected to "y", the module leftovers make
no sense.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/ramfs/inode.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c
index eacb166..313ae92 100644
--- a/fs/ramfs/inode.c
+++ b/fs/ramfs/inode.c
@@ -23,7 +23,6 @@
  * caches is sufficient.
  */
 
-#include <linux/module.h>
 #include <linux/fs.h>
 #include <linux/pagemap.h>
 #include <linux/highmem.h>
@@ -294,8 +293,8 @@ static void __exit exit_ramfs_fs(void)
 	unregister_filesystem(&ramfs_fs_type);
 }
 
-module_init(init_ramfs_fs)
-module_exit(exit_ramfs_fs)
+device_initcall(init_ramfs_fs);
+__exitcall(exit_ramfs_fs);
 
 int __init init_rootfs(void)
 {
@@ -311,5 +310,3 @@ int __init init_rootfs(void)
 
 	return err;
 }
-
-MODULE_LICENSE("GPL");
-- 
1.7.6.1

Re: [PATCH] ramfs: Remove module leftovers

[Américo Wang]

On Mon, Aug 29, 2011 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote:
> Since ramfs is hard-selected to "y", the module leftovers make
> no sense.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Yeah, it makes sense to remove these module stuffs,
but I think there is no need to make exit_ramfs_fs()
be an __exit_call, so just remove exit_ramfs_fs()?

Thanks.

Re: [PATCH] ramfs: Remove module leftovers

[Richard Weinberger]

Am 30.08.2011 16:29, schrieb Américo Wang:
> On Mon, Aug 29, 2011 at 11:24 PM, Richard Weinberger<richard@nod.at>  wrote:
>> Since ramfs is hard-selected to "y", the module leftovers make
>> no sense.
>>
>> Signed-off-by: Richard Weinberger<richard@nod.at>
>
> Yeah, it makes sense to remove these module stuffs,
> but I think there is no need to make exit_ramfs_fs()
> be an __exit_call, so just remove exit_ramfs_fs()?

True. There no need to unregister ramfs.
I'll resend an updated patch!

Thanks,
//richard