* [net] e1000: Fix driver to be used on PA RISC C8000 workstations
@ 2011-08-31 0:19 Jeff Kirsher
2011-08-31 0:39 ` David Miller
2011-08-31 15:37 ` [stable] " Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Kirsher @ 2011-08-31 0:19 UTC (permalink / raw)
To: davem
Cc: Jeff Kirsher, netdev, gospo, stable, Guy Martin, Rolf Eike Beer,
Matt Turner
The checksum field in the EEPROM on HPPA is really not a
checksum but a signature (0x16d6). So allow 0x16d6 as the
matching checksum on HPPA systems.
This issue is present on longterm/stable kernels, I have
verified that this patch is applicable back to at least
2.6.32.y kernels.
CC: Guy Martin <gmsoft@tuxicoman.be>
CC: Rolf Eike Beer <eike-kernel@sf-tec.de>
CC: Matt Turner <mattst88@gmail.com>
Reported-by: Mikulas Patocka <mikulas@artax.kerlin.mff.cuni.cz>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
drivers/net/e1000/e1000_hw.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net/e1000/e1000_hw.c
index 8545c7a..08c1ad5 100644
--- a/drivers/net/e1000/e1000_hw.c
+++ b/drivers/net/e1000/e1000_hw.c
@@ -4026,6 +4026,12 @@ s32 e1000_validate_eeprom_checksum(struct e1000_hw *hw)
checksum += eeprom_data;
}
+#ifdef __hppa__
+ /* This is a signature and not a checksum on HP c8000 */
+ if ((hw->subsystem_vendor_id == 0x103C) && (eeprom_data == 0x16d6))
+ return E1000_SUCCESS;
+
+#endif
if (checksum == (u16) EEPROM_SUM)
return E1000_SUCCESS;
else {
--
1.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [net] e1000: Fix driver to be used on PA RISC C8000 workstations
2011-08-31 0:19 [net] e1000: Fix driver to be used on PA RISC C8000 workstations Jeff Kirsher
@ 2011-08-31 0:39 ` David Miller
2011-08-31 0:48 ` Jeff Kirsher
2011-08-31 15:37 ` [stable] " Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2011-08-31 0:39 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, stable, gmsoft, gospo, eike-kernel, mattst88
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 30 Aug 2011 17:19:26 -0700
> +#ifdef __hppa__
Please use CONFIG_PARISC
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net] e1000: Fix driver to be used on PA RISC C8000 workstations
2011-08-31 0:39 ` David Miller
@ 2011-08-31 0:48 ` Jeff Kirsher
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Kirsher @ 2011-08-31 0:48 UTC (permalink / raw)
To: David Miller; +Cc: netdev, gospo, stable, gmsoft, eike-kernel, mattst88
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
On Tue, 2011-08-30 at 17:39 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Tue, 30 Aug 2011 17:19:26 -0700
>
> > +#ifdef __hppa__
>
> Please use CONFIG_PARISC
Ok, I will put together a v2 of the patch with your suggested change.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [net] e1000: Fix driver to be used on PA RISC C8000 workstations
2011-08-31 0:19 [net] e1000: Fix driver to be used on PA RISC C8000 workstations Jeff Kirsher
2011-08-31 0:39 ` David Miller
@ 2011-08-31 15:37 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2011-08-31 15:37 UTC (permalink / raw)
To: Jeff Kirsher
Cc: davem, netdev, Guy Martin, Matt Turner, gospo, Rolf Eike Beer, stable
On Tue, Aug 30, 2011 at 05:19:26PM -0700, Jeff Kirsher wrote:
> The checksum field in the EEPROM on HPPA is really not a
> checksum but a signature (0x16d6). So allow 0x16d6 as the
> matching checksum on HPPA systems.
>
> This issue is present on longterm/stable kernels, I have
> verified that this patch is applicable back to at least
> 2.6.32.y kernels.
>
> CC: Guy Martin <gmsoft@tuxicoman.be>
> CC: Rolf Eike Beer <eike-kernel@sf-tec.de>
> CC: Matt Turner <mattst88@gmail.com>
> Reported-by: Mikulas Patocka <mikulas@artax.kerlin.mff.cuni.cz>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-31 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-31 0:19 [net] e1000: Fix driver to be used on PA RISC C8000 workstations Jeff Kirsher
2011-08-31 0:39 ` David Miller
2011-08-31 0:48 ` Jeff Kirsher
2011-08-31 15:37 ` [stable] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.