All of lore.kernel.org
 help / color / mirror / Atom feed
* devkit8000 & omap3stalker LCD panel
@ 2011-09-01  6:42 Tomi Valkeinen
  2011-09-01 13:00 ` Thomas Weber
  2011-09-01 13:05 ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Thomas Weber
  0 siblings, 2 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2011-09-01  6:42 UTC (permalink / raw)
  To: lzg, weber; +Cc: linux-omap mailing list

Hi Thomas, Jason,

I noticed that both devkit8000 and omap3stalker boards use the generic
dpi driver for LCD. Why is that? If the boards have a normal fixed
resolution LCD, the timings for the LCD should be added to the
panel-generic-dpi.c.

 Tomi



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: devkit8000 & omap3stalker LCD panel
  2011-09-01  6:42 devkit8000 & omap3stalker LCD panel Tomi Valkeinen
@ 2011-09-01 13:00 ` Thomas Weber
  2011-09-01 13:05 ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Thomas Weber
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Weber @ 2011-09-01 13:00 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: lzg, linux-omap mailing list

Am 01.09.2011 08:42, schrieb Tomi Valkeinen:
> Hi Thomas, Jason,
>
> I noticed that both devkit8000 and omap3stalker boards use the generic
> dpi driver for LCD. Why is that? If the boards have a normal fixed
> resolution LCD, the timings for the LCD should be added to the
> panel-generic-dpi.c.
>
>  Tomi
>
>
Hello Tomi,

I will send a patch that adds support for the devkit8000 panel.

Thomas


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83
  2011-09-01  6:42 devkit8000 & omap3stalker LCD panel Tomi Valkeinen
  2011-09-01 13:00 ` Thomas Weber
@ 2011-09-01 13:05 ` Thomas Weber
  2011-09-01 13:05   ` [PATCH 2/3] OMAP: Devkit8000: Change lcd driver to AT070TN83 Thomas Weber
  2011-09-02  7:58   ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Tomi Valkeinen
  1 sibling, 2 replies; 6+ messages in thread
From: Thomas Weber @ 2011-09-01 13:05 UTC (permalink / raw)
  To: linux-omap; +Cc: Thomas Weber, Tomi Valkeinen

Add support for Innolux AT070TN83, a 7 inch LCD
with RGB-Interface and touch panel to panel-generic-dpi.

Tested with Devkit8000.

Signed-off-by: Thomas Weber <weber@corscience.de>
---
 drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
index 9c90f75..b401304 100644
--- a/drivers/video/omap2/displays/panel-generic-dpi.c
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -232,6 +232,31 @@ static struct panel_config generic_dpi_panels[] = {
 		.power_off_delay	= 0,
 		.name			= "powertip_ph480272t",
 	},
+
+	/* Innolux AT070TN83 */
+	{
+		{
+			.x_res		= 800,
+			.y_res		= 480,
+
+			.pixel_clock	= 40000,
+
+			.hsw		= 48,
+			.hfp		= 1,
+			.hbp		= 1,
+
+			.vsw		= 3,
+			.vfp		= 12,
+			.vbp		= 25,
+		},
+		.acbi			= 0x0,
+		.acb			= 0x28,
+		.config			= OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+					  OMAP_DSS_LCD_IHS,
+		.power_on_delay		= 0,
+		.power_off_delay	= 0,
+		.name			= "innolux_at070tn83",
+	},
 };
 
 struct panel_drv_data {
-- 
1.7.6.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] OMAP: Devkit8000: Change lcd driver to AT070TN83
  2011-09-01 13:05 ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Thomas Weber
@ 2011-09-01 13:05   ` Thomas Weber
  2011-09-02  7:58   ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Tomi Valkeinen
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Weber @ 2011-09-01 13:05 UTC (permalink / raw)
  To: linux-omap; +Cc: Thomas Weber, Tomi Valkeinen

Change lcd driver from generic to AT070TN83.

Signed-off-by: Thomas Weber <weber@corscience.de>
---
 arch/arm/mach-omap2/board-devkit8000.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c
index 4b1f6c6..a3b8e81 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -139,7 +139,7 @@ static struct regulator_consumer_supply devkit8000_vio_supply[] = {
 };
 
 static struct panel_generic_dpi_data lcd_panel = {
-	.name			= "generic",
+	.name			= "innolux_at070tn83",
 	.platform_enable        = devkit8000_panel_enable_lcd,
 	.platform_disable       = devkit8000_panel_disable_lcd,
 };
-- 
1.7.6.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83
  2011-09-01 13:05 ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Thomas Weber
  2011-09-01 13:05   ` [PATCH 2/3] OMAP: Devkit8000: Change lcd driver to AT070TN83 Thomas Weber
@ 2011-09-02  7:58   ` Tomi Valkeinen
  2011-09-05  8:25     ` Thomas Weber
  1 sibling, 1 reply; 6+ messages in thread
From: Tomi Valkeinen @ 2011-09-02  7:58 UTC (permalink / raw)
  To: Thomas Weber; +Cc: linux-omap

On Thu, 2011-09-01 at 15:05 +0200, Thomas Weber wrote:
> Add support for Innolux AT070TN83, a 7 inch LCD
> with RGB-Interface and touch panel to panel-generic-dpi.
> 
> Tested with Devkit8000.
> 
> Signed-off-by: Thomas Weber <weber@corscience.de>
> ---
>  drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)

Thanks, these look fine to me.

The subject suggests there are 3 patches, but I presume that's wrong?

 Tomi



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83
  2011-09-02  7:58   ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Tomi Valkeinen
@ 2011-09-05  8:25     ` Thomas Weber
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Weber @ 2011-09-05  8:25 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: linux-omap

Am 02.09.2011 09:58, schrieb Tomi Valkeinen:
> On Thu, 2011-09-01 at 15:05 +0200, Thomas Weber wrote:
>> Add support for Innolux AT070TN83, a 7 inch LCD
>> with RGB-Interface and touch panel to panel-generic-dpi.
>>
>> Tested with Devkit8000.
>>
>> Signed-off-by: Thomas Weber <weber@corscience.de>
>> ---
>>  drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
>>  1 files changed, 25 insertions(+), 0 deletions(-)
> Thanks, these look fine to me.
>
> The subject suggests there are 3 patches, but I presume that's wrong?
>
>  Tomi
>
>
>
You are right, I had an additional patch during format-patch.

Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-09-05  8:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-01  6:42 devkit8000 & omap3stalker LCD panel Tomi Valkeinen
2011-09-01 13:00 ` Thomas Weber
2011-09-01 13:05 ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Thomas Weber
2011-09-01 13:05   ` [PATCH 2/3] OMAP: Devkit8000: Change lcd driver to AT070TN83 Thomas Weber
2011-09-02  7:58   ` [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83 Tomi Valkeinen
2011-09-05  8:25     ` Thomas Weber

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.