All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 04/11] xfs: call xfs_buf_delwri_queue directly
Date: Thu, 1 Sep 2011 14:22:15 -0500	[thread overview]
Message-ID: <1314904935.2903.62.camel@doink> (raw)
In-Reply-To: <20110823082912.512830398@bombadil.infradead.org>

On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote:
> Unify the ways we add buffers to the delwri queue by always calling
> xfs_buf_delwri_queue directly.  The xfs_bdwrite functions is removed and
> opencoded in its callers, and the two places setting XBF_DELWRI while a
> buffer is locked and expecting xfs_buf_unlock to pick it up are converted
> to call xfs_buf_delwri_queue directly, too.  Also replace the
> XFS_BUF_UNDELAYWRITE macro with direct calls to xfs_buf_delwri_dequeue
> to make the explicit queuing/dequeuing more obvious.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

So instead of just marking XBF_DELWRI to flag to signal
that the buffer should be queued at unlock time, we now
just put it in the queue right away.  Seems reasonable.
Do you know why enqueueing it was delayed before?

In any case:
Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-09-01 19:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23  8:28 [PATCH 00/11] patch queue for Linux 3.2 Christoph Hellwig
2011-08-23  8:28 ` [PATCH 01/11] xfs: remove delwri buffer handling from xfs_buf_iorequest Christoph Hellwig
2011-09-01 19:21   ` Alex Elder
2011-08-23  8:28 ` [PATCH 02/11] xfs: remove the unlock argument to xfs_buf_delwri_queue Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-09-01 21:39     ` Christoph Hellwig
2011-08-23  8:28 ` [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 04/11] xfs: call xfs_buf_delwri_queue directly Christoph Hellwig
2011-09-01 19:22   ` Alex Elder [this message]
2011-09-01 21:46     ` Christoph Hellwig
2011-09-02  0:17       ` Dave Chinner
2011-08-23  8:28 ` [PATCH 05/11] xfs: let xfs_bwrite callers handle the xfs_buf_relse Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 06/11] xfs: use the "delwri" terminology consistently Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 07/11] xfs: remove dead ENODEV handling in xfs_destroy_ioend Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 08/11] xfs: defer AIO/DIO completions Christoph Hellwig
2011-08-24  0:01   ` Dave Chinner
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 09/11] xfs: reduce ioend latency Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 10/11] xfs: wait for I/O completion when writing out pages in xfs_setattr_size Christoph Hellwig
2011-09-01 19:22   ` Alex Elder
2011-08-23  8:28 ` [PATCH 11/11] xfs: remove i_iocount Christoph Hellwig
2011-09-01 19:22   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314904935.2903.62.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.