[U-Boot] [PATCH] harmony: fix out of tree building

[U-Boot] [PATCH] harmony: fix out of tree building

[Wolfgang Denk]

Out of tree building of the "harmony" board failed like this:

Configuring for harmony board...
Assembler messages:
Fatal error: can't create /work/wd/tmp-arm/board/nvidia/harmony/../common/board.o: No such file or directory
make[1]: *** [/work/wd/tmp-arm/board/nvidia/harmony/../common/board.o] Error 2

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Tom Warren <twarren@nvidia.com>
---
 board/nvidia/harmony/Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile
index 9fb6b57..ebd8e02 100644
--- a/board/nvidia/harmony/Makefile
+++ b/board/nvidia/harmony/Makefile
@@ -24,6 +24,10 @@
 
 include $(TOPDIR)/config.mk
 
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
+
 LIB	= $(obj)lib$(BOARD).o
 
 COBJS	:= $(BOARD).o
-- 
1.7.6

[U-Boot] [PATCH] harmony / seaboard: fix out of tree building

[Wolfgang Denk]

Out of tree building of the "harmony" and "seaboard" boards failed
like this:

Configuring for harmony board...
Assembler messages:
Fatal error: can't create /work/wd/tmp-arm/board/nvidia/harmony/../common/board.o: No such file or directory
make[1]: *** [/work/wd/tmp-arm/board/nvidia/harmony/../common/board.o] Error 2

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Tom Warren <twarren@nvidia.com>
---
This replaces [PATCH] harmony: fix out of tree building;
both Nvidia boards have the same problem, so fix them in one go.

 board/nvidia/harmony/Makefile  |    4 ++++
 board/nvidia/seaboard/Makefile |    4 ++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile
index 9fb6b57..ebd8e02 100644
--- a/board/nvidia/harmony/Makefile
+++ b/board/nvidia/harmony/Makefile
@@ -24,6 +24,10 @@
 
 include $(TOPDIR)/config.mk
 
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
+
 LIB	= $(obj)lib$(BOARD).o
 
 COBJS	:= $(BOARD).o
diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile
index 9fb6b57..ebd8e02 100644
--- a/board/nvidia/seaboard/Makefile
+++ b/board/nvidia/seaboard/Makefile
@@ -24,6 +24,10 @@
 
 include $(TOPDIR)/config.mk
 
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
+
 LIB	= $(obj)lib$(BOARD).o
 
 COBJS	:= $(BOARD).o
-- 
1.7.6

[U-Boot] [PATCH] harmony / seaboard: fix out of tree building

[Anton Staaf]

On Mon, Sep 5, 2011 at 12:37 PM, Wolfgang Denk <wd@denx.de> wrote:
> Out of tree building of the "harmony" and "seaboard" boards failed
> like this:
>
> Configuring for harmony board...
> Assembler messages:
> Fatal error: can't create /work/wd/tmp-arm/board/nvidia/harmony/../common/board.o: No such file or directory
> make[1]: *** [/work/wd/tmp-arm/board/nvidia/harmony/../common/board.o] Error 2
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
> This replaces [PATCH] harmony: fix out of tree building;
> both Nvidia boards have the same problem, so fix them in one go.
>
> ?board/nvidia/harmony/Makefile ?| ? ?4 ++++
> ?board/nvidia/seaboard/Makefile | ? ?4 ++++
> ?2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile
> index 9fb6b57..ebd8e02 100644
> --- a/board/nvidia/harmony/Makefile
> +++ b/board/nvidia/harmony/Makefile
> @@ -24,6 +24,10 @@
>
> ?include $(TOPDIR)/config.mk
>
> +ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../common)
> +endif
> +
> ?LIB ? ?= $(obj)lib$(BOARD).o

This looks good to me.  But I'm confused, I submitted this same fix a
while ago and was told to instead create a separate library our of the
common code...  Oh well.  :)

Thanks,
    Anton

> ?COBJS ?:= $(BOARD).o
> diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile
> index 9fb6b57..ebd8e02 100644
> --- a/board/nvidia/seaboard/Makefile
> +++ b/board/nvidia/seaboard/Makefile
> @@ -24,6 +24,10 @@
>
> ?include $(TOPDIR)/config.mk
>
> +ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../common)
> +endif
> +
> ?LIB ? ?= $(obj)lib$(BOARD).o
>
> ?COBJS ?:= $(BOARD).o
> --
> 1.7.6
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] harmony / seaboard: fix out of tree building

[Wolfgang Denk]

Dear Wolfgang Denk,

In message <1315251447-23869-1-git-send-email-wd@denx.de> you wrote:
> Out of tree building of the "harmony" and "seaboard" boards failed
> like this:
> 
> Configuring for harmony board...
> Assembler messages:
> Fatal error: can't create /work/wd/tmp-arm/board/nvidia/harmony/../common/board.o: No such file or directory
> make[1]: *** [/work/wd/tmp-arm/board/nvidia/harmony/../common/board.o] Error 2
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
> This replaces [PATCH] harmony: fix out of tree building;
> both Nvidia boards have the same problem, so fix them in one go.
> 
>  board/nvidia/harmony/Makefile  |    4 ++++
>  board/nvidia/seaboard/Makefile |    4 ++++
>  2 files changed, 8 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
                        - Terry Pratchett, _The Dark Side of the Sun_

[U-Boot] [PATCH] harmony / seaboard: fix out of tree building

[Wolfgang Denk]

Dear Anton Staaf,

In message <CAF6FioW+7srjzS4g1NNwZ58gWYmCbAxCTRCzo7u9isd_2=x4Dw@mail.gmail.com> you wrote:
>
> This looks good to me.  But I'm confused, I submitted this same fix a
> while ago and was told to instead create a separate library our of the
> common code...  Oh well.  :)

Must have missed this.  Well, the "shell mkdir" method is currently
used in a number of Makefiles. Indeed there should be a better way to
solve this...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whenever people agree with me, I always think I must be wrong.
- Oscar Wilde