All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Input: wacom bamboo improvements
@ 2011-09-15  1:36 chris
  2011-09-15  1:36 ` [PATCH 1/3] Input: wacom - remove unneeded touch pressure init chris
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: chris @ 2011-09-15  1:36 UTC (permalink / raw)
  To: linux-input, pinglinux; +Cc: Chris Bagwell

From: Chris Bagwell <chris@cnpbagwell.com>

The need for patch 3 was recently discussed on linuxwacom
mailing list. During that discussion, I looked closer at pen
code and notice pressure cleanup needed (patch 1) and that
ABS_DISTANCE was not completely implemented (patch 2).

Chris Bagwell (3):
  Input: wacom - remove unneeded touch pressure init
  Input: wacom - add ABS_DISTANCE to Bamboo Pen reports
  Input: wacom - correct max Y value on medium bamboos

 drivers/input/tablet/wacom_wac.c |   47 +++++++++++++++++++++-----------------
 1 files changed, 26 insertions(+), 21 deletions(-)

-- 
1.7.6


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] Input: wacom - remove unneeded touch pressure init
  2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
@ 2011-09-15  1:36 ` chris
  2011-09-15  1:36 ` [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports chris
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: chris @ 2011-09-15  1:36 UTC (permalink / raw)
  To: linux-input, pinglinux; +Cc: Chris Bagwell

From: Chris Bagwell <chris@cnpbagwell.com>

These were left in during removal of touch pressure reports
but not needed now.

Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
---
 drivers/input/tablet/wacom_wac.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 74fa7dd..1503425 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1030,8 +1030,6 @@ void wacom_setup_device_quirks(struct wacom_features *features)
 		features->y_max <<= 5;
 		features->x_fuzz <<= 5;
 		features->y_fuzz <<= 5;
-		features->pressure_max = 256;
-		features->pressure_fuzz = 16;
 		features->quirks |= WACOM_QUIRK_BBTOUCH_LOWRES;
 	}
 }
@@ -1221,9 +1219,6 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
 			input_set_abs_params(input_dev, ABS_MT_POSITION_Y,
 					     0, features->y_max,
 					     features->y_fuzz, 0);
-			input_set_abs_params(input_dev, ABS_MT_PRESSURE,
-					     0, features->pressure_max,
-					     features->pressure_fuzz, 0);
 		} else if (features->device_type == BTN_TOOL_PEN) {
 			__set_bit(BTN_TOOL_RUBBER, input_dev->keybit);
 			__set_bit(BTN_TOOL_PEN, input_dev->keybit);
-- 
1.7.6


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports
  2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
  2011-09-15  1:36 ` [PATCH 1/3] Input: wacom - remove unneeded touch pressure init chris
@ 2011-09-15  1:36 ` chris
  2011-09-19 19:11   ` Ping Cheng
  2011-09-15  1:36 ` [PATCH 3/3] Input: wacom - correct max Y value on medium bamboos chris
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 7+ messages in thread
From: chris @ 2011-09-15  1:36 UTC (permalink / raw)
  To: linux-input, pinglinux; +Cc: Chris Bagwell

From: Chris Bagwell <chris@cnpbagwell.com>

Tablet reports a distance of 0 right at highest point possible
to be in proximity and distance_max when touching tablet. Inverse
the distance since user land has no way of knowing ABS_DISTANCE
is not distance from tablet.

Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
---
 drivers/input/tablet/wacom_wac.c |   34 ++++++++++++++++++++++------------
 1 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 1503425..d7da1b0 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -874,7 +874,14 @@ static int wacom_bpt_pen(struct wacom_wac *wacom)
 		x = le16_to_cpup((__le16 *)&data[2]);
 		y = le16_to_cpup((__le16 *)&data[4]);
 		p = le16_to_cpup((__le16 *)&data[6]);
-		d = data[8];
+		/* convert distance from out prox to distance from tablet.
+		 * distance will be greater than distance_max once
+		 * touching and applying pressure. do not report negative
+		 * distance.
+		 */
+		if (data[8] <= wacom->features.distance_max)
+			d = wacom->features.distance_max - data[8];
+
 		pen = data[1] & 0x01;
 		btn1 = data[1] & 0x02;
 		btn2 = data[1] & 0x04;
@@ -1224,6 +1231,9 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
 			__set_bit(BTN_TOOL_PEN, input_dev->keybit);
 			__set_bit(BTN_STYLUS, input_dev->keybit);
 			__set_bit(BTN_STYLUS2, input_dev->keybit);
+			input_set_abs_params(input_dev, ABS_DISTANCE, 0,
+					      features->distance_max,
+					      0, 0);
 		}
 		break;
 	}
@@ -1444,37 +1454,37 @@ static const struct wacom_features wacom_features_0x47 =
 	  31, INTUOS, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD0 =
 	{ "Wacom Bamboo 2FG",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD1 =
 	{ "Wacom Bamboo 2FG 4x5", WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD2 =
 	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD3 =
 	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD4 =
 	{ "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD5 =
 	{ "Wacom Bamboo Pen 6x8",     WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD6 =
 	{ "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD7 =
 	{ "Wacom BambooPT 2FG Small", WACOM_PKGLEN_BBFUN, 14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD8 =
 	{ "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13530, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xDA =
 	{ "Wacom Bamboo 2FG 4x5 SE", WACOM_PKGLEN_BBFUN,  14720,  9200, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static struct wacom_features wacom_features_0xDB =
 	{ "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN,  21648, 13530, 1023,
-	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0x6004 =
 	{ "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800,  8000,  255,
 	  0, TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
-- 
1.7.6


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] Input: wacom - correct max Y value on medium bamboos
  2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
  2011-09-15  1:36 ` [PATCH 1/3] Input: wacom - remove unneeded touch pressure init chris
  2011-09-15  1:36 ` [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports chris
@ 2011-09-15  1:36 ` chris
  2011-09-16 11:32 ` [PATCH 0/3] Input: wacom bamboo improvements Henrik Rydberg
  2011-10-10 14:04 ` Chris Bagwell
  4 siblings, 0 replies; 7+ messages in thread
From: chris @ 2011-09-15  1:36 UTC (permalink / raw)
  To: linux-input, pinglinux; +Cc: Chris Bagwell

From: Chris Bagwell <chris@cnpbagwell.com>

Medium size Bamboo P&T driver reused max X/Y form older Bamboo 1
medium size tablets and never updated to real value. Actual
active area of tablet is slightly larger in Y direction.

Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
Acked-by: Ping Cheng <pingc@wacom.com>
---
 drivers/input/tablet/wacom_wac.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index d7da1b0..f5641a9 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1462,13 +1462,13 @@ static const struct wacom_features wacom_features_0xD2 =
 	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD3 =
-	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
+	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13700, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD4 =
 	{ "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD5 =
-	{ "Wacom Bamboo Pen 6x8",     WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
+	{ "Wacom Bamboo Pen 6x8",     WACOM_PKGLEN_BBFUN, 21648, 13700, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD6 =
 	{ "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
@@ -1477,13 +1477,13 @@ static const struct wacom_features wacom_features_0xD7 =
 	{ "Wacom BambooPT 2FG Small", WACOM_PKGLEN_BBFUN, 14720,  9200, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD8 =
-	{ "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13530, 1023,
+	{ "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13700, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xDA =
 	{ "Wacom Bamboo 2FG 4x5 SE", WACOM_PKGLEN_BBFUN,  14720,  9200, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static struct wacom_features wacom_features_0xDB =
-	{ "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN,  21648, 13530, 1023,
+	{ "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN,  21648, 13700, 1023,
 	  31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0x6004 =
 	{ "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800,  8000,  255,
-- 
1.7.6


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Input: wacom bamboo improvements
  2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
                   ` (2 preceding siblings ...)
  2011-09-15  1:36 ` [PATCH 3/3] Input: wacom - correct max Y value on medium bamboos chris
@ 2011-09-16 11:32 ` Henrik Rydberg
  2011-10-10 14:04 ` Chris Bagwell
  4 siblings, 0 replies; 7+ messages in thread
From: Henrik Rydberg @ 2011-09-16 11:32 UTC (permalink / raw)
  To: chris; +Cc: linux-input, pinglinux

Hi Chris,

On Wed, Sep 14, 2011 at 08:36:25PM -0500, chris@cnpbagwell.com wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
> 
> The need for patch 3 was recently discussed on linuxwacom
> mailing list. During that discussion, I looked closer at pen
> code and notice pressure cleanup needed (patch 1) and that
> ABS_DISTANCE was not completely implemented (patch 2).
> 
> Chris Bagwell (3):
>   Input: wacom - remove unneeded touch pressure init
>   Input: wacom - add ABS_DISTANCE to Bamboo Pen reports
>   Input: wacom - correct max Y value on medium bamboos
> 
>  drivers/input/tablet/wacom_wac.c |   47 +++++++++++++++++++++-----------------
>  1 files changed, 26 insertions(+), 21 deletions(-)
> 
> -- 
> 1.7.6

    Reviewed-by: Henrik Rydberg <rydberg@euromail.se>

on all three patches.

Thanks,
Henrik

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports
  2011-09-15  1:36 ` [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports chris
@ 2011-09-19 19:11   ` Ping Cheng
  0 siblings, 0 replies; 7+ messages in thread
From: Ping Cheng @ 2011-09-19 19:11 UTC (permalink / raw)
  To: linux-input; +Cc: Dmitry Torokhov, chris

On Wed, Sep 14, 2011 at 6:36 PM,  <chris@cnpbagwell.com> wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
>
> Tablet reports a distance of 0 right at highest point possible
> to be in proximity and distance_max when touching tablet. Inverse
> the distance since user land has no way of knowing ABS_DISTANCE
> is not distance from tablet.
>
> Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>

In case Dmitry is waiting for my confirmation for this patch (all
patches in this series are either acked or reviewed):

Acked-by: Ping Cheng <pingc@wacom.com>

Thanks.

Ping

> ---
>  drivers/input/tablet/wacom_wac.c |   34 ++++++++++++++++++++++------------
>  1 files changed, 22 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 1503425..d7da1b0 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -874,7 +874,14 @@ static int wacom_bpt_pen(struct wacom_wac *wacom)
>                x = le16_to_cpup((__le16 *)&data[2]);
>                y = le16_to_cpup((__le16 *)&data[4]);
>                p = le16_to_cpup((__le16 *)&data[6]);
> -               d = data[8];
> +               /* convert distance from out prox to distance from tablet.
> +                * distance will be greater than distance_max once
> +                * touching and applying pressure. do not report negative
> +                * distance.
> +                */
> +               if (data[8] <= wacom->features.distance_max)
> +                       d = wacom->features.distance_max - data[8];
> +
>                pen = data[1] & 0x01;
>                btn1 = data[1] & 0x02;
>                btn2 = data[1] & 0x04;
> @@ -1224,6 +1231,9 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
>                        __set_bit(BTN_TOOL_PEN, input_dev->keybit);
>                        __set_bit(BTN_STYLUS, input_dev->keybit);
>                        __set_bit(BTN_STYLUS2, input_dev->keybit);
> +                       input_set_abs_params(input_dev, ABS_DISTANCE, 0,
> +                                             features->distance_max,
> +                                             0, 0);
>                }
>                break;
>        }
> @@ -1444,37 +1454,37 @@ static const struct wacom_features wacom_features_0x47 =
>          31, INTUOS, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD0 =
>        { "Wacom Bamboo 2FG",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD1 =
>        { "Wacom Bamboo 2FG 4x5", WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD2 =
>        { "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD3 =
>        { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD4 =
>        { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD5 =
>        { "Wacom Bamboo Pen 6x8",     WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD6 =
>        { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD7 =
>        { "Wacom BambooPT 2FG Small", WACOM_PKGLEN_BBFUN, 14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD8 =
>        { "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13530, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xDA =
>        { "Wacom Bamboo 2FG 4x5 SE", WACOM_PKGLEN_BBFUN,  14720,  9200, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static struct wacom_features wacom_features_0xDB =
>        { "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN,  21648, 13530, 1023,
> -         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +         31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0x6004 =
>        { "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800,  8000,  255,
>          0, TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> --
> 1.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Input: wacom bamboo improvements
  2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
                   ` (3 preceding siblings ...)
  2011-09-16 11:32 ` [PATCH 0/3] Input: wacom bamboo improvements Henrik Rydberg
@ 2011-10-10 14:04 ` Chris Bagwell
  4 siblings, 0 replies; 7+ messages in thread
From: Chris Bagwell @ 2011-10-10 14:04 UTC (permalink / raw)
  To: linux-input, Dmitry Torokhov; +Cc: Chris Bagwell

On Wed, Sep 14, 2011 at 8:36 PM,  <chris@cnpbagwell.com> wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
>
> The need for patch 3 was recently discussed on linuxwacom
> mailing list. During that discussion, I looked closer at pen
> code and notice pressure cleanup needed (patch 1) and that
> ABS_DISTANCE was not completely implemented (patch 2).

Hi Dmitry,

Where there any issues for including these patches?

I also have new patches to add support for just released Bamboo
tablets that support 16 touches... but they build upon these patches.

Should I resend old+new patches together?

Chris

>
> Chris Bagwell (3):
>  Input: wacom - remove unneeded touch pressure init
>  Input: wacom - add ABS_DISTANCE to Bamboo Pen reports
>  Input: wacom - correct max Y value on medium bamboos
>
>  drivers/input/tablet/wacom_wac.c |   47 +++++++++++++++++++++-----------------
>  1 files changed, 26 insertions(+), 21 deletions(-)
>
> --
> 1.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-10-10 14:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-15  1:36 [PATCH 0/3] Input: wacom bamboo improvements chris
2011-09-15  1:36 ` [PATCH 1/3] Input: wacom - remove unneeded touch pressure init chris
2011-09-15  1:36 ` [PATCH 2/3] Input: wacom - add ABS_DISTANCE to Bamboo Pen reports chris
2011-09-19 19:11   ` Ping Cheng
2011-09-15  1:36 ` [PATCH 3/3] Input: wacom - correct max Y value on medium bamboos chris
2011-09-16 11:32 ` [PATCH 0/3] Input: wacom bamboo improvements Henrik Rydberg
2011-10-10 14:04 ` Chris Bagwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.