All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Martin Hostettler <martin@neutronstar.dyndns.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2] arm: omap3evm: Add support for an MT9M032 based camera board.
Date: Sat, 17 Sep 2011 13:24:29 -0700	[thread overview]
Message-ID: <1316291069.1610.23.camel@Joe-Laptop> (raw)
In-Reply-To: <1316252097-4213-1-git-send-email-martin@neutronstar.dyndns.org>

On Sat, 2011-09-17 at 11:34 +0200, Martin Hostettler wrote:
> Adds board support for an MT9M032 based camera to omap3evm.

All of the logging messages could be
prefixed by the printk subsystem if you
add #define pr_fmt before any #include

> diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c b/arch/arm/mach-omap2/board-omap3evm-camera.c
[]
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
[]
> +static int omap3evm_set_mux(enum omap3evmdc_mux mux_id)
[]
> +	switch (mux_id) {
[]
> +	default:
> +		pr_err("omap3evm-camera: Invalid mux id #%d\n", mux_id);

		pr_err("Invalid mux id #%d\n", mux_id);
[]
> +static int __init camera_init(void)
[]
> +	if (gpio_request(nCAM_VD_SEL, "nCAM_VD_SEL") < 0) {
> +		pr_err("omap3evm-camera: Failed to get GPIO nCAM_VD_SEL(%d)\n",
> +		       nCAM_VD_SEL);

		pr_err("Failed to get GPIO nCAM_VD_SEL(%d)\n",
		       nCAM_VD_SEL);
etc.


WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: omap3evm: Add support for an MT9M032 based camera board.
Date: Sat, 17 Sep 2011 13:24:29 -0700	[thread overview]
Message-ID: <1316291069.1610.23.camel@Joe-Laptop> (raw)
In-Reply-To: <1316252097-4213-1-git-send-email-martin@neutronstar.dyndns.org>

On Sat, 2011-09-17 at 11:34 +0200, Martin Hostettler wrote:
> Adds board support for an MT9M032 based camera to omap3evm.

All of the logging messages could be
prefixed by the printk subsystem if you
add #define pr_fmt before any #include

> diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c b/arch/arm/mach-omap2/board-omap3evm-camera.c
[]
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
[]
> +static int omap3evm_set_mux(enum omap3evmdc_mux mux_id)
[]
> +	switch (mux_id) {
[]
> +	default:
> +		pr_err("omap3evm-camera: Invalid mux id #%d\n", mux_id);

		pr_err("Invalid mux id #%d\n", mux_id);
[]
> +static int __init camera_init(void)
[]
> +	if (gpio_request(nCAM_VD_SEL, "nCAM_VD_SEL") < 0) {
> +		pr_err("omap3evm-camera: Failed to get GPIO nCAM_VD_SEL(%d)\n",
> +		       nCAM_VD_SEL);

		pr_err("Failed to get GPIO nCAM_VD_SEL(%d)\n",
		       nCAM_VD_SEL);
etc.

  reply	other threads:[~2011-09-17 20:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-17  9:34 [PATCH v2] arm: omap3evm: Add support for an MT9M032 based camera board Martin Hostettler
2011-09-17  9:34 ` Martin Hostettler
2011-09-17 20:24 ` Joe Perches [this message]
2011-09-17 20:24   ` Joe Perches
2011-09-18 20:10   ` martin
2011-09-18 20:10     ` martin at neutronstar.dyndns.org
2011-09-17 22:00 ` Sylwester Nawrocki
2011-09-17 22:00   ` Sylwester Nawrocki
2011-09-17 22:08   ` Laurent Pinchart
2011-09-17 22:08     ` Laurent Pinchart
2011-09-18 20:13     ` martin
2011-09-18 20:13       ` martin at neutronstar.dyndns.org
2011-09-18 21:58 ` Laurent Pinchart
2011-09-18 21:58   ` Laurent Pinchart
2011-09-19  6:07   ` Hiremath, Vaibhav
2011-09-19  6:07     ` Hiremath, Vaibhav
2011-09-19 19:24     ` martin
2011-09-19 19:24       ` martin at neutronstar.dyndns.org
2011-09-19 19:24       ` martin
2011-09-19 19:59       ` Hiremath, Vaibhav
2011-09-19 19:59         ` Hiremath, Vaibhav
2011-09-19  6:10   ` martin
2011-09-19  6:10     ` martin at neutronstar.dyndns.org
2011-09-19  8:01     ` Laurent Pinchart
2011-09-19  8:01       ` Laurent Pinchart
2011-09-19 19:17   ` Guennadi Liakhovetski
2011-09-19 19:17     ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316291069.1610.23.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=martin@neutronstar.dyndns.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.