All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: tony@atomide.com
Cc: linux-omap@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jason Lam <lzg@ema-tech.com>
Subject: [PATCH 06/10] OMAP: stalker: Remove LCD device from board file
Date: Tue, 20 Sep 2011 11:18:22 +0300	[thread overview]
Message-ID: <1316506706-18941-7-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1316506706-18941-1-git-send-email-tomi.valkeinen@ti.com>

OMAP3 Stalker board has definitions for LCD, but uses the generic driver
without any information what kind of LCD it has. The board should use a
particular panel type from panel-generic-dpi driver, not the generic
one.

As I haven't gotten response the signer-off of stalker board about the
issue, this patch removes the LCD support from the board file. This will
allow us to clean up the panel-generic-dpi driver and make it support
only fixed size panels.

CC: Jason Lam <lzg@ema-tech.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/mach-omap2/board-omap3stalker.c |   34 ------------------------------
 1 files changed, 0 insertions(+), 34 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3stalker.c b/arch/arm/mach-omap2/board-omap3stalker.c
index 8ab99f1..106a2ba 100644
--- a/arch/arm/mach-omap2/board-omap3stalker.c
+++ b/arch/arm/mach-omap2/board-omap3stalker.c
@@ -108,39 +108,6 @@ static void __init omap3_stalker_display_init(void)
 	return;
 }
 
-static int omap3_stalker_enable_lcd(struct omap_dss_device *dssdev)
-{
-	if (dvi_enabled) {
-		printk(KERN_ERR "cannot enable LCD, DVI is enabled\n");
-		return -EINVAL;
-	}
-	gpio_set_value(DSS_ENABLE_GPIO, 1);
-	gpio_set_value(LCD_PANEL_BKLIGHT_GPIO, 1);
-	lcd_enabled = 1;
-	return 0;
-}
-
-static void omap3_stalker_disable_lcd(struct omap_dss_device *dssdev)
-{
-	gpio_set_value(DSS_ENABLE_GPIO, 0);
-	gpio_set_value(LCD_PANEL_BKLIGHT_GPIO, 0);
-	lcd_enabled = 0;
-}
-
-static struct panel_generic_dpi_data lcd_panel = {
-	.name			= "generic",
-	.platform_enable	= omap3_stalker_enable_lcd,
-	.platform_disable	= omap3_stalker_disable_lcd,
-};
-
-static struct omap_dss_device omap3_stalker_lcd_device = {
-	.name			= "lcd",
-	.driver_name		= "generic_dpi_panel",
-	.data			= &lcd_panel,
-	.phy.dpi.data_lines	= 24,
-	.type			= OMAP_DISPLAY_TYPE_DPI,
-};
-
 static int omap3_stalker_enable_tv(struct omap_dss_device *dssdev)
 {
 	return 0;
@@ -194,7 +161,6 @@ static struct omap_dss_device omap3_stalker_dvi_device = {
 };
 
 static struct omap_dss_device *omap3_stalker_dss_devices[] = {
-	&omap3_stalker_lcd_device,
 	&omap3_stalker_tv_device,
 	&omap3_stalker_dvi_device,
 };
-- 
1.7.4.1


  parent reply	other threads:[~2011-09-20  8:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20  8:18 [PATCH 00/10] OMAP DSS related board changes Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 01/10] OMAP: DSS2: Change DSI device naming Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 02/10] OMAP4: TWL: Add common omapdss supplies Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 03/10] OMAP: Devkit8000: Change lcd driver to AT070TN83 Tomi Valkeinen
2011-09-20 12:35   ` Thomas Weber
2011-09-20 12:37     ` Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 04/10] OMAP: DSS2: HDMI: use default dividers Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 05/10] OMAP: use dvi panel driver instead of generic-dpi Tomi Valkeinen
2011-09-20  8:18 ` Tomi Valkeinen [this message]
2011-09-20  8:18 ` [PATCH 07/10] OMAP: Add DDC i2c_bus_num to board files Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 08/10] OMAP: 4430SDP: Remove unneeded lcd config Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 09/10] OMAP4: 4430SDP: Add panel support to board file Tomi Valkeinen
2011-09-20  8:18 ` [PATCH 10/10] OMAP4: 4430SDP: Add picodlp " Tomi Valkeinen
2011-09-26  6:37 ` [PATCH 00/10] OMAP DSS related board changes Tomi Valkeinen
2011-09-29 17:52   ` Tony Lindgren
2011-09-30  5:20     ` Tomi Valkeinen
2011-10-04  0:32       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316506706-18941-7-git-send-email-tomi.valkeinen@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lzg@ema-tech.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.