* [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks
@ 2011-09-22 10:02 Marek Szyprowski
2011-09-22 17:05 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2011-09-22 10:02 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kyungmin Park, Kukjin Kim, Angus Ainslie, Grant Likely
Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO
SoCs. The new driver doesn't work correctly on Samsung Exynos4 SoC. It
fails to set configuration for all but external interrupt pins. This
patch fixes this issue.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/gpio/gpio-samsung.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index 36f3675..be13580 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -446,6 +446,8 @@ static struct samsung_gpio_cfg s3c24xx_gpiocfg_banka = {
static struct samsung_gpio_cfg exynos4_gpio_cfg = {
.set_pull = exynos4_gpio_setpull,
.get_pull = exynos4_gpio_getpull,
+ .set_config = samsung_gpio_setcfg_4bit,
+ .get_config = samsung_gpio_getcfg_4bit,
};
static struct samsung_gpio_cfg s5p64x0_gpio_cfg_rbank = {
--
1.7.1.569.g6f426
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks
2011-09-22 10:02 [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks Marek Szyprowski
@ 2011-09-22 17:05 ` Grant Likely
2011-09-26 4:22 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2011-09-22 17:05 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, Kyungmin Park, Kukjin Kim, Angus Ainslie
On Thu, Sep 22, 2011 at 12:02:39PM +0200, Marek Szyprowski wrote:
> Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO
> SoCs. The new driver doesn't work correctly on Samsung Exynos4 SoC. It
> fails to set configuration for all but external interrupt pins. This
> patch fixes this issue.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/gpio/gpio-samsung.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 36f3675..be13580 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -446,6 +446,8 @@ static struct samsung_gpio_cfg s3c24xx_gpiocfg_banka = {
> static struct samsung_gpio_cfg exynos4_gpio_cfg = {
> .set_pull = exynos4_gpio_setpull,
> .get_pull = exynos4_gpio_getpull,
> + .set_config = samsung_gpio_setcfg_4bit,
> + .get_config = samsung_gpio_getcfg_4bit,
> };
>
> static struct samsung_gpio_cfg s5p64x0_gpio_cfg_rbank = {
> --
> 1.7.1.569.g6f426
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks
2011-09-22 17:05 ` Grant Likely
@ 2011-09-26 4:22 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2011-09-26 4:22 UTC (permalink / raw)
To: 'Grant Likely', 'Marek Szyprowski'
Cc: linux-samsung-soc, 'Kyungmin Park', 'Angus Ainslie'
Grant Likely wrote:
>
> On Thu, Sep 22, 2011 at 12:02:39PM +0200, Marek Szyprowski wrote:
> > Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO
> > SoCs. The new driver doesn't work correctly on Samsung Exynos4 SoC. It
> > fails to set configuration for all but external interrupt pins. This
> > patch fixes this issue.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
> > ---
> > drivers/gpio/gpio-samsung.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 36f3675..be13580 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -446,6 +446,8 @@ static struct samsung_gpio_cfg s3c24xx_gpiocfg_banka
> = {
> > static struct samsung_gpio_cfg exynos4_gpio_cfg = {
> > .set_pull = exynos4_gpio_setpull,
> > .get_pull = exynos4_gpio_getpull,
> > + .set_config = samsung_gpio_setcfg_4bit,
> > + .get_config = samsung_gpio_getcfg_4bit,
> > };
> >
> > static struct samsung_gpio_cfg s5p64x0_gpio_cfg_rbank = {
> > --
> > 1.7.1.569.g6f426
> >
Oops :(
You're right, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-26 4:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-22 10:02 [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks Marek Szyprowski
2011-09-22 17:05 ` Grant Likely
2011-09-26 4:22 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.